mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-03 06:55:49 +01:00
c93a0e5e42
See arena.h for discussion of what canonicalization means in this context. This is primarily intended to support implementing a memo table of template instantiations to resolve #2951, but could be useful for other purposes as well. Additional changes: - Pass `VTable` constructor parameters by pointer, to avoid the need to define `operator==` and `hash_value` for it. - Clean up the recurring pattern of allocating identical `NamedElement`s on the stack and heap. Instead we always allocate it on the heap and pass it by pointer. - Add `Print()` and `Dump()` to `Bindings` as a debugging convenience. --------- Co-authored-by: Jon Ross-Perkins <jperkins@google.com> Co-authored-by: Richard Smith <richard@metafoo.co.uk>
97 lines
2.4 KiB
C++
97 lines
2.4 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "explorer/common/arena.h"
|
|
|
|
#include <gtest/gtest.h>
|
|
|
|
#include <optional>
|
|
#include <vector>
|
|
|
|
namespace Carbon {
|
|
|
|
class ReportDestruction {
|
|
public:
|
|
explicit ReportDestruction(bool* destroyed) : destroyed_(destroyed) {}
|
|
|
|
~ReportDestruction() { *destroyed_ = true; }
|
|
|
|
private:
|
|
bool* destroyed_;
|
|
};
|
|
|
|
TEST(ArenaTest, BasicAllocation) {
|
|
bool destroyed = false;
|
|
{
|
|
Arena arena;
|
|
(void)arena.New<ReportDestruction>(&destroyed);
|
|
}
|
|
EXPECT_TRUE(destroyed);
|
|
}
|
|
|
|
struct CanonicalizedDummy {
|
|
explicit CanonicalizedDummy(int) {}
|
|
explicit CanonicalizedDummy(int*) {}
|
|
explicit CanonicalizedDummy(int, int*) {}
|
|
explicit CanonicalizedDummy(std::vector<int>, std::nullopt_t) {}
|
|
using EnableCanonicalizedAllocation = void;
|
|
};
|
|
|
|
TEST(ArenaTest, Canonicalize) {
|
|
Arena arena;
|
|
auto* dummy1 = arena.New<CanonicalizedDummy>(1);
|
|
EXPECT_TRUE(std::is_const_v<std::remove_pointer_t<decltype(dummy1)>>);
|
|
auto* dummy2 = arena.New<CanonicalizedDummy>(1);
|
|
EXPECT_TRUE(dummy1 == dummy2);
|
|
}
|
|
|
|
TEST(ArenaTest, CanonicalizeArgMismatch) {
|
|
Arena arena;
|
|
auto* dummy1 = arena.New<CanonicalizedDummy>(1);
|
|
auto* dummy2 = arena.New<CanonicalizedDummy>(2);
|
|
EXPECT_TRUE(dummy1 != dummy2);
|
|
}
|
|
|
|
TEST(ArenaTest, CanonicalizeDifferentArenas) {
|
|
Arena arena1;
|
|
Arena arena2;
|
|
auto* dummy1 = arena1.New<CanonicalizedDummy>(1);
|
|
auto* dummy2 = arena2.New<CanonicalizedDummy>(1);
|
|
|
|
EXPECT_TRUE(dummy1 != dummy2);
|
|
}
|
|
|
|
TEST(ArenaTest, CanonicalizeIsShallow) {
|
|
Arena arena;
|
|
int i1 = 1;
|
|
int i2 = 1;
|
|
auto* dummy1 = arena.New<CanonicalizedDummy>(&i1);
|
|
auto* dummy2 = arena.New<CanonicalizedDummy>(&i2);
|
|
EXPECT_TRUE(dummy1 != dummy2);
|
|
}
|
|
|
|
TEST(ArenaTest, CanonicalizeMultipleArgs) {
|
|
Arena arena;
|
|
int i;
|
|
auto* dummy1 = arena.New<CanonicalizedDummy>(1, &i);
|
|
auto* dummy2 = arena.New<CanonicalizedDummy>(1, &i);
|
|
EXPECT_TRUE(dummy1 == dummy2);
|
|
}
|
|
|
|
TEST(ArenaTest, CanonicalizeStdTypes) {
|
|
Arena arena;
|
|
std::vector<int> v1 = {1, 2, 3};
|
|
std::vector<int> v2 = {1, 2, 3};
|
|
std::vector<int> v3 = {1, 2, 3, 4};
|
|
|
|
auto* dummy1 = arena.New<CanonicalizedDummy>(v1, std::nullopt);
|
|
auto* dummy2 = arena.New<CanonicalizedDummy>(v2, std::nullopt);
|
|
EXPECT_TRUE(dummy1 == dummy2);
|
|
|
|
auto* dummy3 = arena.New<CanonicalizedDummy>(v3, std::nullopt);
|
|
EXPECT_TRUE(dummy1 != dummy3);
|
|
}
|
|
|
|
} // namespace Carbon
|