Files
carbon-lang/toolchain/diagnostics/check_diagnostics.py
T
Chandler CarruthandGeoff Romer 2b9fdd6e42 Fix the check that every registered diagnostic kind is declared (#7660)
`load_diagnostic_kind` matched `^\s+CARBON_DIAGNOSTIC_KIND` without
`re.MULTILINE` against a file whose entries start at column zero, so it
found nothing: `check_unused` was comparing an empty set of declarations
against every use and reporting nothing at all. The check has never run.

With it running, three kinds turn out to be registered and never
declared, and go: `BuildFailureRunningClangToLink`,
`BuildOutputFileOpenError`, and `BuildPreludeManifestError`.

`load_diagnostic_uses_in` looked only for `CARBON_DIAGNOSTIC`, so a
diagnostic declared with `CARBON_DIAGNOSTIC_ON_SCOPE` counted as unused,
and it read the two macros' own definitions in `diagnostic.h` as uses.
Both are why the kinds above could not simply be deleted before.

Assisted-by: Claude Code

---------

Co-authored-by: Geoff Romer <gromer@google.com>
2026-08-21 22:21:54 +00:00

139 lines
3.8 KiB
Python
Executable File

#!/usr/bin/env -S uv run --script
# /// script
# requires-python = ">=3.12"
# ///
"""Checks diagnostic use.
Validates that each diagnostic declared with CARBON_DIAGNOSTIC_KIND is
referenced by one (and only one) CARBON_DIAGNOSTIC.
"""
__copyright__ = """
Part of the Carbon Language project, under the Apache License v2.0 with LLVM
Exceptions. See /LICENSE for license information.
SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
"""
import collections
import itertools
import os
import re
import sys
from concurrent import futures
from pathlib import Path
from typing import Dict, List, NamedTuple, Set, override
# Example or test diagnostics, ignored because they're expected to not pass.
IGNORED = set(
[
"MyDiagnostic",
"TestDiagnostic",
"TestDiagnosticContext",
"TestDiagnosticNote",
"TestDiagnosticSoftContext",
]
)
class Loc(NamedTuple):
"""A location for a diagnostic."""
@override
def __str__(self) -> str:
return f"{str(self.path)}:{self.line}"
path: Path
line: int
def load_diagnostic_kind() -> Set[str]:
"""Returns the set of declared diagnostic kinds.
This isn't validated for uniqueness because the compiler does that.
"""
path = Path("toolchain/diagnostics/kind.def")
content = path.read_text()
decls = set(
re.findall(r"^CARBON_DIAGNOSTIC_KIND\((.+)\)", content, flags=re.M)
)
return decls.difference(IGNORED)
def load_diagnostic_uses_in(
path: Path,
) -> Dict[str, List[Loc]]:
"""Returns the path's CARBON_DIAGNOSTIC uses."""
content = path.read_text()
# Keep a line cursor so that we don't keep re-scanning the file.
line = 1
line_offset = 0
found: Dict[str, List[Loc]] = collections.defaultdict(lambda: [])
# `CARBON_DIAGNOSTIC_ON_SCOPE` declares a diagnostic too; the definitions of
# both macros name their own parameter, which is not a use.
for m in re.finditer(
r"(?<!#define )CARBON_DIAGNOSTIC(?:_ON_SCOPE)?\(\s*(\w+),", content
):
diag = m.group(1)
if diag in IGNORED or diag in ("DiagnosticName",):
continue
line += content.count("\n", line_offset, m.start())
line_offset = m.start()
found[diag].append(Loc(path, line))
return found
def load_diagnostic_uses() -> Dict[str, List[Loc]]:
"""Returns all CARBON_DIAGNOSTIC uses."""
globs = itertools.chain(
*[Path("toolchain").glob(f"**/*.{ext}") for ext in ("h", "cpp")]
)
with futures.ThreadPoolExecutor() as exec:
results = exec.map(load_diagnostic_uses_in, globs)
found: Dict[str, List[Loc]] = collections.defaultdict(lambda: [])
for result in results:
for diag, locations in result.items():
found[diag].extend(locations)
return found
def check_uniqueness(uses: Dict[str, List[Loc]]) -> bool:
"""If any diagnostic is non-unique, prints an error and returns true."""
has_errors = False
for diag in sorted(uses.keys()):
if len(uses[diag]) > 1:
print(f"Non-unique diagnostic {diag}:", file=sys.stderr)
for loc in uses[diag]:
print(f" - {loc}", file=sys.stderr)
has_errors = True
return has_errors
def check_unused(decls: Set[str], uses: Dict[str, List[Loc]]) -> bool:
"""If any diagnostic is unused, prints an error and returns true."""
unused = decls.difference(uses.keys())
if not unused:
return False
for diag in sorted(unused):
print(f"Unused diagnostic: {diag}")
return True
def main() -> None:
# Run from the repo root.
os.chdir(Path(__file__).parents[2])
decls = load_diagnostic_kind()
uses = load_diagnostic_uses()
if any([check_uniqueness(uses), check_unused(decls, uses)]):
exit(1)
if __name__ == "__main__":
main()