mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-30 21:05:02 +01:00
ATHARVAandDana Jansens
804359dce0
If a Carbon class overrides virtual functions from a C++ base class but is never referenced from C++, it is never exported to Clang. During lowering, `BuildVtable` then fails to find a `CXXRecordDecl` and crashes when attempting to get the vtable from Clang's code generator. Ensure dynamic classes with foreign vtables are exported to Clang when completing the class definition in `CheckCompleteClassType`, and look up `first_decl_id()` in `BuildVtable`. Fixes #7721 --------- Co-authored-by: Dana Jansens <danakj@orodu.net>
81 lines
1.9 KiB
Plaintext
81 lines
1.9 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// INCLUDE-FILE: toolchain/testing/testdata/min_prelude/destroy.carbon
|
|
// EXTRA-ARGS: --share-cpp-ast
|
|
//
|
|
// AUTOUPDATE
|
|
// TIP: To test this file alone, run:
|
|
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/interop/cpp/class/export/override.carbon
|
|
// TIP: To dump output, run:
|
|
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/interop/cpp/class/export/override.carbon
|
|
|
|
// --- const_ref_param.carbon
|
|
library "[[@TEST_NAME]]";
|
|
import Cpp;
|
|
|
|
inline Cpp '''
|
|
struct X {};
|
|
|
|
struct A {
|
|
virtual void f(const X& x) = 0;
|
|
};
|
|
''';
|
|
|
|
class B {
|
|
extend base: Cpp.A;
|
|
override fn f(unused self, unused x: Cpp.X) {}
|
|
}
|
|
|
|
inline Cpp '''
|
|
Carbon::B b;
|
|
''';
|
|
|
|
// --- base.h
|
|
struct Base {
|
|
virtual ~Base();
|
|
virtual void F() = 0;
|
|
};
|
|
|
|
// --- derived.carbon
|
|
library "derived";
|
|
import Cpp library "base.h";
|
|
|
|
class Derived {
|
|
extend base: Cpp.Base;
|
|
override fn F(unused self) {}
|
|
}
|
|
|
|
// --- imported.carbon
|
|
library "imported";
|
|
import Cpp library "base.h";
|
|
import library "derived";
|
|
|
|
inline Cpp '''
|
|
void Test() {
|
|
Carbon::Derived d;
|
|
}
|
|
''';
|
|
|
|
// --- fail_todo_generic.carbon
|
|
// TODO: Test in `toolchain/lower/testdata/` once generic classes deriving from
|
|
// C++ virtual classes pass check.
|
|
library "[[@TEST_NAME]]";
|
|
import Cpp;
|
|
|
|
inline Cpp '''
|
|
struct VBase {
|
|
virtual void f() {}
|
|
};
|
|
''';
|
|
|
|
// CHECK:STDERR: fail_todo_generic.carbon:[[@LINE+4]]:1: error: semantics TODO: `generic class deriving from C++ virtual class` [SemanticsTodo]
|
|
// CHECK:STDERR: class GenericZ(T: type) {
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
class GenericZ(T: type) {
|
|
extend base: Cpp.VBase;
|
|
override fn f(unused self) {}
|
|
}
|