mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-01 08:15:01 +01:00
Chandler Carruth
8be274cf60
Implement the toolchain side of proposal #7254, removing the `:!` binding syntax for generic and template parameters in favor of the keywords `generic`, `template`, and `runtime` plus contextual defaults for phase. For valid programs this is semantics-preserving: each binding resolves to the same phase, and produces the same SemIR, as it did under `:!`/`:`. The parser derives a binding's phase from its syntactic context plus any explicit phase keyword; new diagnostics and error recovery for misused keywords are described below. Implementation details for each component: - Lexer: remove the `:!` (`ColonExclaim`) token, move its virtual parse-node budget onto `:`, and add the `generic` and `runtime` keywords. - Parser: thread a `BindingContext` (`ExplicitParam`, `DeducedParam`, or `CompileTimeEntityParam`) from declaration introducers down through parameter lists to each binding pattern, using a one-token lookahead to distinguish a name-qualifier parameter list from a declaration's own final list. Parameters of a compile-time entity (`class`, `interface`, `constraint`, `choice`, `alias`, `export`, `namespace`) and deduced `[]` parameters default to checked generic; explicit function parameters and local bindings default to runtime. `HandleBindingPattern` resolves the phase from that context plus the keyword: a `generic` keyword needs no node of its own (the phase is carried by the binding's node kind), while a `runtime` keyword is preserved as a `RuntimeBindingName` node so `check` can name it in a diagnostic. A phase keyword that is merely redundant with the contextual default is diagnosed here, without invalidating the parse tree. - Check: a phase keyword that is invalid for its context (for example `runtime` on a checked-generic parameter) is diagnosed here, and recovers by building an error binding that still introduces the name so that later uses of it do not produce cascading errors. The removed `:!` syntax is now rejected as an ordinary parse error. The `form`/`:?`/`->?` ("extended types") portion of proposal #7254 is left for a separate change. Assisted-by: Claude Code
182 lines
6.2 KiB
Plaintext
182 lines
6.2 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// INCLUDE-FILE: toolchain/testing/testdata/min_prelude/none.carbon
|
|
//
|
|
// AUTOUPDATE
|
|
// TIP: To test this file alone, run:
|
|
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/impl/impl_self_as.carbon
|
|
// TIP: To dump output, run:
|
|
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/impl/impl_self_as.carbon
|
|
|
|
// --- match.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface I1 {}
|
|
interface I2 {}
|
|
interface J1(T1: type) {}
|
|
interface J2(T2: type) {}
|
|
|
|
// `impl Self as` should match `impl as`, so these should not trigger impl
|
|
// declaration without definition diagnostics.
|
|
|
|
class C1 {
|
|
impl Self as I1;
|
|
impl as I1 {}
|
|
|
|
impl as I2;
|
|
impl Self as I2 {}
|
|
|
|
impl forall [U: type] Self as J1(U);
|
|
impl forall [U: type] as J1(U) {}
|
|
|
|
impl forall [V: type] as J2(V);
|
|
impl forall [V: type] Self as J2(V) {}
|
|
}
|
|
|
|
class C2(W: type) {
|
|
impl Self as I1;
|
|
impl as I1 {}
|
|
|
|
impl as I2;
|
|
impl Self as I2 {}
|
|
|
|
impl forall [X: type] Self as J1(X);
|
|
impl forall [X: type] as J1(X) {}
|
|
|
|
impl forall [Y: type] as J2(Y);
|
|
impl forall [Y: type] Self as J2(Y) {}
|
|
}
|
|
|
|
|
|
// --- fail_no_match.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
interface I3 {}
|
|
interface I4 {}
|
|
interface I5 {}
|
|
interface I6 {}
|
|
interface J3(T3: type) {}
|
|
interface J4(T4: type) {}
|
|
interface J5(T5: type) {}
|
|
interface J6(T6: type) {}
|
|
|
|
// `impl C as` should not match `impl Self as` or `impl as`.
|
|
|
|
class C3 {
|
|
// CHECK:STDERR: fail_no_match.carbon:[[@LINE+4]]:3: error: impl declared but not defined [ImplMissingDefinition]
|
|
// CHECK:STDERR: impl C3 as I3;
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
impl C3 as I3;
|
|
impl as I3 {}
|
|
|
|
// CHECK:STDERR: fail_no_match.carbon:[[@LINE+4]]:3: error: impl declared but not defined [ImplMissingDefinition]
|
|
// CHECK:STDERR: impl C3 as I4;
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
impl C3 as I4;
|
|
impl Self as I4 {}
|
|
|
|
// CHECK:STDERR: fail_no_match.carbon:[[@LINE+4]]:3: error: impl declared but not defined [ImplMissingDefinition]
|
|
// CHECK:STDERR: impl as I5;
|
|
// CHECK:STDERR: ^~~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
impl as I5;
|
|
impl C3 as I5 {}
|
|
|
|
// CHECK:STDERR: fail_no_match.carbon:[[@LINE+4]]:3: error: impl declared but not defined [ImplMissingDefinition]
|
|
// CHECK:STDERR: impl Self as I6;
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
impl Self as I6;
|
|
impl C3 as I6 {}
|
|
|
|
// CHECK:STDERR: fail_no_match.carbon:[[@LINE+4]]:3: error: impl declared but not defined [ImplMissingDefinition]
|
|
// CHECK:STDERR: impl forall [Z3: type] C3 as J3(Z3);
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
impl forall [Z3: type] C3 as J3(Z3);
|
|
impl forall [Z3: type] as J3(Z3) {}
|
|
|
|
// CHECK:STDERR: fail_no_match.carbon:[[@LINE+4]]:3: error: impl declared but not defined [ImplMissingDefinition]
|
|
// CHECK:STDERR: impl forall [Z4: type] C3 as J4(Z4);
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
impl forall [Z4: type] C3 as J4(Z4);
|
|
impl forall [Z4: type] Self as J4(Z4) {}
|
|
|
|
// CHECK:STDERR: fail_no_match.carbon:[[@LINE+4]]:3: error: impl declared but not defined [ImplMissingDefinition]
|
|
// CHECK:STDERR: impl forall [Z5: type] as J5(Z5);
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
impl forall [Z5: type] as J5(Z5);
|
|
impl forall [Z5: type] C3 as J5(Z5) {}
|
|
|
|
// CHECK:STDERR: fail_no_match.carbon:[[@LINE+4]]:3: error: impl declared but not defined [ImplMissingDefinition]
|
|
// CHECK:STDERR: impl forall [Z6: type] Self as J6(Z6);
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
impl forall [Z6: type] Self as J6(Z6);
|
|
impl forall [Z6: type] C3 as J6(Z6) {}
|
|
}
|
|
|
|
class C4(A: type) {
|
|
// CHECK:STDERR: fail_no_match.carbon:[[@LINE+4]]:3: error: impl declared but not defined [ImplMissingDefinition]
|
|
// CHECK:STDERR: impl C4(A) as I3;
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
impl C4(A) as I3;
|
|
impl as I3 {}
|
|
|
|
// CHECK:STDERR: fail_no_match.carbon:[[@LINE+4]]:3: error: impl declared but not defined [ImplMissingDefinition]
|
|
// CHECK:STDERR: impl C4(A) as I4;
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
impl C4(A) as I4;
|
|
impl Self as I4 {}
|
|
|
|
// CHECK:STDERR: fail_no_match.carbon:[[@LINE+4]]:3: error: impl declared but not defined [ImplMissingDefinition]
|
|
// CHECK:STDERR: impl as I5;
|
|
// CHECK:STDERR: ^~~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
impl as I5;
|
|
impl C4(A) as I5 {}
|
|
|
|
// CHECK:STDERR: fail_no_match.carbon:[[@LINE+4]]:3: error: impl declared but not defined [ImplMissingDefinition]
|
|
// CHECK:STDERR: impl Self as I6;
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
impl Self as I6;
|
|
impl C4(A) as I6 {}
|
|
|
|
// CHECK:STDERR: fail_no_match.carbon:[[@LINE+4]]:3: error: impl declared but not defined [ImplMissingDefinition]
|
|
// CHECK:STDERR: impl forall [B3: type] C4(A) as J3(B3);
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
impl forall [B3: type] C4(A) as J3(B3);
|
|
impl forall [B3: type] as J3(B3) {}
|
|
|
|
// CHECK:STDERR: fail_no_match.carbon:[[@LINE+4]]:3: error: impl declared but not defined [ImplMissingDefinition]
|
|
// CHECK:STDERR: impl forall [B4: type] C4(A) as J4(B4);
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
impl forall [B4: type] C4(A) as J4(B4);
|
|
impl forall [B4: type] Self as J4(B4) {}
|
|
|
|
// CHECK:STDERR: fail_no_match.carbon:[[@LINE+4]]:3: error: impl declared but not defined [ImplMissingDefinition]
|
|
// CHECK:STDERR: impl forall [B5: type] as J5(B5);
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
impl forall [B5: type] as J5(B5);
|
|
impl forall [B5: type] C4(A) as J5(B5) {}
|
|
|
|
// CHECK:STDERR: fail_no_match.carbon:[[@LINE+4]]:3: error: impl declared but not defined [ImplMissingDefinition]
|
|
// CHECK:STDERR: impl forall [B6: type] Self as J6(B6);
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
// CHECK:STDERR:
|
|
impl forall [B6: type] Self as J6(B6);
|
|
impl forall [B6: type] C4(A) as J6(B6) {}
|
|
}
|