mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 20:40:11 +01:00
Chandler Carruth
8be274cf60
Implement the toolchain side of proposal #7254, removing the `:!` binding syntax for generic and template parameters in favor of the keywords `generic`, `template`, and `runtime` plus contextual defaults for phase. For valid programs this is semantics-preserving: each binding resolves to the same phase, and produces the same SemIR, as it did under `:!`/`:`. The parser derives a binding's phase from its syntactic context plus any explicit phase keyword; new diagnostics and error recovery for misused keywords are described below. Implementation details for each component: - Lexer: remove the `:!` (`ColonExclaim`) token, move its virtual parse-node budget onto `:`, and add the `generic` and `runtime` keywords. - Parser: thread a `BindingContext` (`ExplicitParam`, `DeducedParam`, or `CompileTimeEntityParam`) from declaration introducers down through parameter lists to each binding pattern, using a one-token lookahead to distinguish a name-qualifier parameter list from a declaration's own final list. Parameters of a compile-time entity (`class`, `interface`, `constraint`, `choice`, `alias`, `export`, `namespace`) and deduced `[]` parameters default to checked generic; explicit function parameters and local bindings default to runtime. `HandleBindingPattern` resolves the phase from that context plus the keyword: a `generic` keyword needs no node of its own (the phase is carried by the binding's node kind), while a `runtime` keyword is preserved as a `RuntimeBindingName` node so `check` can name it in a diagnostic. A phase keyword that is merely redundant with the contextual default is diagnosed here, without invalidating the parse tree. - Check: a phase keyword that is invalid for its context (for example `runtime` on a checked-generic parameter) is diagnosed here, and recovers by building an error binding that still introduces the name so that later uses of it do not produce cascading errors. The removed `:!` syntax is now rejected as an ordinary parse error. The `form`/`:?`/`->?` ("extended types") portion of proposal #7254 is left for a separate change. Assisted-by: Claude Code
49 lines
1.5 KiB
Plaintext
49 lines
1.5 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// INCLUDE-FILE: toolchain/testing/testdata/min_prelude/convert.carbon
|
|
//
|
|
// AUTOUPDATE
|
|
// TIP: To test this file alone, run:
|
|
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/impl/lookup/struct.carbon
|
|
// TIP: To dump output, run:
|
|
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/impl/lookup/struct.carbon
|
|
|
|
interface Z {
|
|
let X: type;
|
|
fn ZZ() -> X;
|
|
}
|
|
|
|
class C { adapt (); }
|
|
class D { adapt (); }
|
|
|
|
impl {.a: (), .b: ()} as Z where .X = C {
|
|
fn ZZ() -> C { return () as C; }
|
|
}
|
|
|
|
// A struct with different field names. Structs with different field names are
|
|
// different types and can be matched by an impl lookup with matching field
|
|
// names.
|
|
impl {.aa: (), .bb: ()} as Z where .X = D {
|
|
fn ZZ() -> D { return () as D; }
|
|
}
|
|
|
|
// Structs with different field orders are different types too, for impl
|
|
// lookup. See https://github.com/carbon-language/carbon-lang/issues/5413.
|
|
impl {.b: (), .a: ()} as Z where .X = D {
|
|
fn ZZ() -> D { return () as D; }
|
|
}
|
|
|
|
fn F(generic T: Z) -> T.X {
|
|
return T.ZZ();
|
|
}
|
|
|
|
fn G() {
|
|
// Check which impl is selected for struct literals with different field
|
|
// names.
|
|
let unused c1: C = F({.a: (), .b: ()});
|
|
let unused d1: D = F({.aa: (), .bb: ()});
|
|
let unused d2: D = F({.b: (), .a: ()});
|
|
}
|