mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 21:40:12 +01:00
I'm doing this to avoid macro name conflicts, following https://google.github.io/styleguide/cppguide.html#Preprocessor_Macros: "If you do export a macro from a header, it must have a globally unique name. To achieve this, it must be named with a prefix consisting of your project's namespace name (but upper case)." Commands run: ``` sed -i 's/\(DCHECK\|CHECK\|FATAL\|MAKE_UNIQUE_NAME\|MAKE_UNIQUE_NAME_IMPL\|RAW_EXITING_STREAM\|RETURN_IF_ERROR\|RETURN_IF_ERROR_IMPL\|ASSIGN_OR_RETURN\|ASSIGN_OR_RETURN_IMPL\|DIAGNOSTIC_KIND\|RETURN_IF_STACK_LIMITED\)(/CARBON_\1(/g' $(git ls-files *.cpp *.h *.lpp *.ypp *.def ':!third_party') sed -i 's/#undef DIAGNOSTIC_KIND/#undef CARBON_DIAGNOSTIC_KIND/' toolchain/diagnostics/diagnostic_registry.def ``` Note this isn't *quite* everything, but it's intended to be a large pass at everything: ``` ╚╡git grep '#define ' *.cpp *.h *.lpp *.ypp *.def ':!third_party' | grep -v '#define CARBON' | grep -v _H_ explorer/syntax/lexer.lpp: #define YY_USER_ACTION \ explorer/syntax/lexer.lpp: #define SIMPLE_TOKEN(name) \ explorer/syntax/lexer.lpp: #define ARG_TOKEN(name, arg) \ explorer/syntax/parse_and_lex_context.h:#define YY_DECL \ migrate_cpp/cpp_refactoring/var_decl.cpp:#define ABSTRACT_TYPE(Class, Base) migrate_cpp/cpp_refactoring/var_decl.cpp:#define TYPE(Class, Base) \ ``` We may in particular want to do a pass to clean up #ifdef guards and make them be CARBON_ rooted.
58 lines
1.5 KiB
C++
58 lines
1.5 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "common/check.h"
|
|
|
|
#include <gtest/gtest.h>
|
|
|
|
namespace Carbon::Testing {
|
|
namespace {
|
|
|
|
TEST(CheckTest, CheckTrue) { CARBON_CHECK(true); }
|
|
|
|
TEST(CheckTest, CheckFalse) {
|
|
// TODO: figure out why we can't use \\d+ instead of .+ in these patterns.
|
|
ASSERT_DEATH({ CARBON_CHECK(false); },
|
|
"Stack trace:\n"
|
|
".+\n"
|
|
"CHECK failure at common/check_test.cpp:.+: false\n");
|
|
}
|
|
|
|
TEST(CheckTest, CheckTrueCallbackNotUsed) {
|
|
bool called = false;
|
|
auto callback = [&]() {
|
|
called = true;
|
|
return "called";
|
|
};
|
|
CARBON_CHECK(true) << callback();
|
|
EXPECT_FALSE(called);
|
|
}
|
|
|
|
TEST(CheckTest, CheckFalseMessage) {
|
|
ASSERT_DEATH({ CARBON_CHECK(false) << "msg"; },
|
|
"CHECK failure at common/check_test.cpp:.+: false: msg\n");
|
|
}
|
|
|
|
TEST(CheckTest, CheckOutputForms) {
|
|
const char msg[] = "msg";
|
|
std::string str = "str";
|
|
int i = 1;
|
|
CARBON_CHECK(true) << msg << str << i << 0;
|
|
}
|
|
|
|
TEST(CheckTest, Fatal) {
|
|
ASSERT_DEATH({ CARBON_FATAL() << "msg"; },
|
|
"FATAL failure at common/check_test.cpp:.+: msg\n");
|
|
}
|
|
|
|
auto FatalNoReturnRequired() -> int { CARBON_FATAL() << "msg"; }
|
|
|
|
TEST(ErrorTest, FatalNoReturnRequired) {
|
|
ASSERT_DEATH({ FatalNoReturnRequired(); },
|
|
"FATAL failure at common/check_test.cpp:.+: msg\n");
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace Carbon::Testing
|