mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 21:00:13 +01:00
When returning a value from a function whose return type has a by-copy initializing representation, perform initialization like we do when the return type has an in-place initializing representation. This makes our SemIR representation more uniform, as the return expression will now always be an initializing expression rather than a value expression, but more importantly it means that attempts to return a non-copyable type by value now fail, even if the type has a by-copy initializing representation. This catches a bunch of places where we were returning a value of an unconstrained template parameter `T:! type`, which we were incorrectly allowing because we didn't notice it was not copyable. Unfortunately this then requires quite a few test updates. Like #6034, this exposes a lowering issue where lowering crashes when attempting to lower a specific copy operation for certain types; a couple more tests are temporarily disabled here. An upcoming PR dependent on this one will fix the issue and re-enable those tests.
197 lines
7.8 KiB
C++
197 lines
7.8 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "toolchain/check/return.h"
|
|
|
|
#include "toolchain/check/context.h"
|
|
#include "toolchain/check/control_flow.h"
|
|
#include "toolchain/check/convert.h"
|
|
#include "toolchain/check/inst.h"
|
|
|
|
namespace Carbon::Check {
|
|
|
|
// Gets the function that lexically encloses the current location.
|
|
auto GetCurrentFunctionForReturn(Context& context) -> SemIR::Function& {
|
|
CARBON_CHECK(context.scope_stack().IsInFunctionScope(),
|
|
"Handling return but not in a function");
|
|
auto decl_id = context.scope_stack().GetReturnScopeDeclId();
|
|
auto function_id =
|
|
context.insts().GetAs<SemIR::FunctionDecl>(decl_id).function_id;
|
|
return context.functions().Get(function_id);
|
|
}
|
|
|
|
auto GetCurrentReturnSlot(Context& context) -> SemIR::InstId {
|
|
// TODO: this does some unnecessary work to compute non-lexical scopes,
|
|
// so a separate API on ScopeStack could be more efficient.
|
|
auto return_slot_id = context.scope_stack()
|
|
.LookupInLexicalScopes(SemIR::NameId::ReturnSlot)
|
|
.first;
|
|
return return_slot_id;
|
|
}
|
|
|
|
// Gets the currently in scope `returned var`, if any, that would be returned
|
|
// by a `return var;`.
|
|
static auto GetCurrentReturnedVar(Context& context) -> SemIR::InstId {
|
|
CARBON_CHECK(context.scope_stack().IsInFunctionScope(),
|
|
"Handling return but not in a function");
|
|
return context.scope_stack().GetReturnedVar();
|
|
}
|
|
|
|
// Produces a note that the given function has no explicit return type.
|
|
static auto NoteNoReturnTypeProvided(DiagnosticBuilder& diag,
|
|
const SemIR::Function& function) {
|
|
CARBON_DIAGNOSTIC(ReturnTypeOmittedNote, Note,
|
|
"there was no return type provided");
|
|
diag.Note(function.latest_decl_id(), ReturnTypeOmittedNote);
|
|
}
|
|
|
|
// Produces a note describing the return type of the given function, which
|
|
// must be a function whose definition is currently being checked.
|
|
static auto NoteReturnType(Context& context, DiagnosticBuilder& diag,
|
|
const SemIR::Function& function) {
|
|
auto out_param_pattern = context.insts().GetAs<SemIR::OutParamPattern>(
|
|
function.return_slot_pattern_id);
|
|
auto return_type_inst_id =
|
|
context.insts()
|
|
.GetAs<SemIR::ReturnSlotPattern>(out_param_pattern.subpattern_id)
|
|
.type_inst_id;
|
|
CARBON_DIAGNOSTIC(ReturnTypeHereNote, Note, "return type of function is {0}",
|
|
InstIdAsType);
|
|
diag.Note(function.return_slot_pattern_id, ReturnTypeHereNote,
|
|
return_type_inst_id);
|
|
}
|
|
|
|
// Produces a note pointing at the currently in scope `returned var`.
|
|
static auto NoteReturnedVar(DiagnosticBuilder& diag,
|
|
SemIR::InstId returned_var_id) {
|
|
CARBON_DIAGNOSTIC(ReturnedVarHere, Note, "`returned var` was declared here");
|
|
diag.Note(returned_var_id, ReturnedVarHere);
|
|
}
|
|
|
|
auto RegisterReturnedVar(Context& context, Parse::NodeId returned_node,
|
|
Parse::NodeId type_node, SemIR::TypeId type_id,
|
|
SemIR::InstId bind_id) -> void {
|
|
auto& function = GetCurrentFunctionForReturn(context);
|
|
auto return_info =
|
|
SemIR::ReturnTypeInfo::ForFunction(context.sem_ir(), function);
|
|
if (!return_info.is_valid()) {
|
|
// We already diagnosed this when we started defining the function.
|
|
return;
|
|
}
|
|
|
|
// A `returned var` requires an explicit return type.
|
|
if (!return_info.type_id.has_value()) {
|
|
CARBON_DIAGNOSTIC(ReturnedVarWithNoReturnType, Error,
|
|
"cannot declare a `returned var` in this function");
|
|
auto diag =
|
|
context.emitter().Build(returned_node, ReturnedVarWithNoReturnType);
|
|
NoteNoReturnTypeProvided(diag, function);
|
|
diag.Emit();
|
|
return;
|
|
}
|
|
|
|
// The declared type of the var must match the return type of the function.
|
|
if (return_info.type_id != type_id) {
|
|
CARBON_DIAGNOSTIC(ReturnedVarWrongType, Error,
|
|
"type {0} of `returned var` does not match "
|
|
"return type of enclosing function",
|
|
SemIR::TypeId);
|
|
auto diag =
|
|
context.emitter().Build(type_node, ReturnedVarWrongType, type_id);
|
|
NoteReturnType(context, diag, function);
|
|
diag.Emit();
|
|
}
|
|
|
|
auto existing_id = context.scope_stack().SetReturnedVarOrGetExisting(bind_id);
|
|
if (existing_id.has_value()) {
|
|
CARBON_DIAGNOSTIC(ReturnedVarShadowed, Error,
|
|
"cannot declare a `returned var` in the scope of "
|
|
"another `returned var`");
|
|
auto diag = context.emitter().Build(bind_id, ReturnedVarShadowed);
|
|
NoteReturnedVar(diag, existing_id);
|
|
diag.Emit();
|
|
}
|
|
}
|
|
|
|
auto BuildReturnWithNoExpr(Context& context, SemIR::LocId loc_id) -> void {
|
|
const auto& function = GetCurrentFunctionForReturn(context);
|
|
auto return_type_id = function.GetDeclaredReturnType(context.sem_ir());
|
|
|
|
if (return_type_id.has_value()) {
|
|
CARBON_DIAGNOSTIC(ReturnStatementMissingExpr, Error,
|
|
"missing return value");
|
|
auto diag = context.emitter().Build(loc_id, ReturnStatementMissingExpr);
|
|
NoteReturnType(context, diag, function);
|
|
diag.Emit();
|
|
}
|
|
|
|
AddReturnCleanupBlock(context, loc_id);
|
|
}
|
|
|
|
auto BuildReturnWithExpr(Context& context, SemIR::LocId loc_id,
|
|
SemIR::InstId expr_id) -> void {
|
|
const auto& function = GetCurrentFunctionForReturn(context);
|
|
auto returned_var_id = GetCurrentReturnedVar(context);
|
|
auto return_slot_id = SemIR::InstId::None;
|
|
auto return_info =
|
|
SemIR::ReturnTypeInfo::ForFunction(context.sem_ir(), function);
|
|
|
|
if (!return_info.type_id.has_value()) {
|
|
CARBON_DIAGNOSTIC(
|
|
ReturnStatementDisallowExpr, Error,
|
|
"no return expression should be provided in this context");
|
|
auto diag = context.emitter().Build(loc_id, ReturnStatementDisallowExpr);
|
|
NoteNoReturnTypeProvided(diag, function);
|
|
diag.Emit();
|
|
expr_id = SemIR::ErrorInst::InstId;
|
|
} else if (returned_var_id.has_value()) {
|
|
CARBON_DIAGNOSTIC(
|
|
ReturnExprWithReturnedVar, Error,
|
|
"can only `return var;` in the scope of a `returned var`");
|
|
auto diag = context.emitter().Build(loc_id, ReturnExprWithReturnedVar);
|
|
NoteReturnedVar(diag, returned_var_id);
|
|
diag.Emit();
|
|
expr_id = SemIR::ErrorInst::InstId;
|
|
} else if (!return_info.is_valid()) {
|
|
// We already diagnosed that the return type is invalid. Don't try to
|
|
// convert to it.
|
|
expr_id = SemIR::ErrorInst::InstId;
|
|
} else {
|
|
return_slot_id = GetCurrentReturnSlot(context);
|
|
CARBON_CHECK(return_slot_id.has_value());
|
|
expr_id = Initialize(context, loc_id, return_slot_id, expr_id);
|
|
}
|
|
|
|
AddReturnCleanupBlockWithExpr(
|
|
context, loc_id, {.expr_id = expr_id, .dest_id = return_slot_id});
|
|
}
|
|
|
|
auto BuildReturnVar(Context& context, Parse::ReturnStatementId node_id)
|
|
-> void {
|
|
const auto& function = GetCurrentFunctionForReturn(context);
|
|
auto returned_var_id = GetCurrentReturnedVar(context);
|
|
|
|
if (!returned_var_id.has_value()) {
|
|
CARBON_DIAGNOSTIC(ReturnVarWithNoReturnedVar, Error,
|
|
"`return var;` with no `returned var` in scope");
|
|
context.emitter().Emit(node_id, ReturnVarWithNoReturnedVar);
|
|
returned_var_id = SemIR::ErrorInst::InstId;
|
|
}
|
|
|
|
auto return_slot_id = GetCurrentReturnSlot(context);
|
|
if (!SemIR::ReturnTypeInfo::ForFunction(context.sem_ir(), function)
|
|
.has_return_slot()) {
|
|
// If we don't have a return slot, we're returning by value. Convert to a
|
|
// value expression.
|
|
returned_var_id = ConvertToValueExpr(context, returned_var_id);
|
|
return_slot_id = SemIR::InstId::None;
|
|
}
|
|
|
|
AddReturnCleanupBlockWithExpr(
|
|
context, node_id,
|
|
{.expr_id = returned_var_id, .dest_id = return_slot_id});
|
|
}
|
|
|
|
} // namespace Carbon::Check
|