mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 22:02:23 +01:00
Remove the type canonicalization mechanism and instead rely on constant canonicalization to deduplicate types. Rename the `Canonicalize*Type` functions to reflect that they're no longer performing canonicalization. Switch code that creates types due to semantic checking, rather than due to source syntax, to directly create type constants through evaluation rather than creating an instruction and evaluating it to produce a separate constant representation. The mapping from `const (const T)` that was previously performed by type canonicalization is now implemented in expression evaluation instead. The value `<error>` is now treated as a constant value, with a special property that an instruction involving `<error>` that could possibly be constant evaluates to `<error>`. This helps avoid producing follow-on errors when an error occurs as a subexpression of an expression, such as a type, that is intended to be constant.
140 lines
5.0 KiB
C++
140 lines
5.0 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "toolchain/check/context.h"
|
|
#include "toolchain/check/convert.h"
|
|
|
|
namespace Carbon::Check {
|
|
|
|
auto HandleStructLiteralOrStructTypeLiteralStart(
|
|
Context& context, Parse::StructLiteralOrStructTypeLiteralStartId parse_node)
|
|
-> bool {
|
|
context.PushScope();
|
|
context.node_stack().Push(parse_node);
|
|
// At this point we aren't sure whether this will be a value or type literal,
|
|
// so we push onto args irrespective. It just won't be used for a type
|
|
// literal.
|
|
context.args_type_info_stack().Push();
|
|
context.ParamOrArgStart();
|
|
return true;
|
|
}
|
|
|
|
auto HandleStructFieldDesignator(Context& context,
|
|
Parse::StructFieldDesignatorId /*parse_node*/)
|
|
-> bool {
|
|
// This leaves the designated name on top because the `.` isn't interesting.
|
|
CARBON_CHECK(context.node_stack().PeekIsName());
|
|
return true;
|
|
}
|
|
|
|
auto HandleStructComma(Context& context, Parse::StructCommaId /*parse_node*/)
|
|
-> bool {
|
|
context.ParamOrArgComma();
|
|
return true;
|
|
}
|
|
|
|
auto HandleStructFieldValue(Context& context,
|
|
Parse::StructFieldValueId parse_node) -> bool {
|
|
auto value_inst_id = context.node_stack().PopExpr();
|
|
auto [name_node, name_id] = context.node_stack().PopNameWithParseNode();
|
|
|
|
// Store the name for the type.
|
|
context.args_type_info_stack().AddInstId(context.AddInstInNoBlock(
|
|
{name_node, SemIR::StructTypeField{
|
|
name_id, context.insts().Get(value_inst_id).type_id()}}));
|
|
|
|
// Push the value back on the stack as an argument.
|
|
context.node_stack().Push(parse_node, value_inst_id);
|
|
return true;
|
|
}
|
|
|
|
auto HandleStructFieldType(Context& context,
|
|
Parse::StructFieldTypeId parse_node) -> bool {
|
|
auto [type_node, type_id] = context.node_stack().PopExprWithParseNode();
|
|
SemIR::TypeId cast_type_id = ExprAsType(context, type_node, type_id);
|
|
|
|
auto [name_node, name_id] = context.node_stack().PopNameWithParseNode();
|
|
|
|
auto inst_id = context.AddInst(
|
|
{name_node, SemIR::StructTypeField{name_id, cast_type_id}});
|
|
context.node_stack().Push(parse_node, inst_id);
|
|
return true;
|
|
}
|
|
|
|
static auto DiagnoseDuplicateNames(Context& context,
|
|
SemIR::InstBlockId type_block_id,
|
|
llvm::StringRef construct) -> bool {
|
|
auto& sem_ir = context.sem_ir();
|
|
auto fields = sem_ir.inst_blocks().Get(type_block_id);
|
|
llvm::SmallDenseMap<SemIR::NameId, SemIR::InstId> names;
|
|
auto& insts = sem_ir.insts();
|
|
for (SemIR::InstId field_inst_id : fields) {
|
|
auto field_inst = insts.GetAs<SemIR::StructTypeField>(field_inst_id);
|
|
auto [it, added] = names.insert({field_inst.name_id, field_inst_id});
|
|
if (!added) {
|
|
CARBON_DIAGNOSTIC(StructNameDuplicate, Error,
|
|
"Duplicated field name `{1}` in {0}.", std::string,
|
|
std::string);
|
|
CARBON_DIAGNOSTIC(StructNamePrevious, Note,
|
|
"Field with the same name here.");
|
|
context.emitter()
|
|
.Build(field_inst_id, StructNameDuplicate, construct.str(),
|
|
sem_ir.names().GetFormatted(field_inst.name_id).str())
|
|
.Note(it->second, StructNamePrevious)
|
|
.Emit();
|
|
return true;
|
|
}
|
|
}
|
|
return false;
|
|
}
|
|
|
|
auto HandleStructLiteral(Context& context, Parse::StructLiteralId parse_node)
|
|
-> bool {
|
|
auto refs_id = context.ParamOrArgEnd(
|
|
Parse::NodeKind::StructLiteralOrStructTypeLiteralStart);
|
|
|
|
context.PopScope();
|
|
context.node_stack()
|
|
.PopAndDiscardSoloParseNode<
|
|
Parse::NodeKind::StructLiteralOrStructTypeLiteralStart>();
|
|
auto type_block_id = context.args_type_info_stack().Pop();
|
|
if (DiagnoseDuplicateNames(context, type_block_id, "struct literal")) {
|
|
context.node_stack().Push(parse_node, SemIR::InstId::BuiltinError);
|
|
return true;
|
|
}
|
|
|
|
auto type_id = context.GetStructType(type_block_id);
|
|
|
|
auto value_id =
|
|
context.AddInst({parse_node, SemIR::StructLiteral{type_id, refs_id}});
|
|
context.node_stack().Push(parse_node, value_id);
|
|
return true;
|
|
}
|
|
|
|
auto HandleStructTypeLiteral(Context& context,
|
|
Parse::StructTypeLiteralId parse_node) -> bool {
|
|
auto refs_id = context.ParamOrArgEnd(
|
|
Parse::NodeKind::StructLiteralOrStructTypeLiteralStart);
|
|
|
|
context.PopScope();
|
|
context.node_stack()
|
|
.PopAndDiscardSoloParseNode<
|
|
Parse::NodeKind::StructLiteralOrStructTypeLiteralStart>();
|
|
// This is only used for value literals.
|
|
context.args_type_info_stack().Pop();
|
|
|
|
CARBON_CHECK(refs_id != SemIR::InstBlockId::Empty)
|
|
<< "{} is handled by StructLiteral.";
|
|
|
|
if (DiagnoseDuplicateNames(context, refs_id, "struct type literal")) {
|
|
context.node_stack().Push(parse_node, SemIR::InstId::BuiltinError);
|
|
return true;
|
|
}
|
|
context.AddInstAndPush(
|
|
{parse_node, SemIR::StructType{SemIR::TypeId::TypeType, refs_id}});
|
|
return true;
|
|
}
|
|
|
|
} // namespace Carbon::Check
|