mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 22:02:23 +01:00
Building on #3636 which handles the general import case, add special casing for namespaces. Namespaces can be combined cross-IR, so it's a little more complex. The implementation adds import_id to the Namespace instruction as a reference to find the original using the normal structure. This is achieved by moving the name_id to NameScope to free up space. --- I considered a few alternatives... I considered adding import_id to NameScope, but: 1. It's more consistent with things such as Function or Class that provide name_id on the info object rather than the instruction. 2. I thought it more likely that there would be more NameScope cases that might want a name_id rather than the import_id, since ImportRef will typically be used. I considered putting the import source (cross-ref IR id + inst id) on the NameScope versus a separate ImportRef, which seems like the strongest argument towards the NameScope approach because it removes an instruction. That just felt inconsistent though, and the overhead of instruction-per-imported-namespace should be low (theoretically few namespaces should be used). Plus I feel a bit odd adding two generally-unused ids to NameScope. A specialized Namespace structure could also have been created to store the import_id, but that would add an indirection to the NameScope.
164 lines
6.1 KiB
C++
164 lines
6.1 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "toolchain/check/context.h"
|
|
#include "toolchain/check/modifiers.h"
|
|
|
|
namespace Carbon::Check {
|
|
|
|
auto HandleInterfaceIntroducer(Context& context,
|
|
Parse::InterfaceIntroducerId parse_node)
|
|
-> bool {
|
|
// Create an instruction block to hold the instructions created as part of the
|
|
// interface signature, such as generic parameters.
|
|
context.inst_block_stack().Push();
|
|
// Push the bracketing node.
|
|
context.node_stack().Push(parse_node);
|
|
// Optional modifiers and the name follow.
|
|
context.decl_state_stack().Push(DeclState::Interface);
|
|
context.decl_name_stack().PushScopeAndStartName();
|
|
return true;
|
|
}
|
|
|
|
static auto BuildInterfaceDecl(Context& context,
|
|
Parse::AnyInterfaceDeclId parse_node)
|
|
-> std::tuple<SemIR::InterfaceId, SemIR::InstId> {
|
|
if (context.node_stack().PopIf<Parse::NodeKind::TuplePattern>()) {
|
|
context.TODO(parse_node, "generic interface");
|
|
}
|
|
if (context.node_stack().PopIf<Parse::NodeKind::ImplicitParamList>()) {
|
|
context.TODO(parse_node, "generic interface");
|
|
}
|
|
|
|
auto name_context = context.decl_name_stack().FinishName();
|
|
context.node_stack()
|
|
.PopAndDiscardSoloParseNode<Parse::NodeKind::InterfaceIntroducer>();
|
|
|
|
// Process modifiers.
|
|
CheckAccessModifiersOnDecl(context, Lex::TokenKind::Interface);
|
|
LimitModifiersOnDecl(context, KeywordModifierSet::Access,
|
|
Lex::TokenKind::Interface);
|
|
|
|
auto modifiers = context.decl_state_stack().innermost().modifier_set;
|
|
if (!!(modifiers & KeywordModifierSet::Access)) {
|
|
context.TODO(context.decl_state_stack().innermost().saw_access_modifier,
|
|
"access modifier");
|
|
}
|
|
context.decl_state_stack().Pop(DeclState::Interface);
|
|
|
|
auto decl_block_id = context.inst_block_stack().Pop();
|
|
|
|
// Add the interface declaration.
|
|
auto interface_decl =
|
|
SemIR::InterfaceDecl{SemIR::InterfaceId::Invalid, decl_block_id};
|
|
auto interface_decl_id =
|
|
context.AddPlaceholderInst({parse_node, interface_decl});
|
|
|
|
// Check whether this is a redeclaration.
|
|
auto existing_id = context.decl_name_stack().LookupOrAddName(
|
|
name_context, interface_decl_id);
|
|
if (existing_id.is_valid()) {
|
|
if (auto existing_interface_decl =
|
|
context.insts().Get(existing_id).TryAs<SemIR::InterfaceDecl>()) {
|
|
// This is a redeclaration of an existing interface.
|
|
interface_decl.interface_id = existing_interface_decl->interface_id;
|
|
|
|
// TODO: Check that the generic parameter list agrees with the prior
|
|
// declaration.
|
|
} else {
|
|
// This is a redeclaration of something other than a interface.
|
|
context.DiagnoseDuplicateName(interface_decl_id, existing_id);
|
|
}
|
|
}
|
|
|
|
// Create a new interface if this isn't a valid redeclaration.
|
|
if (!interface_decl.interface_id.is_valid()) {
|
|
// TODO: If this is an invalid redeclaration of a non-interface entity or
|
|
// there was an error in the qualifier, we will have lost track of the
|
|
// interface name here. We should keep track of it even if the name is
|
|
// invalid.
|
|
// TODO: should have a `Self` type id member
|
|
interface_decl.interface_id = context.interfaces().Add(
|
|
{.name_id = name_context.name_id_for_new_inst(),
|
|
.enclosing_scope_id = name_context.enclosing_scope_id_for_new_inst(),
|
|
.decl_id = interface_decl_id});
|
|
}
|
|
|
|
// Write the interface ID into the InterfaceDecl.
|
|
context.ReplaceInstBeforeConstantUse(interface_decl_id,
|
|
{parse_node, interface_decl});
|
|
|
|
return {interface_decl.interface_id, interface_decl_id};
|
|
}
|
|
|
|
auto HandleInterfaceDecl(Context& context, Parse::InterfaceDeclId parse_node)
|
|
-> bool {
|
|
BuildInterfaceDecl(context, parse_node);
|
|
context.decl_name_stack().PopScope();
|
|
return true;
|
|
}
|
|
|
|
auto HandleInterfaceDefinitionStart(
|
|
Context& context, Parse::InterfaceDefinitionStartId parse_node) -> bool {
|
|
auto [interface_id, interface_decl_id] =
|
|
BuildInterfaceDecl(context, parse_node);
|
|
auto& interface_info = context.interfaces().Get(interface_id);
|
|
|
|
// Track that this declaration is the definition.
|
|
if (interface_info.definition_id.is_valid()) {
|
|
CARBON_DIAGNOSTIC(InterfaceRedefinition, Error,
|
|
"Redefinition of interface {0}.", std::string);
|
|
CARBON_DIAGNOSTIC(InterfacePreviousDefinition, Note,
|
|
"Previous definition was here.");
|
|
context.emitter()
|
|
.Build(parse_node, InterfaceRedefinition,
|
|
context.names().GetFormatted(interface_info.name_id).str())
|
|
.Note(interface_info.definition_id, InterfacePreviousDefinition)
|
|
.Emit();
|
|
} else {
|
|
interface_info.definition_id = interface_decl_id;
|
|
interface_info.scope_id =
|
|
context.name_scopes().Add(interface_decl_id, SemIR::NameId::Invalid,
|
|
interface_info.enclosing_scope_id);
|
|
}
|
|
|
|
// Enter the interface scope.
|
|
context.PushScope(interface_decl_id, interface_info.scope_id);
|
|
|
|
// TODO: Introduce `Self`.
|
|
|
|
context.inst_block_stack().Push();
|
|
context.node_stack().Push(parse_node, interface_id);
|
|
// TODO: Perhaps use the args_type_info_stack for a witness table.
|
|
|
|
// TODO: Handle the case where there's control flow in the interface body. For
|
|
// example:
|
|
//
|
|
// interface C {
|
|
// let v: if true then i32 else f64;
|
|
// }
|
|
//
|
|
// We may need to track a list of instruction blocks here, as we do for a
|
|
// function.
|
|
interface_info.body_block_id = context.inst_block_stack().PeekOrAdd();
|
|
return true;
|
|
}
|
|
|
|
auto HandleInterfaceDefinition(Context& context,
|
|
Parse::InterfaceDefinitionId /*parse_node*/)
|
|
-> bool {
|
|
auto interface_id =
|
|
context.node_stack().Pop<Parse::NodeKind::InterfaceDefinitionStart>();
|
|
context.inst_block_stack().Pop();
|
|
context.PopScope();
|
|
context.decl_name_stack().PopScope();
|
|
|
|
// The interface type is now fully defined.
|
|
auto& interface_info = context.interfaces().Get(interface_id);
|
|
interface_info.defined = true;
|
|
return true;
|
|
}
|
|
|
|
} // namespace Carbon::Check
|