mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 22:02:23 +01:00
Jon Ross-Perkins
446b0ce4ae
This started with cleaning up the remaining Name/expression type punning in the node stack, and grew. I'm factoring out a class because we've previously expressed the desire to factor logic out of SemanticsContext where possible, and this seemed like a reasonable cut. NameExpression as the first node as a QualifiedExpression allows the qualifier handling to consider Name in one less spot, an incremental simplification. However, the additional complexity caused by this makes me split ApplyNameQualifier/ApplyExpressionQualifier in order to avoid repeat checks of the parse node's kind. The logic is still largely shared, thus a couple helper functions. I think this is all fairly well structured in the isolated class. I can see that we may want to avoid passing SemanticsContext as an argument in the future if it elides a step of lookup.
26 lines
950 B
C++
26 lines
950 B
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#include "toolchain/semantics/semantics_context.h"
|
|
#include "toolchain/semantics/semantics_node.h"
|
|
|
|
namespace Carbon {
|
|
|
|
auto SemanticsHandleNamespaceStart(SemanticsContext& context,
|
|
ParseTree::Node /*parse_node*/) -> bool {
|
|
context.declaration_name_stack().Push();
|
|
return true;
|
|
}
|
|
|
|
auto SemanticsHandleNamespace(SemanticsContext& context,
|
|
ParseTree::Node parse_node) -> bool {
|
|
auto name_context = context.declaration_name_stack().Pop();
|
|
auto namespace_id = context.AddNode(SemanticsNode::Namespace::Make(
|
|
parse_node, context.semantics_ir().AddNameScope()));
|
|
context.declaration_name_stack().AddNameToLookup(name_context, namespace_id);
|
|
return true;
|
|
}
|
|
|
|
} // namespace Carbon
|