mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-30 17:05:05 +01:00
Jon Ross-Perkins
91f0c23124
Building on #3636 which handles the general import case, add special casing for namespaces. Namespaces can be combined cross-IR, so it's a little more complex. The implementation adds import_id to the Namespace instruction as a reference to find the original using the normal structure. This is achieved by moving the name_id to NameScope to free up space. --- I considered a few alternatives... I considered adding import_id to NameScope, but: 1. It's more consistent with things such as Function or Class that provide name_id on the info object rather than the instruction. 2. I thought it more likely that there would be more NameScope cases that might want a name_id rather than the import_id, since ImportRef will typically be used. I considered putting the import source (cross-ref IR id + inst id) on the NameScope versus a separate ImportRef, which seems like the strongest argument towards the NameScope approach because it removes an instruction. That just felt inconsistent though, and the overhead of instruction-per-imported-namespace should be low (theoretically few namespaces should be used). Plus I feel a bit odd adding two generally-unused ids to NameScope. A specialized Namespace structure could also have been created to store the import_id, but that would add an indirection to the NameScope.
68 lines
2.2 KiB
Plaintext
68 lines
2.2 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// AUTOUPDATE
|
|
|
|
fn Cond() -> bool;
|
|
|
|
fn F();
|
|
fn G();
|
|
fn H();
|
|
|
|
fn While() {
|
|
F();
|
|
while (Cond()) {
|
|
G();
|
|
}
|
|
H();
|
|
}
|
|
|
|
// CHECK:STDOUT: --- while.carbon
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: constants {
|
|
// CHECK:STDOUT: %.1: type = tuple_type () [template]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: file {
|
|
// CHECK:STDOUT: package: <namespace> = namespace {.Cond = %Cond, .F = %F, .G = %G, .H = %H, .While = %While} [template]
|
|
// CHECK:STDOUT: %Cond: <function> = fn_decl @Cond [template]
|
|
// CHECK:STDOUT: %F: <function> = fn_decl @F [template]
|
|
// CHECK:STDOUT: %G: <function> = fn_decl @G [template]
|
|
// CHECK:STDOUT: %H: <function> = fn_decl @H [template]
|
|
// CHECK:STDOUT: %While: <function> = fn_decl @While [template]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: fn @Cond() -> bool;
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: fn @F();
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: fn @G();
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: fn @H();
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: fn @While() {
|
|
// CHECK:STDOUT: !entry:
|
|
// CHECK:STDOUT: %F.ref: <function> = name_ref F, file.%F [template = file.%F]
|
|
// CHECK:STDOUT: %.loc14: init () = call %F.ref()
|
|
// CHECK:STDOUT: br !while.cond
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: !while.cond:
|
|
// CHECK:STDOUT: %Cond.ref: <function> = name_ref Cond, file.%Cond [template = file.%Cond]
|
|
// CHECK:STDOUT: %.loc15_14.1: init bool = call %Cond.ref()
|
|
// CHECK:STDOUT: %.loc15_16: bool = value_of_initializer %.loc15_14.1
|
|
// CHECK:STDOUT: %.loc15_14.2: bool = converted %.loc15_14.1, %.loc15_16
|
|
// CHECK:STDOUT: if %.loc15_14.2 br !while.body else br !while.done
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: !while.body:
|
|
// CHECK:STDOUT: %G.ref: <function> = name_ref G, file.%G [template = file.%G]
|
|
// CHECK:STDOUT: %.loc16: init () = call %G.ref()
|
|
// CHECK:STDOUT: br !while.cond
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: !while.done:
|
|
// CHECK:STDOUT: %H.ref: <function> = name_ref H, file.%H [template = file.%H]
|
|
// CHECK:STDOUT: %.loc18: init () = call %H.ref()
|
|
// CHECK:STDOUT: return
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|