mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-01 13:45:53 +01:00
Jon Ross-Perkins
91f0c23124
Building on #3636 which handles the general import case, add special casing for namespaces. Namespaces can be combined cross-IR, so it's a little more complex. The implementation adds import_id to the Namespace instruction as a reference to find the original using the normal structure. This is achieved by moving the name_id to NameScope to free up space. --- I considered a few alternatives... I considered adding import_id to NameScope, but: 1. It's more consistent with things such as Function or Class that provide name_id on the info object rather than the instruction. 2. I thought it more likely that there would be more NameScope cases that might want a name_id rather than the import_id, since ImportRef will typically be used. I considered putting the import source (cross-ref IR id + inst id) on the NameScope versus a separate ImportRef, which seems like the strongest argument towards the NameScope approach because it removes an instruction. That just felt inconsistent though, and the overhead of instruction-per-imported-namespace should be low (theoretically few namespaces should be used). Plus I feel a bit odd adding two generally-unused ids to NameScope. A specialized Namespace structure could also have been created to store the import_id, but that would add an indirection to the NameScope.
41 lines
1.3 KiB
Plaintext
41 lines
1.3 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// AUTOUPDATE
|
|
|
|
fn While() {
|
|
// CHECK:STDERR: fail_bad_condition.carbon:[[@LINE+3]]:9: ERROR: Cannot implicitly convert from `String` to `bool`.
|
|
// CHECK:STDERR: while ("Hello") {}
|
|
// CHECK:STDERR: ^~~~~~~~~
|
|
while ("Hello") {}
|
|
}
|
|
|
|
// CHECK:STDOUT: --- fail_bad_condition.carbon
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: constants {
|
|
// CHECK:STDOUT: %.1: type = ptr_type String [template]
|
|
// CHECK:STDOUT: %.2: String = string_literal "Hello" [template]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: file {
|
|
// CHECK:STDOUT: package: <namespace> = namespace {.While = %While} [template]
|
|
// CHECK:STDOUT: %While: <function> = fn_decl @While [template]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: fn @While() {
|
|
// CHECK:STDOUT: !entry:
|
|
// CHECK:STDOUT: br !while.cond
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: !while.cond:
|
|
// CHECK:STDOUT: %.loc11: String = string_literal "Hello" [template = constants.%.2]
|
|
// CHECK:STDOUT: if <error> br !while.body else br !while.done
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: !while.body:
|
|
// CHECK:STDOUT: br !while.cond
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: !while.done:
|
|
// CHECK:STDOUT: return
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|