mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-04 22:02:52 +01:00
Jon Ross-Perkins
91f0c23124
Building on #3636 which handles the general import case, add special casing for namespaces. Namespaces can be combined cross-IR, so it's a little more complex. The implementation adds import_id to the Namespace instruction as a reference to find the original using the normal structure. This is achieved by moving the name_id to NameScope to free up space. --- I considered a few alternatives... I considered adding import_id to NameScope, but: 1. It's more consistent with things such as Function or Class that provide name_id on the info object rather than the instruction. 2. I thought it more likely that there would be more NameScope cases that might want a name_id rather than the import_id, since ImportRef will typically be used. I considered putting the import source (cross-ref IR id + inst id) on the NameScope versus a separate ImportRef, which seems like the strongest argument towards the NameScope approach because it removes an instruction. That just felt inconsistent though, and the overhead of instruction-per-imported-namespace should be low (theoretically few namespaces should be used). Plus I feel a bit odd adding two generally-unused ids to NameScope. A specialized Namespace structure could also have been created to store the import_id, but that would add an indirection to the NameScope.
61 lines
2.2 KiB
Plaintext
61 lines
2.2 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// AUTOUPDATE
|
|
|
|
class X {
|
|
}
|
|
|
|
fn F(x: X) {
|
|
// TODO: Strings should eventually be copyable, once we decide how to
|
|
// represent them.
|
|
// CHECK:STDERR: fail_not_copyable.carbon:[[@LINE+3]]:19: ERROR: Cannot copy value of type `String`.
|
|
// CHECK:STDERR: var s: String = "hello";
|
|
// CHECK:STDERR: ^~~~~~~
|
|
var s: String = "hello";
|
|
|
|
// TODO: Decide on rules for when classes are copyable.
|
|
// CHECK:STDERR: fail_not_copyable.carbon:[[@LINE+3]]:14: ERROR: Cannot copy value of type `X`.
|
|
// CHECK:STDERR: var y: X = x;
|
|
// CHECK:STDERR: ^
|
|
var y: X = x;
|
|
}
|
|
|
|
// CHECK:STDOUT: --- fail_not_copyable.carbon
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: constants {
|
|
// CHECK:STDOUT: %X: type = class_type @X [template]
|
|
// CHECK:STDOUT: %.1: type = struct_type {} [template]
|
|
// CHECK:STDOUT: %.2: type = tuple_type () [template]
|
|
// CHECK:STDOUT: %.3: type = ptr_type {} [template]
|
|
// CHECK:STDOUT: %.4: type = ptr_type String [template]
|
|
// CHECK:STDOUT: %.5: String = string_literal "hello" [template]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: file {
|
|
// CHECK:STDOUT: package: <namespace> = namespace {.X = %X.decl, .F = %F} [template]
|
|
// CHECK:STDOUT: %X.decl = class_decl @X, ()
|
|
// CHECK:STDOUT: %F: <function> = fn_decl @F [template]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: class @X {
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: !members:
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: fn @F(%x: X) {
|
|
// CHECK:STDOUT: !entry:
|
|
// CHECK:STDOUT: %s.var: ref String = var s
|
|
// CHECK:STDOUT: %s: ref String = bind_name s, %s.var
|
|
// CHECK:STDOUT: %.loc16: String = string_literal "hello" [template = constants.%.5]
|
|
// CHECK:STDOUT: assign %s.var, <error>
|
|
// CHECK:STDOUT: %X.ref: type = name_ref X, constants.%X [template = constants.%X]
|
|
// CHECK:STDOUT: %y.var: ref X = var y
|
|
// CHECK:STDOUT: %y: ref X = bind_name y, %y.var
|
|
// CHECK:STDOUT: %x.ref: X = name_ref x, %x
|
|
// CHECK:STDOUT: assign %y.var, <error>
|
|
// CHECK:STDOUT: return
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|