mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-05 10:11:04 +01:00
Jon Ross-Perkins
91f0c23124
Building on #3636 which handles the general import case, add special casing for namespaces. Namespaces can be combined cross-IR, so it's a little more complex. The implementation adds import_id to the Namespace instruction as a reference to find the original using the normal structure. This is achieved by moving the name_id to NameScope to free up space. --- I considered a few alternatives... I considered adding import_id to NameScope, but: 1. It's more consistent with things such as Function or Class that provide name_id on the info object rather than the instruction. 2. I thought it more likely that there would be more NameScope cases that might want a name_id rather than the import_id, since ImportRef will typically be used. I considered putting the import source (cross-ref IR id + inst id) on the NameScope versus a separate ImportRef, which seems like the strongest argument towards the NameScope approach because it removes an instruction. That just felt inconsistent though, and the overhead of instruction-per-imported-namespace should be low (theoretically few namespaces should be used). Plus I feel a bit odd adding two generally-unused ids to NameScope. A specialized Namespace structure could also have been created to store the import_id, but that would add an indirection to the NameScope.
33 lines
1.5 KiB
Plaintext
33 lines
1.5 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// AUTOUPDATE
|
|
|
|
// CHECK:STDERR: fail_too_few_element.carbon:[[@LINE+3]]:21: ERROR: Cannot initialize tuple of 2 element(s) from tuple with 1 element(s).
|
|
// CHECK:STDERR: var x: (i32, i32) = (2, );
|
|
// CHECK:STDERR: ^~~~~
|
|
var x: (i32, i32) = (2, );
|
|
|
|
// CHECK:STDOUT: --- fail_too_few_element.carbon
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: constants {
|
|
// CHECK:STDOUT: %.1: type = tuple_type (type, type) [template]
|
|
// CHECK:STDOUT: %.2: type = tuple_type (i32, i32) [template]
|
|
// CHECK:STDOUT: %.3: type = ptr_type (i32, i32) [template]
|
|
// CHECK:STDOUT: %.4: i32 = int_literal 2 [template]
|
|
// CHECK:STDOUT: %.5: type = tuple_type (i32) [template]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: file {
|
|
// CHECK:STDOUT: package: <namespace> = namespace {.x = %x} [template]
|
|
// CHECK:STDOUT: %.loc10_17.1: (type, type) = tuple_literal (i32, i32)
|
|
// CHECK:STDOUT: %.loc10_17.2: type = converted %.loc10_17.1, constants.%.2 [template = constants.%.2]
|
|
// CHECK:STDOUT: %x.var: ref (i32, i32) = var x
|
|
// CHECK:STDOUT: %x: ref (i32, i32) = bind_name x, %x.var
|
|
// CHECK:STDOUT: %.loc10_22: i32 = int_literal 2 [template = constants.%.4]
|
|
// CHECK:STDOUT: %.loc10_25: (i32,) = tuple_literal (%.loc10_22)
|
|
// CHECK:STDOUT: assign %x.var, <error>
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|