mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-30 15:55:03 +01:00
Jon Ross-Perkins
91f0c23124
Building on #3636 which handles the general import case, add special casing for namespaces. Namespaces can be combined cross-IR, so it's a little more complex. The implementation adds import_id to the Namespace instruction as a reference to find the original using the normal structure. This is achieved by moving the name_id to NameScope to free up space. --- I considered a few alternatives... I considered adding import_id to NameScope, but: 1. It's more consistent with things such as Function or Class that provide name_id on the info object rather than the instruction. 2. I thought it more likely that there would be more NameScope cases that might want a name_id rather than the import_id, since ImportRef will typically be used. I considered putting the import source (cross-ref IR id + inst id) on the NameScope versus a separate ImportRef, which seems like the strongest argument towards the NameScope approach because it removes an instruction. That just felt inconsistent though, and the overhead of instruction-per-imported-namespace should be low (theoretically few namespaces should be used). Plus I feel a bit odd adding two generally-unused ids to NameScope. A specialized Namespace structure could also have been created to store the import_id, but that would add an indirection to the NameScope.
39 lines
1.9 KiB
Plaintext
39 lines
1.9 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// AUTOUPDATE
|
|
|
|
var x: {.a: i32} = {.a = 4};
|
|
var y: {.a: i32} = x;
|
|
|
|
// CHECK:STDOUT: --- one_entry.carbon
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: constants {
|
|
// CHECK:STDOUT: %.1: type = struct_type {.a: i32} [template]
|
|
// CHECK:STDOUT: %.2: i32 = int_literal 4 [template]
|
|
// CHECK:STDOUT: %.3: {.a: i32} = struct_value (%.2) [template]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: file {
|
|
// CHECK:STDOUT: package: <namespace> = namespace {.x = %x, .y = %y} [template]
|
|
// CHECK:STDOUT: %.loc7_16: type = struct_type {.a: i32} [template = constants.%.1]
|
|
// CHECK:STDOUT: %x.var: ref {.a: i32} = var x
|
|
// CHECK:STDOUT: %x: ref {.a: i32} = bind_name x, %x.var
|
|
// CHECK:STDOUT: %.loc7_26: i32 = int_literal 4 [template = constants.%.2]
|
|
// CHECK:STDOUT: %.loc7_27.1: {.a: i32} = struct_literal (%.loc7_26)
|
|
// CHECK:STDOUT: %.loc7_27.2: init {.a: i32} = struct_init (%.loc7_26) to %x.var [template = constants.%.3]
|
|
// CHECK:STDOUT: %.loc7_27.3: init {.a: i32} = converted %.loc7_27.1, %.loc7_27.2 [template = constants.%.3]
|
|
// CHECK:STDOUT: assign %x.var, %.loc7_27.3
|
|
// CHECK:STDOUT: %.loc8_16: type = struct_type {.a: i32} [template = constants.%.1]
|
|
// CHECK:STDOUT: %y.var: ref {.a: i32} = var y
|
|
// CHECK:STDOUT: %y: ref {.a: i32} = bind_name y, %y.var
|
|
// CHECK:STDOUT: %x.ref: ref {.a: i32} = name_ref x, %x
|
|
// CHECK:STDOUT: %.loc8_20.1: ref i32 = struct_access %x.ref, element0
|
|
// CHECK:STDOUT: %.loc8_20.2: i32 = bind_value %.loc8_20.1
|
|
// CHECK:STDOUT: %.loc8_20.3: init {.a: i32} = struct_init (%.loc8_20.2) to %y.var
|
|
// CHECK:STDOUT: %.loc8_20.4: init {.a: i32} = converted %x.ref, %.loc8_20.3
|
|
// CHECK:STDOUT: assign %y.var, %.loc8_20.4
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|