mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-02 11:06:03 +01:00
Jon Ross-Perkins
91f0c23124
Building on #3636 which handles the general import case, add special casing for namespaces. Namespaces can be combined cross-IR, so it's a little more complex. The implementation adds import_id to the Namespace instruction as a reference to find the original using the normal structure. This is achieved by moving the name_id to NameScope to free up space. --- I considered a few alternatives... I considered adding import_id to NameScope, but: 1. It's more consistent with things such as Function or Class that provide name_id on the info object rather than the instruction. 2. I thought it more likely that there would be more NameScope cases that might want a name_id rather than the import_id, since ImportRef will typically be used. I considered putting the import source (cross-ref IR id + inst id) on the NameScope versus a separate ImportRef, which seems like the strongest argument towards the NameScope approach because it removes an instruction. That just felt inconsistent though, and the overhead of instruction-per-imported-namespace should be low (theoretically few namespaces should be used). Plus I feel a bit odd adding two generally-unused ids to NameScope. A specialized Namespace structure could also have been created to store the import_id, but that would add an indirection to the NameScope.
49 lines
2.6 KiB
Plaintext
49 lines
2.6 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// AUTOUPDATE
|
|
|
|
var x: {.a: f64, .b: i32} = {.a = 0.0, .b = 1};
|
|
var y: i32 = x.b;
|
|
var z: i32 = y;
|
|
|
|
// CHECK:STDOUT: --- member_access.carbon
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: constants {
|
|
// CHECK:STDOUT: %.1: type = struct_type {.a: f64, .b: i32} [template]
|
|
// CHECK:STDOUT: %.2: type = ptr_type {.a: f64, .b: i32} [template]
|
|
// CHECK:STDOUT: %.3: f64 = real_literal 0e-1 [template]
|
|
// CHECK:STDOUT: %.4: i32 = int_literal 1 [template]
|
|
// CHECK:STDOUT: %.5: {.a: f64, .b: i32} = struct_value (%.3, %.4) [template]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: file {
|
|
// CHECK:STDOUT: package: <namespace> = namespace {.x = %x, .y = %y, .z = %z} [template]
|
|
// CHECK:STDOUT: %.loc7_25: type = struct_type {.a: f64, .b: i32} [template = constants.%.1]
|
|
// CHECK:STDOUT: %x.var: ref {.a: f64, .b: i32} = var x
|
|
// CHECK:STDOUT: %x: ref {.a: f64, .b: i32} = bind_name x, %x.var
|
|
// CHECK:STDOUT: %.loc7_35: f64 = real_literal 0e-1 [template = constants.%.3]
|
|
// CHECK:STDOUT: %.loc7_45: i32 = int_literal 1 [template = constants.%.4]
|
|
// CHECK:STDOUT: %.loc7_46.1: {.a: f64, .b: i32} = struct_literal (%.loc7_35, %.loc7_45)
|
|
// CHECK:STDOUT: %.loc7_46.2: ref f64 = struct_access %x.var, element0
|
|
// CHECK:STDOUT: %.loc7_46.3: init f64 = initialize_from %.loc7_35 to %.loc7_46.2 [template = constants.%.3]
|
|
// CHECK:STDOUT: %.loc7_46.4: ref i32 = struct_access %x.var, element1
|
|
// CHECK:STDOUT: %.loc7_46.5: init i32 = initialize_from %.loc7_45 to %.loc7_46.4 [template = constants.%.4]
|
|
// CHECK:STDOUT: %.loc7_46.6: init {.a: f64, .b: i32} = struct_init (%.loc7_46.3, %.loc7_46.5) to %x.var [template = constants.%.5]
|
|
// CHECK:STDOUT: %.loc7_46.7: init {.a: f64, .b: i32} = converted %.loc7_46.1, %.loc7_46.6 [template = constants.%.5]
|
|
// CHECK:STDOUT: assign %x.var, %.loc7_46.7
|
|
// CHECK:STDOUT: %y.var: ref i32 = var y
|
|
// CHECK:STDOUT: %y: ref i32 = bind_name y, %y.var
|
|
// CHECK:STDOUT: %x.ref: ref {.a: f64, .b: i32} = name_ref x, %x
|
|
// CHECK:STDOUT: %.loc8_15.1: ref i32 = struct_access %x.ref, element1
|
|
// CHECK:STDOUT: %.loc8_15.2: i32 = bind_value %.loc8_15.1
|
|
// CHECK:STDOUT: assign %y.var, %.loc8_15.2
|
|
// CHECK:STDOUT: %z.var: ref i32 = var z
|
|
// CHECK:STDOUT: %z: ref i32 = bind_name z, %z.var
|
|
// CHECK:STDOUT: %y.ref: ref i32 = name_ref y, %y
|
|
// CHECK:STDOUT: %.loc9: i32 = bind_value %y.ref
|
|
// CHECK:STDOUT: assign %z.var, %.loc9
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|