mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-30 18:05:02 +01:00
Jon Ross-Perkins
91f0c23124
Building on #3636 which handles the general import case, add special casing for namespaces. Namespaces can be combined cross-IR, so it's a little more complex. The implementation adds import_id to the Namespace instruction as a reference to find the original using the normal structure. This is achieved by moving the name_id to NameScope to free up space. --- I considered a few alternatives... I considered adding import_id to NameScope, but: 1. It's more consistent with things such as Function or Class that provide name_id on the info object rather than the instruction. 2. I thought it more likely that there would be more NameScope cases that might want a name_id rather than the import_id, since ImportRef will typically be used. I considered putting the import source (cross-ref IR id + inst id) on the NameScope versus a separate ImportRef, which seems like the strongest argument towards the NameScope approach because it removes an instruction. That just felt inconsistent though, and the overhead of instruction-per-imported-namespace should be low (theoretically few namespaces should be used). Plus I feel a bit odd adding two generally-unused ids to NameScope. A specialized Namespace structure could also have been created to store the import_id, but that would add an indirection to the NameScope.
34 lines
1.5 KiB
Plaintext
34 lines
1.5 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// AUTOUPDATE
|
|
|
|
// CHECK:STDERR: fail_assign_nested.carbon:[[@LINE+3]]:19: ERROR: Missing value for field `a` in struct initialization.
|
|
// CHECK:STDERR: var x: {.a: {}} = {.b = {}};
|
|
// CHECK:STDERR: ^~~~~~~~~
|
|
var x: {.a: {}} = {.b = {}};
|
|
|
|
// CHECK:STDOUT: --- fail_assign_nested.carbon
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: constants {
|
|
// CHECK:STDOUT: %.1: type = struct_type {} [template]
|
|
// CHECK:STDOUT: %.2: type = struct_type {.a: {}} [template]
|
|
// CHECK:STDOUT: %.3: type = tuple_type () [template]
|
|
// CHECK:STDOUT: %.4: type = struct_type {.a: ()} [template]
|
|
// CHECK:STDOUT: %.5: type = struct_type {.b: {}} [template]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: file {
|
|
// CHECK:STDOUT: package: <namespace> = namespace {.x = %x} [template]
|
|
// CHECK:STDOUT: %.loc10_14.1: {} = struct_literal ()
|
|
// CHECK:STDOUT: %.loc10_14.2: type = converted %.loc10_14.1, constants.%.1 [template = constants.%.1]
|
|
// CHECK:STDOUT: %.loc10_15: type = struct_type {.a: {}} [template = constants.%.2]
|
|
// CHECK:STDOUT: %x.var: ref {.a: {}} = var x
|
|
// CHECK:STDOUT: %x: ref {.a: {}} = bind_name x, %x.var
|
|
// CHECK:STDOUT: %.loc10_26: {} = struct_literal ()
|
|
// CHECK:STDOUT: %.loc10_27: {.b: {}} = struct_literal (%.loc10_26)
|
|
// CHECK:STDOUT: assign %x.var, <error>
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|