mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-30 14:45:00 +01:00
Jon Ross-Perkins
91f0c23124
Building on #3636 which handles the general import case, add special casing for namespaces. Namespaces can be combined cross-IR, so it's a little more complex. The implementation adds import_id to the Namespace instruction as a reference to find the original using the normal structure. This is achieved by moving the name_id to NameScope to free up space. --- I considered a few alternatives... I considered adding import_id to NameScope, but: 1. It's more consistent with things such as Function or Class that provide name_id on the info object rather than the instruction. 2. I thought it more likely that there would be more NameScope cases that might want a name_id rather than the import_id, since ImportRef will typically be used. I considered putting the import source (cross-ref IR id + inst id) on the NameScope versus a separate ImportRef, which seems like the strongest argument towards the NameScope approach because it removes an instruction. That just felt inconsistent though, and the overhead of instruction-per-imported-namespace should be low (theoretically few namespaces should be used). Plus I feel a bit odd adding two generally-unused ids to NameScope. A specialized Namespace structure could also have been created to store the import_id, but that would add an indirection to the NameScope.
51 lines
2.1 KiB
Plaintext
51 lines
2.1 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// AUTOUPDATE
|
|
|
|
fn Deref(n: i32) {
|
|
// CHECK:STDERR: fail_deref_not_pointer.carbon:[[@LINE+3]]:3: ERROR: Cannot dereference operand of non-pointer type `i32`.
|
|
// CHECK:STDERR: *n;
|
|
// CHECK:STDERR: ^
|
|
*n;
|
|
// CHECK:STDERR: fail_deref_not_pointer.carbon:[[@LINE+3]]:3: ERROR: Cannot dereference operand of non-pointer type `()`.
|
|
// CHECK:STDERR: *();
|
|
// CHECK:STDERR: ^
|
|
*();
|
|
// CHECK:STDERR: fail_deref_not_pointer.carbon:[[@LINE+3]]:3: ERROR: Cannot dereference operand of non-pointer type `{}`.
|
|
// CHECK:STDERR: *{};
|
|
// CHECK:STDERR: ^
|
|
*{};
|
|
}
|
|
|
|
// CHECK:STDOUT: --- fail_deref_not_pointer.carbon
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: constants {
|
|
// CHECK:STDOUT: %.1: type = tuple_type () [template]
|
|
// CHECK:STDOUT: %.2: () = tuple_value () [template]
|
|
// CHECK:STDOUT: %.3: type = struct_type {} [template]
|
|
// CHECK:STDOUT: %.4: {} = struct_value () [template]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: file {
|
|
// CHECK:STDOUT: package: <namespace> = namespace {.Deref = %Deref} [template]
|
|
// CHECK:STDOUT: %Deref: <function> = fn_decl @Deref [template]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: fn @Deref(%n: i32) {
|
|
// CHECK:STDOUT: !entry:
|
|
// CHECK:STDOUT: %n.ref: i32 = name_ref n, %n
|
|
// CHECK:STDOUT: %.loc11: ref <error> = deref %n.ref
|
|
// CHECK:STDOUT: %.loc15_5.1: () = tuple_literal ()
|
|
// CHECK:STDOUT: %.loc15_5.2: () = tuple_value () [template = constants.%.2]
|
|
// CHECK:STDOUT: %.loc15_5.3: () = converted %.loc15_5.1, %.loc15_5.2 [template = constants.%.2]
|
|
// CHECK:STDOUT: %.loc15_3: ref <error> = deref %.loc15_5.3
|
|
// CHECK:STDOUT: %.loc19_5.1: {} = struct_literal ()
|
|
// CHECK:STDOUT: %.loc19_5.2: {} = struct_value () [template = constants.%.4]
|
|
// CHECK:STDOUT: %.loc19_5.3: {} = converted %.loc19_5.1, %.loc19_5.2 [template = constants.%.4]
|
|
// CHECK:STDOUT: %.loc19_3: ref <error> = deref %.loc19_5.3
|
|
// CHECK:STDOUT: return
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|