mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-04 13:31:04 +01:00
Jon Ross-Perkins
91f0c23124
Building on #3636 which handles the general import case, add special casing for namespaces. Namespaces can be combined cross-IR, so it's a little more complex. The implementation adds import_id to the Namespace instruction as a reference to find the original using the normal structure. This is achieved by moving the name_id to NameScope to free up space. --- I considered a few alternatives... I considered adding import_id to NameScope, but: 1. It's more consistent with things such as Function or Class that provide name_id on the info object rather than the instruction. 2. I thought it more likely that there would be more NameScope cases that might want a name_id rather than the import_id, since ImportRef will typically be used. I considered putting the import source (cross-ref IR id + inst id) on the NameScope versus a separate ImportRef, which seems like the strongest argument towards the NameScope approach because it removes an instruction. That just felt inconsistent though, and the overhead of instruction-per-imported-namespace should be low (theoretically few namespaces should be used). Plus I feel a bit odd adding two generally-unused ids to NameScope. A specialized Namespace structure could also have been created to store the import_id, but that would add an indirection to the NameScope.
76 lines
3.6 KiB
Plaintext
76 lines
3.6 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// AUTOUPDATE
|
|
|
|
// TODO: The errors here are in bad locations. We should build a SemIR
|
|
// representation for a reference to a name so that we can track the location
|
|
// properly.
|
|
|
|
namespace N;
|
|
// CHECK:STDERR: fail_invalid_base.carbon:[[@LINE+3]]:14: ERROR: Expression cannot be used as a value.
|
|
// CHECK:STDERR: var a: i32 = N[0];
|
|
// CHECK:STDERR: ^
|
|
var a: i32 = N[0];
|
|
|
|
fn F();
|
|
// CHECK:STDERR: fail_invalid_base.carbon:[[@LINE+3]]:14: ERROR: Expression cannot be used as a value.
|
|
// CHECK:STDERR: var b: i32 = F[1];
|
|
// CHECK:STDERR: ^
|
|
var b: i32 = F[1];
|
|
|
|
// CHECK:STDERR: fail_invalid_base.carbon:[[@LINE+3]]:14: ERROR: Type `{.a: i32, .b: i32}` does not support indexing.
|
|
// CHECK:STDERR: var c: i32 = {.a = 1, .b = 2}[0];
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~
|
|
var c: i32 = {.a = 1, .b = 2}[0];
|
|
|
|
// CHECK:STDERR: fail_invalid_base.carbon:[[@LINE+3]]:14: ERROR: Type `type` does not support indexing.
|
|
// CHECK:STDERR: var d: i32 = {.a: i32, .b: i32}[0];
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~
|
|
var d: i32 = {.a: i32, .b: i32}[0];
|
|
|
|
// CHECK:STDOUT: --- fail_invalid_base.carbon
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: constants {
|
|
// CHECK:STDOUT: %.1: i32 = int_literal 0 [template]
|
|
// CHECK:STDOUT: %.2: i32 = int_literal 1 [template]
|
|
// CHECK:STDOUT: %.3: i32 = int_literal 2 [template]
|
|
// CHECK:STDOUT: %.4: type = struct_type {.a: i32, .b: i32} [template]
|
|
// CHECK:STDOUT: %.5: type = ptr_type {.a: i32, .b: i32} [template]
|
|
// CHECK:STDOUT: %.6: {.a: i32, .b: i32} = struct_value (%.2, %.3) [template]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: file {
|
|
// CHECK:STDOUT: package: <namespace> = namespace {.N = %.loc11, .a = %a, .F = %F, .b = %b, .c = %c, .d = %d} [template]
|
|
// CHECK:STDOUT: %.loc11: <namespace> = namespace {} [template]
|
|
// CHECK:STDOUT: %a.var: ref i32 = var a
|
|
// CHECK:STDOUT: %a: ref i32 = bind_name a, %a.var
|
|
// CHECK:STDOUT: %N.ref: <namespace> = name_ref N, %.loc11 [template = %.loc11]
|
|
// CHECK:STDOUT: %.loc15: i32 = int_literal 0 [template = constants.%.1]
|
|
// CHECK:STDOUT: assign %a.var, <error>
|
|
// CHECK:STDOUT: %F: <function> = fn_decl @F [template]
|
|
// CHECK:STDOUT: %b.var: ref i32 = var b
|
|
// CHECK:STDOUT: %b: ref i32 = bind_name b, %b.var
|
|
// CHECK:STDOUT: %F.ref: <function> = name_ref F, %F [template = %F]
|
|
// CHECK:STDOUT: %.loc21: i32 = int_literal 1 [template = constants.%.2]
|
|
// CHECK:STDOUT: assign %b.var, <error>
|
|
// CHECK:STDOUT: %c.var: ref i32 = var c
|
|
// CHECK:STDOUT: %c: ref i32 = bind_name c, %c.var
|
|
// CHECK:STDOUT: %.loc26_20: i32 = int_literal 1 [template = constants.%.2]
|
|
// CHECK:STDOUT: %.loc26_28: i32 = int_literal 2 [template = constants.%.3]
|
|
// CHECK:STDOUT: %.loc26_29.1: {.a: i32, .b: i32} = struct_literal (%.loc26_20, %.loc26_28)
|
|
// CHECK:STDOUT: %.loc26_31: i32 = int_literal 0 [template = constants.%.1]
|
|
// CHECK:STDOUT: %.loc26_29.2: {.a: i32, .b: i32} = struct_value (%.loc26_20, %.loc26_28) [template = constants.%.6]
|
|
// CHECK:STDOUT: %.loc26_29.3: {.a: i32, .b: i32} = converted %.loc26_29.1, %.loc26_29.2 [template = constants.%.6]
|
|
// CHECK:STDOUT: assign %c.var, <error>
|
|
// CHECK:STDOUT: %d.var: ref i32 = var d
|
|
// CHECK:STDOUT: %d: ref i32 = bind_name d, %d.var
|
|
// CHECK:STDOUT: %.loc31_31: type = struct_type {.a: i32, .b: i32} [template = constants.%.4]
|
|
// CHECK:STDOUT: %.loc31_33: i32 = int_literal 0 [template = constants.%.1]
|
|
// CHECK:STDOUT: assign %d.var, <error>
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: fn @F();
|
|
// CHECK:STDOUT:
|