mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-01 22:02:45 +01:00
Jon Ross-Perkins
91f0c23124
Building on #3636 which handles the general import case, add special casing for namespaces. Namespaces can be combined cross-IR, so it's a little more complex. The implementation adds import_id to the Namespace instruction as a reference to find the original using the normal structure. This is achieved by moving the name_id to NameScope to free up space. --- I considered a few alternatives... I considered adding import_id to NameScope, but: 1. It's more consistent with things such as Function or Class that provide name_id on the info object rather than the instruction. 2. I thought it more likely that there would be more NameScope cases that might want a name_id rather than the import_id, since ImportRef will typically be used. I considered putting the import source (cross-ref IR id + inst id) on the NameScope versus a separate ImportRef, which seems like the strongest argument towards the NameScope approach because it removes an instruction. That just felt inconsistent though, and the overhead of instruction-per-imported-namespace should be low (theoretically few namespaces should be used). Plus I feel a bit odd adding two generally-unused ids to NameScope. A specialized Namespace structure could also have been created to store the import_id, but that would add an indirection to the NameScope.
49 lines
2.6 KiB
Plaintext
49 lines
2.6 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// AUTOUPDATE
|
|
|
|
var a: [i32; 1] = (12,);
|
|
// CHECK:STDERR: fail_array_large_index.carbon:[[@LINE+3]]:16: ERROR: Array index `295147905179352825855` is past the end of type `[i32; 1]`.
|
|
// CHECK:STDERR: var b: i32 = a[0xFFFFFFFFFFFFFFFFF];
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~
|
|
var b: i32 = a[0xFFFFFFFFFFFFFFFFF];
|
|
|
|
// CHECK:STDOUT: --- fail_array_large_index.carbon
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: constants {
|
|
// CHECK:STDOUT: %.1: i32 = int_literal 1 [template]
|
|
// CHECK:STDOUT: %.2: type = array_type %.1, i32 [template]
|
|
// CHECK:STDOUT: %.3: type = ptr_type [i32; 1] [template]
|
|
// CHECK:STDOUT: %.4: i32 = int_literal 12 [template]
|
|
// CHECK:STDOUT: %.5: type = tuple_type (i32) [template]
|
|
// CHECK:STDOUT: %.6: i32 = int_literal 0 [template]
|
|
// CHECK:STDOUT: %.7: [i32; 1] = tuple_value (%.4) [template]
|
|
// CHECK:STDOUT: %.8: i32 = int_literal 295147905179352825855 [template]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: file {
|
|
// CHECK:STDOUT: package: <namespace> = namespace {.a = %a, .b = %b} [template]
|
|
// CHECK:STDOUT: %.loc7_14: i32 = int_literal 1 [template = constants.%.1]
|
|
// CHECK:STDOUT: %.loc7_15: type = array_type %.loc7_14, i32 [template = constants.%.2]
|
|
// CHECK:STDOUT: %a.var: ref [i32; 1] = var a
|
|
// CHECK:STDOUT: %a: ref [i32; 1] = bind_name a, %a.var
|
|
// CHECK:STDOUT: %.loc7_20: i32 = int_literal 12 [template = constants.%.4]
|
|
// CHECK:STDOUT: %.loc7_23.1: (i32,) = tuple_literal (%.loc7_20)
|
|
// CHECK:STDOUT: %.loc7_23.2: i32 = int_literal 0 [template = constants.%.6]
|
|
// CHECK:STDOUT: %.loc7_23.3: ref i32 = array_index %a.var, %.loc7_23.2
|
|
// CHECK:STDOUT: %.loc7_23.4: init i32 = initialize_from %.loc7_20 to %.loc7_23.3 [template = constants.%.4]
|
|
// CHECK:STDOUT: %.loc7_23.5: init [i32; 1] = array_init (%.loc7_23.4) to %a.var [template = constants.%.7]
|
|
// CHECK:STDOUT: %.loc7_23.6: init [i32; 1] = converted %.loc7_23.1, %.loc7_23.5 [template = constants.%.7]
|
|
// CHECK:STDOUT: assign %a.var, %.loc7_23.6
|
|
// CHECK:STDOUT: %b.var: ref i32 = var b
|
|
// CHECK:STDOUT: %b: ref i32 = bind_name b, %b.var
|
|
// CHECK:STDOUT: %a.ref: ref [i32; 1] = name_ref a, %a
|
|
// CHECK:STDOUT: %.loc11_16: i32 = int_literal 295147905179352825855 [template = constants.%.8]
|
|
// CHECK:STDOUT: %.loc11_35.1: ref i32 = array_index %a.ref, %.loc11_16 [template = <error>]
|
|
// CHECK:STDOUT: %.loc11_35.2: i32 = bind_value %.loc11_35.1
|
|
// CHECK:STDOUT: assign %b.var, %.loc11_35.2
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|