mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-30 16:25:01 +01:00
Building on #3636 which handles the general import case, add special casing for namespaces. Namespaces can be combined cross-IR, so it's a little more complex. The implementation adds import_id to the Namespace instruction as a reference to find the original using the normal structure. This is achieved by moving the name_id to NameScope to free up space. --- I considered a few alternatives... I considered adding import_id to NameScope, but: 1. It's more consistent with things such as Function or Class that provide name_id on the info object rather than the instruction. 2. I thought it more likely that there would be more NameScope cases that might want a name_id rather than the import_id, since ImportRef will typically be used. I considered putting the import source (cross-ref IR id + inst id) on the NameScope versus a separate ImportRef, which seems like the strongest argument towards the NameScope approach because it removes an instruction. That just felt inconsistent though, and the overhead of instruction-per-imported-namespace should be low (theoretically few namespaces should be used). Plus I feel a bit odd adding two generally-unused ids to NameScope. A specialized Namespace structure could also have been created to store the import_id, but that would add an indirection to the NameScope.
67 lines
2.7 KiB
Plaintext
67 lines
2.7 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// AUTOUPDATE
|
|
|
|
fn F(a: bool, b: bool, c: bool) -> i32 {
|
|
return if a then if b then 1 else 2 else if c then 3 else 4;
|
|
}
|
|
|
|
// CHECK:STDOUT: --- nested.carbon
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: constants {
|
|
// CHECK:STDOUT: %.1: i32 = int_literal 1 [template]
|
|
// CHECK:STDOUT: %.2: i32 = int_literal 2 [template]
|
|
// CHECK:STDOUT: %.3: i32 = int_literal 3 [template]
|
|
// CHECK:STDOUT: %.4: i32 = int_literal 4 [template]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: file {
|
|
// CHECK:STDOUT: package: <namespace> = namespace {.F = %F} [template]
|
|
// CHECK:STDOUT: %F: <function> = fn_decl @F [template]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: fn @F(%a: bool, %b: bool, %c: bool) -> i32 {
|
|
// CHECK:STDOUT: !entry:
|
|
// CHECK:STDOUT: %a.ref: bool = name_ref a, %a
|
|
// CHECK:STDOUT: if %a.ref br !if.expr.then.loc8_10 else br !if.expr.else.loc8_10
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: !if.expr.then.loc8_10:
|
|
// CHECK:STDOUT: %b.ref: bool = name_ref b, %b
|
|
// CHECK:STDOUT: if %b.ref br !if.expr.then.loc8_20 else br !if.expr.else.loc8_20
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: !if.expr.then.loc8_20:
|
|
// CHECK:STDOUT: %.loc8_30: i32 = int_literal 1 [template = constants.%.1]
|
|
// CHECK:STDOUT: br !if.expr.result.loc8_20(%.loc8_30)
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: !if.expr.else.loc8_20:
|
|
// CHECK:STDOUT: %.loc8_37: i32 = int_literal 2 [template = constants.%.2]
|
|
// CHECK:STDOUT: br !if.expr.result.loc8_20(%.loc8_37)
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: !if.expr.result.loc8_20:
|
|
// CHECK:STDOUT: %.loc8_20: i32 = block_arg !if.expr.result.loc8_20
|
|
// CHECK:STDOUT: br !if.expr.result.loc8_10(%.loc8_20)
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: !if.expr.else.loc8_10:
|
|
// CHECK:STDOUT: %c.ref: bool = name_ref c, %c
|
|
// CHECK:STDOUT: if %c.ref br !if.expr.then.loc8_44 else br !if.expr.else.loc8_44
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: !if.expr.then.loc8_44:
|
|
// CHECK:STDOUT: %.loc8_54: i32 = int_literal 3 [template = constants.%.3]
|
|
// CHECK:STDOUT: br !if.expr.result.loc8_44(%.loc8_54)
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: !if.expr.else.loc8_44:
|
|
// CHECK:STDOUT: %.loc8_61: i32 = int_literal 4 [template = constants.%.4]
|
|
// CHECK:STDOUT: br !if.expr.result.loc8_44(%.loc8_61)
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: !if.expr.result.loc8_44:
|
|
// CHECK:STDOUT: %.loc8_44: i32 = block_arg !if.expr.result.loc8_44
|
|
// CHECK:STDOUT: br !if.expr.result.loc8_10(%.loc8_44)
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: !if.expr.result.loc8_10:
|
|
// CHECK:STDOUT: %.loc8_10: i32 = block_arg !if.expr.result.loc8_10
|
|
// CHECK:STDOUT: return %.loc8_10
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|