Files
carbon-lang/toolchain/check/testdata/eval/fail_aggregate.carbon
T
Jon Ross-Perkins 91f0c23124 Provide diagnostic locations for imported namespaces. (#3640)
Building on #3636 which handles the general import case, add special
casing for namespaces. Namespaces can be combined cross-IR, so it's a
little more complex.

The implementation adds import_id to the Namespace instruction as a
reference to find the original using the normal structure. This is
achieved by moving the name_id to NameScope to free up space.

---

I considered a few alternatives...

I considered adding import_id to NameScope, but:

1. It's more consistent with things such as Function or Class that
provide name_id on the info object rather than the instruction.
2. I thought it more likely that there would be more NameScope cases
that might want a name_id rather than the import_id, since ImportRef
will typically be used.

I considered putting the import source (cross-ref IR id + inst id) on
the NameScope versus a separate ImportRef, which seems like the
strongest argument towards the NameScope approach because it removes an
instruction. That just felt inconsistent though, and the overhead of
instruction-per-imported-namespace should be low (theoretically few
namespaces should be used). Plus I feel a bit odd adding two
generally-unused ids to NameScope.

A specialized Namespace structure could also have been created to store
the import_id, but that would add an indirection to the NameScope.
2024-01-24 18:00:32 +00:00

74 lines
4.8 KiB
Plaintext

// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
// AUTOUPDATE
// TODO: This creates an array temporary, which we don't yet support evaluating.
// CHECK:STDERR: fail_aggregate.carbon:[[@LINE+3]]:43: ERROR: Array bound is not a constant.
// CHECK:STDERR: var array_index: [i32; 1] = (0,) as [i32; ((5, 7, 1, 9) as [i32; 4])[2]];
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
var array_index: [i32; 1] = (0,) as [i32; ((5, 7, 1, 9) as [i32; 4])[2]];
// CHECK:STDOUT: --- fail_aggregate.carbon
// CHECK:STDOUT:
// CHECK:STDOUT: constants {
// CHECK:STDOUT: %.1: i32 = int_literal 1 [template]
// CHECK:STDOUT: %.2: type = array_type %.1, i32 [template]
// CHECK:STDOUT: %.3: type = ptr_type [i32; 1] [template]
// CHECK:STDOUT: %.4: i32 = int_literal 0 [template]
// CHECK:STDOUT: %.5: type = tuple_type (i32) [template]
// CHECK:STDOUT: %.6: i32 = int_literal 5 [template]
// CHECK:STDOUT: %.7: i32 = int_literal 7 [template]
// CHECK:STDOUT: %.8: i32 = int_literal 9 [template]
// CHECK:STDOUT: %.9: type = tuple_type (i32, i32, i32, i32) [template]
// CHECK:STDOUT: %.10: i32 = int_literal 4 [template]
// CHECK:STDOUT: %.11: type = array_type %.10, i32 [template]
// CHECK:STDOUT: %.12: type = ptr_type [i32; 4] [template]
// CHECK:STDOUT: %.13: i32 = int_literal 0 [template]
// CHECK:STDOUT: %.14: i32 = int_literal 1 [template]
// CHECK:STDOUT: %.15: i32 = int_literal 2 [template]
// CHECK:STDOUT: %.16: i32 = int_literal 3 [template]
// CHECK:STDOUT: %.17: [i32; 4] = tuple_value (%.6, %.7, %.1, %.8) [template]
// CHECK:STDOUT: %.18: i32 = int_literal 2 [template]
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: file {
// CHECK:STDOUT: package: <namespace> = namespace {.array_index = %array_index} [template]
// CHECK:STDOUT: %.loc12_24: i32 = int_literal 1 [template = constants.%.1]
// CHECK:STDOUT: %.loc12_25: type = array_type %.loc12_24, i32 [template = constants.%.2]
// CHECK:STDOUT: %array_index.var: ref [i32; 1] = var array_index
// CHECK:STDOUT: %array_index: ref [i32; 1] = bind_name array_index, %array_index.var
// CHECK:STDOUT: %.loc12_30: i32 = int_literal 0 [template = constants.%.4]
// CHECK:STDOUT: %.loc12_32: (i32,) = tuple_literal (%.loc12_30)
// CHECK:STDOUT: %.loc12_45: i32 = int_literal 5 [template = constants.%.6]
// CHECK:STDOUT: %.loc12_48: i32 = int_literal 7 [template = constants.%.7]
// CHECK:STDOUT: %.loc12_51: i32 = int_literal 1 [template = constants.%.1]
// CHECK:STDOUT: %.loc12_54: i32 = int_literal 9 [template = constants.%.8]
// CHECK:STDOUT: %.loc12_55.1: (i32, i32, i32, i32) = tuple_literal (%.loc12_45, %.loc12_48, %.loc12_51, %.loc12_54)
// CHECK:STDOUT: %.loc12_66: i32 = int_literal 4 [template = constants.%.10]
// CHECK:STDOUT: %.loc12_67: type = array_type %.loc12_66, i32 [template = constants.%.11]
// CHECK:STDOUT: %.loc12_55.2: ref [i32; 4] = temporary_storage
// CHECK:STDOUT: %.loc12_55.3: i32 = int_literal 0 [template = constants.%.13]
// CHECK:STDOUT: %.loc12_55.4: ref i32 = array_index %.loc12_55.2, %.loc12_55.3
// CHECK:STDOUT: %.loc12_55.5: init i32 = initialize_from %.loc12_45 to %.loc12_55.4 [template = constants.%.6]
// CHECK:STDOUT: %.loc12_55.6: i32 = int_literal 1 [template = constants.%.14]
// CHECK:STDOUT: %.loc12_55.7: ref i32 = array_index %.loc12_55.2, %.loc12_55.6
// CHECK:STDOUT: %.loc12_55.8: init i32 = initialize_from %.loc12_48 to %.loc12_55.7 [template = constants.%.7]
// CHECK:STDOUT: %.loc12_55.9: i32 = int_literal 2 [template = constants.%.15]
// CHECK:STDOUT: %.loc12_55.10: ref i32 = array_index %.loc12_55.2, %.loc12_55.9
// CHECK:STDOUT: %.loc12_55.11: init i32 = initialize_from %.loc12_51 to %.loc12_55.10 [template = constants.%.1]
// CHECK:STDOUT: %.loc12_55.12: i32 = int_literal 3 [template = constants.%.16]
// CHECK:STDOUT: %.loc12_55.13: ref i32 = array_index %.loc12_55.2, %.loc12_55.12
// CHECK:STDOUT: %.loc12_55.14: init i32 = initialize_from %.loc12_54 to %.loc12_55.13 [template = constants.%.8]
// CHECK:STDOUT: %.loc12_55.15: init [i32; 4] = array_init (%.loc12_55.5, %.loc12_55.8, %.loc12_55.11, %.loc12_55.14) to %.loc12_55.2 [template = constants.%.17]
// CHECK:STDOUT: %.loc12_55.16: init [i32; 4] = converted %.loc12_55.1, %.loc12_55.15 [template = constants.%.17]
// CHECK:STDOUT: %.loc12_70: i32 = int_literal 2 [template = constants.%.18]
// CHECK:STDOUT: %.loc12_55.17: ref [i32; 4] = temporary %.loc12_55.2, %.loc12_55.16
// CHECK:STDOUT: %.loc12_71.1: ref i32 = array_index %.loc12_55.17, %.loc12_70
// CHECK:STDOUT: %.loc12_71.2: i32 = bind_value %.loc12_71.1
// CHECK:STDOUT: assign %array_index.var, <error>
// CHECK:STDOUT: }
// CHECK:STDOUT: