mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-01 22:02:45 +01:00
Jon Ross-Perkins
91f0c23124
Building on #3636 which handles the general import case, add special casing for namespaces. Namespaces can be combined cross-IR, so it's a little more complex. The implementation adds import_id to the Namespace instruction as a reference to find the original using the normal structure. This is achieved by moving the name_id to NameScope to free up space. --- I considered a few alternatives... I considered adding import_id to NameScope, but: 1. It's more consistent with things such as Function or Class that provide name_id on the info object rather than the instruction. 2. I thought it more likely that there would be more NameScope cases that might want a name_id rather than the import_id, since ImportRef will typically be used. I considered putting the import source (cross-ref IR id + inst id) on the NameScope versus a separate ImportRef, which seems like the strongest argument towards the NameScope approach because it removes an instruction. That just felt inconsistent though, and the overhead of instruction-per-imported-namespace should be low (theoretically few namespaces should be used). Plus I feel a bit odd adding two generally-unused ids to NameScope. A specialized Namespace structure could also have been created to store the import_id, but that would add an indirection to the NameScope.
85 lines
4.3 KiB
Plaintext
85 lines
4.3 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// AUTOUPDATE
|
|
|
|
class Class {
|
|
var a: i32;
|
|
var b: i32;
|
|
}
|
|
|
|
fn F() {
|
|
// CHECK:STDERR: fail_init.carbon:[[@LINE+3]]:3: ERROR: Cannot initialize class with 2 field(s) from struct with 1 field(s).
|
|
// CHECK:STDERR: {.a = 1} as Class;
|
|
// CHECK:STDERR: ^~~~~~~~
|
|
{.a = 1} as Class;
|
|
// CHECK:STDERR: fail_init.carbon:[[@LINE+3]]:3: ERROR: Missing value for field `b` in struct initialization.
|
|
// CHECK:STDERR: {.a = 1, .c = 2} as Class;
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~
|
|
{.a = 1, .c = 2} as Class;
|
|
// CHECK:STDERR: fail_init.carbon:[[@LINE+3]]:3: ERROR: Cannot initialize class with 2 field(s) from struct with 3 field(s).
|
|
// CHECK:STDERR: {.a = 1, .b = 2, .c = 3} as Class;
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~~~~
|
|
{.a = 1, .b = 2, .c = 3} as Class;
|
|
}
|
|
|
|
// CHECK:STDOUT: --- fail_init.carbon
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: constants {
|
|
// CHECK:STDOUT: %Class: type = class_type @Class [template]
|
|
// CHECK:STDOUT: %.1: type = unbound_element_type Class, i32 [template]
|
|
// CHECK:STDOUT: %.2: type = struct_type {.a: i32, .b: i32} [template]
|
|
// CHECK:STDOUT: %.3: i32 = int_literal 1 [template]
|
|
// CHECK:STDOUT: %.4: type = struct_type {.a: i32} [template]
|
|
// CHECK:STDOUT: %.5: type = ptr_type {.a: i32, .b: i32} [template]
|
|
// CHECK:STDOUT: %.6: i32 = int_literal 2 [template]
|
|
// CHECK:STDOUT: %.7: type = struct_type {.a: i32, .c: i32} [template]
|
|
// CHECK:STDOUT: %.8: i32 = int_literal 3 [template]
|
|
// CHECK:STDOUT: %.9: type = struct_type {.a: i32, .b: i32, .c: i32} [template]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: file {
|
|
// CHECK:STDOUT: package: <namespace> = namespace {.Class = %Class.decl, .F = %F} [template]
|
|
// CHECK:STDOUT: %Class.decl = class_decl @Class, ()
|
|
// CHECK:STDOUT: %F: <function> = fn_decl @F [template]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: class @Class {
|
|
// CHECK:STDOUT: %.loc8: <unbound element of class Class> = field_decl a, element0 [template]
|
|
// CHECK:STDOUT: %.loc9: <unbound element of class Class> = field_decl b, element1 [template]
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: !members:
|
|
// CHECK:STDOUT: .a = %.loc8
|
|
// CHECK:STDOUT: .b = %.loc9
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: fn @F() {
|
|
// CHECK:STDOUT: !entry:
|
|
// CHECK:STDOUT: %.loc16_9: i32 = int_literal 1 [template = constants.%.3]
|
|
// CHECK:STDOUT: %.loc16_10.1: {.a: i32} = struct_literal (%.loc16_9)
|
|
// CHECK:STDOUT: %Class.ref.loc16: type = name_ref Class, constants.%Class [template = constants.%Class]
|
|
// CHECK:STDOUT: %.loc16_10.2: ref Class = temporary_storage
|
|
// CHECK:STDOUT: %.loc16_10.3: ref Class = temporary %.loc16_10.2, <error>
|
|
// CHECK:STDOUT: %.loc16_10.4: ref Class = converted %.loc16_10.1, %.loc16_10.3
|
|
// CHECK:STDOUT: %.loc20_9: i32 = int_literal 1 [template = constants.%.3]
|
|
// CHECK:STDOUT: %.loc20_17: i32 = int_literal 2 [template = constants.%.6]
|
|
// CHECK:STDOUT: %.loc20_18.1: {.a: i32, .c: i32} = struct_literal (%.loc20_9, %.loc20_17)
|
|
// CHECK:STDOUT: %Class.ref.loc20: type = name_ref Class, constants.%Class [template = constants.%Class]
|
|
// CHECK:STDOUT: %.loc20_18.2: ref Class = temporary_storage
|
|
// CHECK:STDOUT: %.loc20_18.3: ref i32 = class_element_access %.loc20_18.2, element0
|
|
// CHECK:STDOUT: %.loc20_18.4: init i32 = initialize_from %.loc20_9 to %.loc20_18.3 [template = constants.%.3]
|
|
// CHECK:STDOUT: %.loc20_18.5: ref Class = temporary %.loc20_18.2, <error>
|
|
// CHECK:STDOUT: %.loc20_18.6: ref Class = converted %.loc20_18.1, %.loc20_18.5
|
|
// CHECK:STDOUT: %.loc24_9: i32 = int_literal 1 [template = constants.%.3]
|
|
// CHECK:STDOUT: %.loc24_17: i32 = int_literal 2 [template = constants.%.6]
|
|
// CHECK:STDOUT: %.loc24_25: i32 = int_literal 3 [template = constants.%.8]
|
|
// CHECK:STDOUT: %.loc24_26.1: {.a: i32, .b: i32, .c: i32} = struct_literal (%.loc24_9, %.loc24_17, %.loc24_25)
|
|
// CHECK:STDOUT: %Class.ref.loc24: type = name_ref Class, constants.%Class [template = constants.%Class]
|
|
// CHECK:STDOUT: %.loc24_26.2: ref Class = temporary_storage
|
|
// CHECK:STDOUT: %.loc24_26.3: ref Class = temporary %.loc24_26.2, <error>
|
|
// CHECK:STDOUT: %.loc24_26.4: ref Class = converted %.loc24_26.1, %.loc24_26.3
|
|
// CHECK:STDOUT: return
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|