Files
carbon-lang/toolchain/check/testdata/class/base_field.carbon
T
Jon Ross-Perkins 91f0c23124 Provide diagnostic locations for imported namespaces. (#3640)
Building on #3636 which handles the general import case, add special
casing for namespaces. Namespaces can be combined cross-IR, so it's a
little more complex.

The implementation adds import_id to the Namespace instruction as a
reference to find the original using the normal structure. This is
achieved by moving the name_id to NameScope to free up space.

---

I considered a few alternatives...

I considered adding import_id to NameScope, but:

1. It's more consistent with things such as Function or Class that
provide name_id on the info object rather than the instruction.
2. I thought it more likely that there would be more NameScope cases
that might want a name_id rather than the import_id, since ImportRef
will typically be used.

I considered putting the import source (cross-ref IR id + inst id) on
the NameScope versus a separate ImportRef, which seems like the
strongest argument towards the NameScope approach because it removes an
instruction. That just felt inconsistent though, and the overhead of
instruction-per-imported-namespace should be low (theoretically few
namespaces should be used). Plus I feel a bit odd adding two
generally-unused ids to NameScope.

A specialized Namespace structure could also have been created to store
the import_id, but that would add an indirection to the NameScope.
2024-01-24 18:00:32 +00:00

84 lines
3.5 KiB
Plaintext

// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
// AUTOUPDATE
base class Base {
var a: i32;
var b: i32;
var c: i32;
}
class Derived {
extend base: Base;
var d: i32;
var e: i32;
}
fn Access(p: Derived*) -> i32* {
return &(*p).c;
}
// CHECK:STDOUT: --- base_field.carbon
// CHECK:STDOUT:
// CHECK:STDOUT: constants {
// CHECK:STDOUT: %Base: type = class_type @Base [template]
// CHECK:STDOUT: %.1: type = unbound_element_type Base, i32 [template]
// CHECK:STDOUT: %.2: type = struct_type {.a: i32, .b: i32, .c: i32} [template]
// CHECK:STDOUT: %Derived: type = class_type @Derived [template]
// CHECK:STDOUT: %.3: type = ptr_type {.a: i32, .b: i32, .c: i32} [template]
// CHECK:STDOUT: %.4: type = unbound_element_type Derived, Base [template]
// CHECK:STDOUT: %.5: type = unbound_element_type Derived, i32 [template]
// CHECK:STDOUT: %.6: type = struct_type {.base: Base, .d: i32, .e: i32} [template]
// CHECK:STDOUT: %.7: type = ptr_type Derived [template]
// CHECK:STDOUT: %.8: type = ptr_type i32 [template]
// CHECK:STDOUT: %.9: type = struct_type {.base: {.a: i32, .b: i32, .c: i32}*, .d: i32, .e: i32} [template]
// CHECK:STDOUT: %.10: type = ptr_type {.base: {.a: i32, .b: i32, .c: i32}*, .d: i32, .e: i32} [template]
// CHECK:STDOUT: %.11: type = ptr_type {.base: Base, .d: i32, .e: i32} [template]
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: file {
// CHECK:STDOUT: package: <namespace> = namespace {.Base = %Base.decl, .Derived = %Derived.decl, .Access = %Access} [template]
// CHECK:STDOUT: %Base.decl = class_decl @Base, ()
// CHECK:STDOUT: %Derived.decl = class_decl @Derived, ()
// CHECK:STDOUT: %Access: <function> = fn_decl @Access [template]
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: class @Base {
// CHECK:STDOUT: %.loc8: <unbound element of class Base> = field_decl a, element0 [template]
// CHECK:STDOUT: %.loc9: <unbound element of class Base> = field_decl b, element1 [template]
// CHECK:STDOUT: %.loc10: <unbound element of class Base> = field_decl c, element2 [template]
// CHECK:STDOUT:
// CHECK:STDOUT: !members:
// CHECK:STDOUT: .a = %.loc8
// CHECK:STDOUT: .b = %.loc9
// CHECK:STDOUT: .c = %.loc10
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: class @Derived {
// CHECK:STDOUT: %Base.ref: type = name_ref Base, constants.%Base [template = constants.%Base]
// CHECK:STDOUT: %.loc14: <unbound element of class Derived> = base_decl Base, element0 [template]
// CHECK:STDOUT: %.loc16: <unbound element of class Derived> = field_decl d, element1 [template]
// CHECK:STDOUT: %.loc17: <unbound element of class Derived> = field_decl e, element2 [template]
// CHECK:STDOUT:
// CHECK:STDOUT: !members:
// CHECK:STDOUT: .base = %.loc14
// CHECK:STDOUT: .d = %.loc16
// CHECK:STDOUT: .e = %.loc17
// CHECK:STDOUT: extend name_scope1
// CHECK:STDOUT: }
// CHECK:STDOUT:
// CHECK:STDOUT: fn @Access(%p: Derived*) -> i32* {
// CHECK:STDOUT: !entry:
// CHECK:STDOUT: %p.ref: Derived* = name_ref p, %p
// CHECK:STDOUT: %.loc21_12.1: ref Derived = deref %p.ref
// CHECK:STDOUT: %.loc21_15.1: ref Base = class_element_access %.loc21_12.1, element0
// CHECK:STDOUT: %.loc21_12.2: ref Base = converted %.loc21_12.1, %.loc21_15.1
// CHECK:STDOUT: %.loc21_15.2: ref i32 = class_element_access %.loc21_12.2, element2
// CHECK:STDOUT: %.loc21_10: i32* = addr_of %.loc21_15.2
// CHECK:STDOUT: return %.loc21_10
// CHECK:STDOUT: }
// CHECK:STDOUT: