mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-30 21:55:02 +01:00
Jon Ross-Perkins
91f0c23124
Building on #3636 which handles the general import case, add special casing for namespaces. Namespaces can be combined cross-IR, so it's a little more complex. The implementation adds import_id to the Namespace instruction as a reference to find the original using the normal structure. This is achieved by moving the name_id to NameScope to free up space. --- I considered a few alternatives... I considered adding import_id to NameScope, but: 1. It's more consistent with things such as Function or Class that provide name_id on the info object rather than the instruction. 2. I thought it more likely that there would be more NameScope cases that might want a name_id rather than the import_id, since ImportRef will typically be used. I considered putting the import source (cross-ref IR id + inst id) on the NameScope versus a separate ImportRef, which seems like the strongest argument towards the NameScope approach because it removes an instruction. That just felt inconsistent though, and the overhead of instruction-per-imported-namespace should be low (theoretically few namespaces should be used). Plus I feel a bit odd adding two generally-unused ids to NameScope. A specialized Namespace structure could also have been created to store the import_id, but that would add an indirection to the NameScope.
40 lines
1.9 KiB
Plaintext
40 lines
1.9 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// AUTOUPDATE
|
|
|
|
// CHECK:STDERR: fail_bound_overflow.carbon:[[@LINE+3]]:14: ERROR: Array bound of 39999999999999999993 is too large.
|
|
// CHECK:STDERR: var a: [i32; 39999999999999999993];
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~
|
|
var a: [i32; 39999999999999999993];
|
|
|
|
// CHECK:STDERR: fail_bound_overflow.carbon:[[@LINE+6]]:9: ERROR: Cannot implicitly convert from `i32` to `type`.
|
|
// CHECK:STDERR: var b: [1; 39999999999999999993];
|
|
// CHECK:STDERR: ^
|
|
// CHECK:STDERR: fail_bound_overflow.carbon:[[@LINE+3]]:12: ERROR: Array bound of 39999999999999999993 is too large.
|
|
// CHECK:STDERR: var b: [1; 39999999999999999993];
|
|
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~
|
|
var b: [1; 39999999999999999993];
|
|
|
|
// CHECK:STDOUT: --- fail_bound_overflow.carbon
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: constants {
|
|
// CHECK:STDOUT: %.1: i32 = int_literal 39999999999999999993 [template]
|
|
// CHECK:STDOUT: %.2: i32 = int_literal 1 [template]
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|
|
// CHECK:STDOUT: file {
|
|
// CHECK:STDOUT: package: <namespace> = namespace {.a = %a, .b = %b} [template]
|
|
// CHECK:STDOUT: %.loc10_14: i32 = int_literal 39999999999999999993 [template = constants.%.1]
|
|
// CHECK:STDOUT: %.loc10_34: type = array_type %.loc10_14, i32 [template = <error>]
|
|
// CHECK:STDOUT: %a.var: ref <error> = var a
|
|
// CHECK:STDOUT: %a: ref <error> = bind_name a, %a.var
|
|
// CHECK:STDOUT: %.loc18_9: i32 = int_literal 1 [template = constants.%.2]
|
|
// CHECK:STDOUT: %.loc18_12: i32 = int_literal 39999999999999999993 [template = constants.%.1]
|
|
// CHECK:STDOUT: %.loc18_32: type = array_type %.loc18_12, <error> [template = <error>]
|
|
// CHECK:STDOUT: %b.var: ref <error> = var b
|
|
// CHECK:STDOUT: %b: ref <error> = bind_name b, %b.var
|
|
// CHECK:STDOUT: }
|
|
// CHECK:STDOUT:
|