mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-04 19:11:11 +01:00
Chandler CarruthandJon Ross-Perkins
13de9e9d06
Recent runs of `clang-tidy` for me started showing more errors, and this is a collection of changes to address them. First, I've systematically applied the disabling tag to all C++ rules under //explorer/... with `buildozer` so we don't spend time analyzing this code or reporting errors from it. Not sure this was strictly necessary, but it seemed like a nice consistency improvement. Next, I disabled a buggy check for missing `default` cases in `switch`es. It seems to get confused by the fancy conversions in our `enum_base.h`. We don't miss much with this as the Clang compiler warnings for `switch` catch most of our actual bugs. I also removed the local disabling of this now that it is turned off centrally. Lastly, I added error checking to two file descriptor manipulating calls in the `file_test` infrastructure. --------- Co-authored-by: Jon Ross-Perkins <jperkins@google.com>
165 lines
4.2 KiB
Python
165 lines
4.2 KiB
Python
# Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
# Exceptions. See /LICENSE for license information.
|
|
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test")
|
|
|
|
package(default_visibility = ["//explorer:__subpackages__"])
|
|
|
|
cc_library(
|
|
name = "arena",
|
|
hdrs = ["arena.h"],
|
|
# Running clang-tidy is slow, and explorer is currently feature frozen, so
|
|
# don't spend time linting it.
|
|
tags = ["no-clang-tidy"],
|
|
deps = [
|
|
":nonnull",
|
|
"@llvm-project//llvm:Support",
|
|
],
|
|
)
|
|
|
|
cc_test(
|
|
name = "arena_test",
|
|
size = "small",
|
|
srcs = ["arena_test.cpp"],
|
|
# Running clang-tidy is slow, and explorer is currently feature frozen, so
|
|
# don't spend time linting it.
|
|
tags = ["no-clang-tidy"],
|
|
deps = [
|
|
":arena",
|
|
"//testing/base:gtest_main",
|
|
"@com_google_googletest//:gtest",
|
|
],
|
|
)
|
|
|
|
cc_library(
|
|
name = "decompose",
|
|
hdrs = ["decompose.h"],
|
|
# Running clang-tidy is slow, and explorer is currently feature frozen, so
|
|
# don't spend time linting it.
|
|
tags = ["no-clang-tidy"],
|
|
deps = [
|
|
"@llvm-project//llvm:Support",
|
|
],
|
|
)
|
|
|
|
cc_test(
|
|
name = "decompose_test",
|
|
size = "small",
|
|
srcs = ["decompose_test.cpp"],
|
|
# Running clang-tidy is slow, and explorer is currently feature frozen, so
|
|
# don't spend time linting it.
|
|
tags = ["no-clang-tidy"],
|
|
deps = [
|
|
":decompose",
|
|
"//testing/base:gtest_main",
|
|
"@com_google_googletest//:gtest",
|
|
],
|
|
)
|
|
|
|
cc_library(
|
|
name = "error_builders",
|
|
hdrs = ["error_builders.h"],
|
|
# Running clang-tidy is slow, and explorer is currently feature frozen, so
|
|
# don't spend time linting it.
|
|
tags = ["no-clang-tidy"],
|
|
deps = [
|
|
":source_location",
|
|
"//common:error",
|
|
],
|
|
)
|
|
|
|
cc_test(
|
|
name = "error_builders_test",
|
|
size = "small",
|
|
srcs = ["error_builders_test.cpp"],
|
|
# Running clang-tidy is slow, and explorer is currently feature frozen, so
|
|
# don't spend time linting it.
|
|
tags = ["no-clang-tidy"],
|
|
deps = [
|
|
":error_builders",
|
|
":source_location",
|
|
"//testing/base:gtest_main",
|
|
"//testing/base:test_raw_ostream",
|
|
"@com_google_googletest//:gtest",
|
|
],
|
|
)
|
|
|
|
cc_library(
|
|
name = "nonnull",
|
|
hdrs = ["nonnull.h"],
|
|
# Running clang-tidy is slow, and explorer is currently feature frozen, so
|
|
# don't spend time linting it.
|
|
tags = ["no-clang-tidy"],
|
|
deps = [
|
|
"//common:check",
|
|
],
|
|
)
|
|
|
|
cc_library(
|
|
name = "print_as_id",
|
|
hdrs = ["print_as_id.h"],
|
|
# Running clang-tidy is slow, and explorer is currently feature frozen, so
|
|
# don't spend time linting it.
|
|
tags = ["no-clang-tidy"],
|
|
deps = [
|
|
"//common:ostream",
|
|
],
|
|
)
|
|
|
|
cc_library(
|
|
name = "source_location",
|
|
hdrs = ["source_location.h"],
|
|
# Running clang-tidy is slow, and explorer is currently feature frozen, so
|
|
# don't spend time linting it.
|
|
tags = ["no-clang-tidy"],
|
|
deps = [
|
|
":nonnull",
|
|
"//common:ostream",
|
|
],
|
|
)
|
|
|
|
cc_library(
|
|
name = "trace_stream",
|
|
hdrs = ["trace_stream.h"],
|
|
# Running clang-tidy is slow, and explorer is currently feature frozen, so
|
|
# don't spend time linting it.
|
|
tags = ["no-clang-tidy"],
|
|
deps = [
|
|
":source_location",
|
|
"//common:check",
|
|
"//common:ostream",
|
|
"//explorer/base:nonnull",
|
|
"@llvm-project//llvm:Support",
|
|
],
|
|
)
|
|
|
|
cc_test(
|
|
name = "set_program_phase_raii_test",
|
|
size = "small",
|
|
srcs = ["set_program_phase_raii_test.cpp"],
|
|
# Running clang-tidy is slow, and explorer is currently feature frozen, so
|
|
# don't spend time linting it.
|
|
tags = ["no-clang-tidy"],
|
|
deps = [
|
|
":trace_stream",
|
|
"//testing/base:gtest_main",
|
|
"@com_google_googletest//:gtest",
|
|
],
|
|
)
|
|
|
|
cc_test(
|
|
name = "set_file_context_raii_test",
|
|
size = "small",
|
|
srcs = ["set_file_context_raii_test.cpp"],
|
|
# Running clang-tidy is slow, and explorer is currently feature frozen, so
|
|
# don't spend time linting it.
|
|
tags = ["no-clang-tidy"],
|
|
deps = [
|
|
":source_location",
|
|
":trace_stream",
|
|
"//testing/base:gtest_main",
|
|
"@com_google_googletest//:gtest",
|
|
],
|
|
)
|