mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-05 18:11:08 +01:00
Chandler CarruthandJon Ross-Perkins
13de9e9d06
Recent runs of `clang-tidy` for me started showing more errors, and this is a collection of changes to address them. First, I've systematically applied the disabling tag to all C++ rules under //explorer/... with `buildozer` so we don't spend time analyzing this code or reporting errors from it. Not sure this was strictly necessary, but it seemed like a nice consistency improvement. Next, I disabled a buggy check for missing `default` cases in `switch`es. It seems to get confused by the fancy conversions in our `enum_base.h`. We don't miss much with this as the Clang compiler warnings for `switch` catch most of our actual bugs. I also removed the local disabling of this now that it is turned off centrally. Lastly, I added error checking to two file descriptor manipulating calls in the `file_test` infrastructure. --------- Co-authored-by: Jon Ross-Perkins <jperkins@google.com>
203 lines
5.3 KiB
Python
203 lines
5.3 KiB
Python
# Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
# Exceptions. See /LICENSE for license information.
|
|
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test")
|
|
|
|
package(default_visibility = ["//explorer:__subpackages__"])
|
|
|
|
cc_library(
|
|
name = "ast",
|
|
srcs = [
|
|
"ast_node.cpp",
|
|
"ast_rtti.cpp",
|
|
"bindings.cpp",
|
|
"clone_context.cpp",
|
|
"declaration.cpp",
|
|
"element.cpp",
|
|
"expression.cpp",
|
|
"impl_binding.cpp",
|
|
"pattern.cpp",
|
|
"statement.cpp",
|
|
"value.cpp",
|
|
],
|
|
hdrs = [
|
|
"address.h",
|
|
"ast.h",
|
|
"ast_kinds.h",
|
|
"ast_node.h",
|
|
"ast_rtti.h",
|
|
"bindings.h",
|
|
"clone_context.h",
|
|
"declaration.h",
|
|
"element.h",
|
|
"element_path.h",
|
|
"expression.h",
|
|
"impl_binding.h",
|
|
"pattern.h",
|
|
"return_term.h",
|
|
"statement.h",
|
|
"value.h",
|
|
"value_node.h",
|
|
"value_transform.h",
|
|
],
|
|
# Running clang-tidy is slow, and explorer is currently feature frozen, so
|
|
# don't spend time linting it.
|
|
tags = ["no-clang-tidy"],
|
|
textual_hdrs = [
|
|
"value_kinds.def",
|
|
],
|
|
deps = [
|
|
":expression_category",
|
|
":library_name",
|
|
":paren_contents",
|
|
"//common:check",
|
|
"//common:enum_base",
|
|
"//common:error",
|
|
"//common:indirect_value",
|
|
"//common:ostream",
|
|
"//explorer/base:arena",
|
|
"//explorer/base:decompose",
|
|
"//explorer/base:error_builders",
|
|
"//explorer/base:nonnull",
|
|
"//explorer/base:print_as_id",
|
|
"//explorer/base:source_location",
|
|
"@llvm-project//llvm:Support",
|
|
],
|
|
)
|
|
|
|
cc_library(
|
|
name = "ast_test_matchers",
|
|
testonly = 1,
|
|
srcs = [
|
|
"ast_test_matchers_internal.cpp",
|
|
"ast_test_matchers_internal.h",
|
|
],
|
|
hdrs = ["ast_test_matchers.h"],
|
|
# Running clang-tidy is slow, and explorer is currently feature frozen, so
|
|
# don't spend time linting it.
|
|
tags = ["no-clang-tidy"],
|
|
deps = [
|
|
":ast",
|
|
"@com_google_googletest//:gtest",
|
|
"@llvm-project//llvm:Support",
|
|
],
|
|
)
|
|
|
|
cc_test(
|
|
name = "ast_test_matchers_test",
|
|
size = "small",
|
|
srcs = ["ast_test_matchers_test.cpp"],
|
|
# Running clang-tidy is slow, and explorer is currently feature frozen, so
|
|
# don't spend time linting it.
|
|
tags = ["no-clang-tidy"],
|
|
deps = [
|
|
":ast",
|
|
":ast_test_matchers",
|
|
"//explorer/base:arena",
|
|
"//testing/base:gtest_main",
|
|
"@com_google_googletest//:gtest",
|
|
],
|
|
)
|
|
|
|
cc_test(
|
|
name = "expression_test",
|
|
size = "small",
|
|
srcs = ["expression_test.cpp"],
|
|
# Running clang-tidy is slow, and explorer is currently feature frozen, so
|
|
# don't spend time linting it.
|
|
tags = ["no-clang-tidy"],
|
|
deps = [
|
|
":ast",
|
|
":paren_contents",
|
|
"//explorer/base:arena",
|
|
"//testing/base:gtest_main",
|
|
"@com_google_googletest//:gtest",
|
|
"@llvm-project//llvm:Support",
|
|
],
|
|
)
|
|
|
|
cc_library(
|
|
name = "library_name",
|
|
hdrs = ["library_name.h"],
|
|
# Running clang-tidy is slow, and explorer is currently feature frozen, so
|
|
# don't spend time linting it.
|
|
tags = ["no-clang-tidy"],
|
|
)
|
|
|
|
cc_library(
|
|
name = "paren_contents",
|
|
hdrs = ["paren_contents.h"],
|
|
# Running clang-tidy is slow, and explorer is currently feature frozen, so
|
|
# don't spend time linting it.
|
|
tags = ["no-clang-tidy"],
|
|
deps = [
|
|
"//explorer/base:error_builders",
|
|
"//explorer/base:source_location",
|
|
],
|
|
)
|
|
|
|
cc_test(
|
|
name = "element_test",
|
|
size = "small",
|
|
srcs = ["element_test.cpp"],
|
|
# Running clang-tidy is slow, and explorer is currently feature frozen, so
|
|
# don't spend time linting it.
|
|
tags = ["no-clang-tidy"],
|
|
deps = [
|
|
":ast",
|
|
":paren_contents",
|
|
"//explorer/base:arena",
|
|
"//testing/base:gtest_main",
|
|
"@com_google_googletest//:gtest",
|
|
"@llvm-project//llvm:Support",
|
|
],
|
|
)
|
|
|
|
cc_test(
|
|
name = "pattern_test",
|
|
size = "small",
|
|
srcs = ["pattern_test.cpp"],
|
|
# Running clang-tidy is slow, and explorer is currently feature frozen, so
|
|
# don't spend time linting it.
|
|
tags = ["no-clang-tidy"],
|
|
deps = [
|
|
":ast",
|
|
":paren_contents",
|
|
"//explorer/base:arena",
|
|
"//testing/base:gtest_main",
|
|
"@com_google_googletest//:gtest",
|
|
"@llvm-project//llvm:Support",
|
|
],
|
|
)
|
|
|
|
cc_library(
|
|
name = "static_scope",
|
|
srcs = ["static_scope.cpp"],
|
|
hdrs = ["static_scope.h"],
|
|
# Running clang-tidy is slow, and explorer is currently feature frozen, so
|
|
# don't spend time linting it.
|
|
tags = ["no-clang-tidy"],
|
|
deps = [
|
|
":ast",
|
|
"//common:check",
|
|
"//common:error",
|
|
"//common:ostream",
|
|
"//explorer/base:error_builders",
|
|
"//explorer/base:nonnull",
|
|
"//explorer/base:print_as_id",
|
|
"//explorer/base:source_location",
|
|
"//explorer/base:trace_stream",
|
|
"@llvm-project//llvm:Support",
|
|
],
|
|
)
|
|
|
|
cc_library(
|
|
name = "expression_category",
|
|
hdrs = ["expression_category.h"],
|
|
# Running clang-tidy is slow, and explorer is currently feature frozen, so
|
|
# don't spend time linting it.
|
|
tags = ["no-clang-tidy"],
|
|
deps = ["@llvm-project//llvm:Support"],
|
|
)
|