Files
carbon-lang/toolchain/testing/compile_helper.cpp
T
Jon Ross-Perkins ae16332a11 Fix handling of null StringRef file buffers (#5428)
The current behavior hits UBSAN and ASAN issues.

Note, `RequiresNullTerminator` is already set to `false` in
`source_buffer.cpp`; setting it in `compile_helper.cpp` is making things
more consistent. The related logic is an [assert
fail](https://github.com/llvm/llvm-project/blob/main/llvm/lib/Support/MemoryBuffer.cpp#L52).

This was fuzzer-discovered.
2025-05-07 22:42:58 +00:00

63 lines
2.3 KiB
C++

// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
#include "toolchain/testing/compile_helper.h"
#include <string>
#include <utility>
namespace Carbon::Testing {
auto CompileHelper::GetTokenizedBuffer(llvm::StringRef text,
Diagnostics::Consumer* consumer)
-> Lex::TokenizedBuffer& {
auto& source = GetSourceBuffer(text);
value_store_storage_.emplace_front();
token_storage_.push_front(Lex::Lex(value_store_storage_.front(), source,
consumer ? *consumer : consumer_));
return token_storage_.front();
}
auto CompileHelper::GetTokenizedBufferWithSharedValueStore(
llvm::StringRef text, Diagnostics::Consumer* consumer)
-> std::pair<Lex::TokenizedBuffer&, SharedValueStores&> {
auto& tokens = GetTokenizedBuffer(text, consumer);
return {tokens, value_store_storage_.front()};
}
auto CompileHelper::GetTree(llvm::StringRef text) -> Parse::Tree& {
auto& tokens = GetTokenizedBuffer(text);
tree_storage_.push_front(Parse::Parse(tokens, consumer_,
/*vlog_stream=*/nullptr));
return tree_storage_.front();
}
auto CompileHelper::GetTreeAndSubtrees(llvm::StringRef text)
-> Parse::TreeAndSubtrees& {
auto& tree = GetTree(text);
tree_and_subtrees_storage_.push_front(
Parse::TreeAndSubtrees(token_storage_.front(), tree));
return tree_and_subtrees_storage_.front();
}
auto CompileHelper::GetTokenizedBufferWithTreeAndSubtrees(llvm::StringRef text)
-> std::pair<Lex::TokenizedBuffer&, Parse::TreeAndSubtrees&> {
auto& tree_and_subtrees = GetTreeAndSubtrees(text);
return {token_storage_.front(), tree_and_subtrees};
}
auto CompileHelper::GetSourceBuffer(llvm::StringRef text) -> SourceBuffer& {
std::string filename = llvm::formatv("test{0}.carbon", ++file_index_);
CARBON_CHECK(
fs_.addFile(filename, /*ModificationTime=*/0,
llvm::MemoryBuffer::getMemBuffer(
text, filename, /*RequiresNullTerminator=*/false)));
source_storage_.push_front(
std::move(*SourceBuffer::MakeFromFile(fs_, filename, consumer_)));
return source_storage_.front();
}
} // namespace Carbon::Testing