Dana Jansens e9823df130 Update the test comment explaining the fix for #5481 (#5488) ...

The fix for #5481 changed but the comment explaining what needs to
happen (and now happens due to the #5481 PR) was not updated.

2025-05-15 17:00:09 +00:00

..

fuzzer_corpus

Change array syntax from [T; N] to array(T, N) (#4981)

2025-02-20 22:42:47 +00:00

testdata

Update the test comment explaining the fix for #5481 (#5488)

2025-05-15 17:00:09 +00:00

action.cpp

Drop Singleton from ErrorInst::SingletonInstId and similar (#5304)

2025-04-15 22:40:29 +00:00

action.h

Even more usage of TypeInstId (#5296)

2025-04-11 21:47:43 +00:00

BUILD

Remove VariantMatch; use CARBON_KIND_SWITCH for std::variants (#5437)

2025-05-12 18:56:52 +00:00

call.cpp

Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)

2025-04-28 19:06:24 +00:00

call.h

Use As and ImplicitAs interfaces for conversions. (#4209)

2024-09-05 23:39:58 +00:00

check_fuzzer.cpp

Switch Driver back to parameters for construction (#4849)

2025-01-27 23:48:44 +00:00

check_unit.cpp

Diagnose impls that are fully overlapped by a final impl (#5417)

2025-05-10 17:36:28 +00:00

check_unit.h

Diagnose impls that are fully overlapped by a final impl (#5417)

2025-05-10 17:36:28 +00:00

check.cpp

Cache multi-IR info, particularly include_in_dumps (#5408)

2025-05-02 22:53:46 +00:00

check.h

Cache multi-IR info, particularly include_in_dumps (#5408)

2025-05-02 22:53:46 +00:00

class.cpp

Rename singleton InstId constants to TypeInstId (#5323)

2025-04-17 18:57:20 +00:00

class.h

Remove all remaining uses of TypeIds as instruction operands. (#5280)

2025-04-10 20:53:42 +00:00

context.cpp

Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)

2025-04-28 19:06:24 +00:00

context.h

Defer building thunks until the end of the enclosing definition. (#5403)

2025-05-07 22:20:39 +00:00

control_flow.cpp

Detect control flow in entities nested inside functions (#5336)

2025-04-23 19:03:53 +00:00

control_flow.h

Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)

2025-04-28 19:06:24 +00:00

convert.cpp

Convert discarded calls in thunks. (#5452)

2025-05-09 16:35:28 +00:00

convert.h

Convert discarded calls in thunks. (#5452)

2025-05-09 16:35:28 +00:00

decl_introducer_state.h

Allow extend final impl as for impl declarations (#5345)

2025-04-23 15:20:18 +00:00

decl_name_stack.cpp

Defer building thunks until the end of the enclosing definition. (#5403)

2025-05-07 22:20:39 +00:00

decl_name_stack.h

Defer building thunks until the end of the enclosing definition. (#5403)

2025-05-07 22:20:39 +00:00

deduce.cpp

Remove needs_substitution logic (#5443)

2025-05-07 22:13:33 +00:00

deduce.h

Separate pattern types from expression types (#5360)

2025-04-28 16:54:37 +00:00

deferred_definition_scope.h

Defer building thunks until the end of the enclosing definition. (#5403)

2025-05-07 22:20:39 +00:00

deferred_definition_worklist.cpp

Remove VariantMatch; use CARBON_KIND_SWITCH for std::variants (#5437)

2025-05-12 18:56:52 +00:00

deferred_definition_worklist.h

Defer building thunks until the end of the enclosing definition. (#5403)

2025-05-07 22:20:39 +00:00

diagnostic_emitter.cpp

Move the logic in TryConvertClangDiagnosticLoc() to ConvertLocInFile() (#5391)

2025-05-02 08:08:11 +00:00

diagnostic_emitter.h

Move the logic in TryConvertClangDiagnosticLoc() to ConvertLocInFile() (#5391)

2025-05-02 08:08:11 +00:00

diagnostic_helpers.h

Poison impl lookup queries with concrete results (#5373)

2025-04-29 21:55:11 +00:00

dump.cpp

Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)

2025-04-28 19:06:24 +00:00

eval_inst.cpp

Poison impl lookup queries with concrete results (#5373)

2025-04-29 21:55:11 +00:00

eval_inst.h

Drop Singleton from ErrorInst::SingletonInstId and similar (#5304)

2025-04-15 22:40:29 +00:00

eval.cpp

Update tool versions beyond just bazel (#5446)

2025-05-08 16:24:28 +00:00

eval.h

Remove the SemIRLoc typedef (#5299)

2025-04-14 14:28:15 +00:00

facet_type.cpp

Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)

2025-04-28 19:06:24 +00:00

facet_type.h

Remove the SemIRLoc typedef (#5299)

2025-04-14 14:28:15 +00:00

full_pattern_stack.h

Clean up handling of Call params (#5061)

2025-03-04 21:01:59 +00:00

function.cpp

Generate thunks for functions in impls (#5390)

2025-05-01 22:17:55 +00:00

function.h

Defer building thunks until the end of the enclosing definition. (#5403)

2025-05-07 22:20:39 +00:00

generic_region_stack.cpp

Build generic eval blocks incrementally (#5313)

2025-05-01 20:24:15 +00:00

generic_region_stack.h

Build generic eval blocks incrementally (#5313)

2025-05-01 20:24:15 +00:00

generic.cpp

Build generic eval blocks incrementally (#5313)

2025-05-01 20:24:15 +00:00

generic.h

Build generic eval blocks incrementally (#5313)

2025-05-01 20:24:15 +00:00

global_init.cpp

[Refactor] Move call_params_id from EntityBase to FunctionFields. (#5146)

2025-03-18 23:49:24 +00:00

global_init.h

Split global init out from InstBlockStack. (#4101)

2024-07-03 17:49:47 +00:00

handle_alias.cpp

Stop pushing a fake generic for the duration of check. (#5326)

2025-04-17 21:58:37 +00:00

handle_array.cpp

Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)

2025-04-28 19:06:24 +00:00

handle_binding_pattern.cpp

Generate thunks for functions in impls (#5390)

2025-05-01 22:17:55 +00:00

handle_call_expr.cpp

Include the call arguments in the location of a call. (#4602)

2024-12-02 18:51:44 +00:00

handle_choice.cpp

Build generic eval blocks incrementally (#5313)

2025-05-01 20:24:15 +00:00

handle_class.cpp

Add build option --features=poison_value_stores. (#5438)

2025-05-08 21:07:04 +00:00

handle_codeblock.cpp

Detect control flow in entities nested inside functions (#5336)

2025-04-23 19:03:53 +00:00

handle_export.cpp

Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)

2025-04-28 19:06:24 +00:00

handle_expr_statement.cpp

Convert discarded calls in thunks. (#5452)

2025-05-09 16:35:28 +00:00

handle_file.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_function.cpp

Don't crash if a builtin fn is declared with positional parameters. (#5444)

2025-05-07 22:27:29 +00:00

handle_if_expr.cpp

Detect control flow in entities nested inside functions (#5336)

2025-04-23 19:03:53 +00:00

handle_if_statement.cpp

Refactor AddInst-family functions to their own file (#4941)

2025-02-14 19:44:36 +00:00

handle_impl.cpp

Don't reuse the reference into the ImplStore after doing deduce (#5456)

2025-05-09 20:35:18 +00:00

handle_import_and_package.cpp

Implement #4864: Core is a keyword (#4909)

2025-02-11 21:33:57 +00:00

handle_index.cpp

Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)

2025-04-28 19:06:24 +00:00

handle_interface.cpp

Build generic eval blocks incrementally (#5313)

2025-05-01 20:24:15 +00:00

handle_let_and_var.cpp

Generate thunks for functions in impls (#5390)

2025-05-01 22:17:55 +00:00

handle_literal.cpp

Rename singleton InstId constants to TypeInstId (#5323)

2025-04-17 18:57:20 +00:00

handle_loop_statement.cpp

Refactor AddInst-family functions to their own file (#4941)

2025-02-14 19:44:36 +00:00

handle_match.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_modifier.cpp

Allow extend final impl as for impl declarations (#5345)

2025-04-23 15:20:18 +00:00

handle_name.cpp

Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)

2025-04-28 19:06:24 +00:00

handle_named_constraint.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_namespace.cpp

Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)

2025-04-28 19:06:24 +00:00

handle_noop.cpp

Abort checking when encountering an invalid parse node (#4700)

2024-12-18 00:19:12 +00:00

handle_operator.cpp

Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)

2025-04-28 19:06:24 +00:00

handle_paren_expr.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_pattern_list.cpp

Generate thunks for functions in impls (#5390)

2025-05-01 22:17:55 +00:00

handle_return_statement.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_struct.cpp

Detect control flow in entities nested inside functions (#5336)

2025-04-23 19:03:53 +00:00

handle_tuple_literal.cpp

Remove all remaining uses of TypeIds as instruction operands. (#5280)

2025-04-10 20:53:42 +00:00

handle_where.cpp

Detect control flow in entities nested inside functions (#5336)

2025-04-23 19:03:53 +00:00

handle.h

Defer building thunks until the end of the enclosing definition. (#5403)

2025-05-07 22:20:39 +00:00

impl_lookup.cpp

Diagnose impls that are fully overlapped by a final impl (#5417)

2025-05-10 17:36:28 +00:00

impl_lookup.h

Diagnose impls that are fully overlapped by a final impl (#5417)

2025-05-10 17:36:28 +00:00

impl.cpp

Avoid witnesses in redecls when handling errors in handle_impl (#5409)

2025-05-02 19:49:06 +00:00

impl.h

Avoid witnesses in redecls when handling errors in handle_impl (#5409)

2025-05-02 19:49:06 +00:00

import_cpp.cpp

[Carbon/C++ interop] Add support for C++ type short (#5393)

2025-05-09 08:51:46 +00:00

import_cpp.h

Add support for importing a trivial global C++ function (#5033)

2025-03-03 10:38:19 +00:00

import_ref.cpp

Preserve the is_final bit when importing an impl declaration (#5461)

2025-05-12 18:10:36 +00:00

import_ref.h

Factor out GetCanonicalFileAndInstId for code sharing. (#5362)

2025-04-25 20:04:49 +00:00

import.cpp

Don't use GetCanonicalLocId when determining what instruction an instruction was imported from. (#5418)

2025-05-05 19:58:30 +00:00

import.h

Remove the SemIRLoc typedef (#5299)

2025-04-14 14:28:15 +00:00

inst_block_stack.cpp

Refactor InstBlockStore's API, AddDefaultValue -> AddPlaceholder (#5166)

2025-03-21 23:09:37 +00:00

inst_block_stack.h

Split SemIR's formatter class into a more typical h+cpp (#5372)

2025-04-29 18:00:07 +00:00

inst.cpp

Build generic eval blocks incrementally (#5313)

2025-05-01 20:24:15 +00:00

inst.h

Generate thunks for functions in impls (#5390)

2025-05-01 22:17:55 +00:00

interface.cpp

Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)

2025-04-28 19:06:24 +00:00

interface.h

Remove the SemIRLoc typedef (#5299)

2025-04-14 14:28:15 +00:00

keyword_modifier_set.h

Clean up KeywordModifierSet after #5345 (#5425)

2025-05-06 16:56:06 +00:00

lexical_lookup.h

Refactor value store code to use separate files. (#4477)

2024-11-04 04:00:17 +00:00

literal.cpp

Rename singleton InstId constants to TypeInstId (#5323)

2025-04-17 18:57:20 +00:00

literal.h

Factor out machinery for forming int type literals. (#4616)

2024-12-03 18:46:27 +00:00

member_access.cpp

Gracefully error in non-compound member lookup into a runtime facet value (#5485)

2025-05-15 16:25:53 +00:00

member_access.h

Build generic eval blocks incrementally (#5313)

2025-05-01 20:24:15 +00:00

merge.cpp

Don't require a thunk for parameter name differences. (#5404)

2025-05-02 03:01:00 +00:00

merge.h

Remove the SemIRLoc typedef (#5299)

2025-04-14 14:28:15 +00:00

modifiers.cpp

Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)

2025-04-28 19:06:24 +00:00

modifiers.h

Refactor modifier formatting to remove string passing. (#4418)

2024-10-17 22:47:40 +00:00

name_component.cpp

Fix parse support for 'fn F[];' (#5135)

2025-03-18 00:31:17 +00:00

name_component.h

Id::Invalid -> Id::None (#4834)

2025-01-22 23:15:00 +00:00

name_lookup.cpp

Build generic eval blocks incrementally (#5313)

2025-05-01 20:24:15 +00:00

name_lookup.h

Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)

2025-04-28 19:06:24 +00:00

node_id_traversal.cpp

Defer building thunks until the end of the enclosing definition. (#5403)

2025-05-07 22:20:39 +00:00

node_id_traversal.h

Change NodeIdTraversal.context_ from reference to pointer (#5210)

2025-03-28 16:24:17 +00:00

node_stack.cpp

Avoid redundantly specifying Id::Kind. (#4911)

2025-02-07 22:35:18 +00:00

node_stack.h

Separate fields from other var decls in parse (#5320)

2025-04-22 17:15:53 +00:00

operator.cpp

Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)

2025-04-28 19:06:24 +00:00

operator.h

Move diagnostic usings off Context (#5007)

2025-02-26 18:44:36 +00:00

param_and_arg_refs_stack.h

Consolidate post-check logic (#5003)

2025-02-25 02:07:43 +00:00

pattern_match.cpp

Generate thunks for functions in impls (#5390)

2025-05-01 22:17:55 +00:00

pattern_match.h

Invalid comment cleanup (#4836)

2025-01-23 02:21:48 +00:00

pattern.cpp

Restore disabled CHECK in pattern handling. (#5410)

2025-05-02 18:08:43 +00:00

pattern.h

Generate thunks for functions in impls (#5390)

2025-05-01 22:17:55 +00:00

pending_block.h

Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)

2025-04-28 19:06:24 +00:00

pointer_dereference.cpp

Generate thunks for functions in impls (#5390)

2025-05-01 22:17:55 +00:00

pointer_dereference.h

Generate thunks for functions in impls (#5390)

2025-05-01 22:17:55 +00:00

region_stack.h

Remove the SemIRLoc typedef (#5299)

2025-04-14 14:28:15 +00:00

return.cpp

Generate thunks for functions in impls (#5390)

2025-05-01 22:17:55 +00:00

return.h

Generate thunks for functions in impls (#5390)

2025-05-01 22:17:55 +00:00

scope_index.h

Move None to IdBase (#5030)

2025-03-01 08:00:17 +00:00

scope_stack.cpp

Defer building thunks until the end of the enclosing definition. (#5403)

2025-05-07 22:20:39 +00:00

scope_stack.h

Defer building thunks until the end of the enclosing definition. (#5403)

2025-05-07 22:20:39 +00:00

subst.cpp

Substitute into the type of BindSymbolicName or SymbolicBindingPattern (#5481)

2025-05-15 16:30:32 +00:00

subst.h

Build generic eval blocks incrementally (#5313)

2025-05-01 20:24:15 +00:00

thunk.cpp

Convert discarded calls in thunks. (#5452)

2025-05-09 16:35:28 +00:00

thunk.h

Defer building thunks until the end of the enclosing definition. (#5403)

2025-05-07 22:20:39 +00:00

type_completion.cpp

Separate pattern types from expression types (#5360)

2025-04-28 16:54:37 +00:00

type_completion.h

Remove the SemIRLoc typedef (#5299)

2025-04-14 14:28:15 +00:00

type_structure.cpp

Flatten TypeIterator::Step::Any to not use nested variants (#5453)

2025-05-12 19:27:20 +00:00

type_structure.h

Include concrete non-type values in the type structure and use for impl candidate selection (#5431)

2025-05-08 18:41:36 +00:00

type.cpp

Separate pattern types from expression types (#5360)

2025-04-28 16:54:37 +00:00

type.h

Separate pattern types from expression types (#5360)

2025-04-28 16:54:37 +00:00