mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-05 22:02:55 +01:00
Chandler CarruthandJon Ross-Perkins
13de9e9d06
Recent runs of `clang-tidy` for me started showing more errors, and this is a collection of changes to address them. First, I've systematically applied the disabling tag to all C++ rules under //explorer/... with `buildozer` so we don't spend time analyzing this code or reporting errors from it. Not sure this was strictly necessary, but it seemed like a nice consistency improvement. Next, I disabled a buggy check for missing `default` cases in `switch`es. It seems to get confused by the fancy conversions in our `enum_base.h`. We don't miss much with this as the Clang compiler warnings for `switch` catch most of our actual bugs. I also removed the local disabling of this now that it is turned off centrally. Lastly, I added error checking to two file descriptor manipulating calls in the `file_test` infrastructure. --------- Co-authored-by: Jon Ross-Perkins <jperkins@google.com>
132 lines
3.4 KiB
Python
132 lines
3.4 KiB
Python
# Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
# Exceptions. See /LICENSE for license information.
|
|
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
load("@rules_cc//cc:defs.bzl", "cc_binary", "cc_library")
|
|
load("//bazel/cc_toolchains:defs.bzl", "cc_env")
|
|
load("//bazel/sh_run:rules.bzl", "glob_sh_run")
|
|
load("//testing/file_test:rules.bzl", "file_test")
|
|
|
|
package(default_visibility = [
|
|
"//bazel/check_deps:__pkg__",
|
|
"//explorer:__subpackages__",
|
|
"//installers:__subpackages__",
|
|
])
|
|
|
|
filegroup(
|
|
name = "standard_libraries",
|
|
srcs = ["data/prelude.carbon"],
|
|
)
|
|
|
|
cc_library(
|
|
name = "main",
|
|
srcs = ["main.cpp"],
|
|
hdrs = ["main.h"],
|
|
# Running clang-tidy is slow, and explorer is currently feature frozen, so
|
|
# don't spend time linting it.
|
|
tags = ["no-clang-tidy"],
|
|
deps = [
|
|
"//common:error",
|
|
"//common:ostream",
|
|
"//explorer/base:trace_stream",
|
|
"//explorer/parse_and_execute",
|
|
"@llvm-project//llvm:Support",
|
|
],
|
|
)
|
|
|
|
cc_binary(
|
|
name = "explorer",
|
|
srcs = ["main_bin.cpp"],
|
|
env = cc_env(),
|
|
# Running clang-tidy is slow, and explorer is currently feature frozen, so
|
|
# don't spend time linting it.
|
|
tags = ["no-clang-tidy"],
|
|
deps = [
|
|
":main",
|
|
"//common:bazel_working_dir",
|
|
"@llvm-project//llvm:Support",
|
|
],
|
|
)
|
|
|
|
cc_binary(
|
|
name = "file_test",
|
|
testonly = 1,
|
|
srcs = ["file_test.cpp"],
|
|
# Running clang-tidy is slow, and explorer is currently feature frozen, so
|
|
# don't spend time linting it.
|
|
tags = ["no-clang-tidy"],
|
|
deps = [
|
|
":main",
|
|
"//common:check",
|
|
"//testing/base:test_raw_ostream",
|
|
"//testing/file_test:file_test_base",
|
|
"@com_google_absl//absl/flags:flag",
|
|
"@com_googlesource_code_re2//:re2",
|
|
],
|
|
)
|
|
|
|
file_test(
|
|
name = "file_test.notrace",
|
|
size = "small",
|
|
prebuilt_binary = ":file_test",
|
|
shard_count = 20,
|
|
tests = glob(["testdata/**/*.carbon"]),
|
|
)
|
|
|
|
file_test(
|
|
name = "file_test.trace",
|
|
size = "small",
|
|
args = ["--trace"],
|
|
prebuilt_binary = ":file_test",
|
|
shard_count = 30,
|
|
tests = glob(
|
|
["testdata/**/*.carbon"],
|
|
exclude = [
|
|
# `limits` tests check for various limit conditions (such as an
|
|
# infinite loop). The tests collectively don't test tracing
|
|
# because it creates substantial additional overhead.
|
|
"testdata/limits/**",
|
|
# `trace` tests do tracing by default.
|
|
"testdata/trace/**",
|
|
# Expensive tests to trace.
|
|
"testdata/assoc_const/rewrite_large_type.carbon",
|
|
"testdata/linked_list/typed_linked_list.carbon",
|
|
],
|
|
),
|
|
)
|
|
|
|
glob_sh_run(
|
|
args = ["$(location //explorer)"],
|
|
data = ["//explorer"],
|
|
file_exts = ["carbon"],
|
|
)
|
|
|
|
glob_sh_run(
|
|
args = [
|
|
"$(location //explorer)",
|
|
"--parser_debug",
|
|
"--trace_file=-",
|
|
],
|
|
data = ["//explorer"],
|
|
file_exts = ["carbon"],
|
|
run_ext = "verbose",
|
|
)
|
|
|
|
filegroup(
|
|
name = "carbon_files",
|
|
srcs = glob(["testdata/**/*.carbon"]),
|
|
# Files are used for validating fuzzer completeness.
|
|
visibility = ["//explorer/fuzzing:__pkg__"],
|
|
)
|
|
|
|
filegroup(
|
|
name = "treesitter_testdata",
|
|
srcs = glob(
|
|
["testdata/**/*.carbon"],
|
|
exclude = [
|
|
"testdata/**/fail_*",
|
|
],
|
|
),
|
|
visibility = ["//utils/treesitter:__pkg__"],
|
|
)
|