mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-01 14:45:53 +01:00
Jon Ross-Perkins
e58ce3e1bb
This refactors the diagnostic kind coverage check into something that also works for node kinds. Then, since this points out a few node kinds that aren't having their parse verified, I'm adding minor tests for those.
83 lines
2.7 KiB
C++
83 lines
2.7 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
#ifndef CARBON_TOOLCHAIN_TESTING_COVERAGE_HELPER_H_
|
|
#define CARBON_TOOLCHAIN_TESTING_COVERAGE_HELPER_H_
|
|
|
|
#include <gtest/gtest.h>
|
|
|
|
#include <fstream>
|
|
#include <string>
|
|
|
|
#include "common/set.h"
|
|
#include "llvm/ADT/StringExtras.h"
|
|
#include "re2/re2.h"
|
|
|
|
namespace Carbon::Testing {
|
|
|
|
// Looks for kinds that aren't covered by a file_test in the manifest path.
|
|
// Kinds are identified by the provided regular expression kind_pattern.
|
|
//
|
|
// should_be_covered should return false when a kind is either untestable or not
|
|
// yet tested.
|
|
template <typename KindT>
|
|
auto TestKindCoverage(const std::string& manifest_path,
|
|
llvm::StringLiteral kind_pattern,
|
|
llvm::ArrayRef<KindT> kinds,
|
|
llvm::ArrayRef<KindT> untested_kinds) {
|
|
std::ifstream manifest_in(manifest_path.c_str());
|
|
ASSERT_TRUE(manifest_in.good());
|
|
|
|
RE2 kind_re(kind_pattern.data());
|
|
ASSERT_TRUE(kind_re.ok()) << kind_re.error();
|
|
|
|
Set<std::string> covered_kinds;
|
|
|
|
std::string test_filename;
|
|
while (std::getline(manifest_in, test_filename)) {
|
|
std::ifstream test_in(test_filename);
|
|
ASSERT_TRUE(test_in.good());
|
|
|
|
std::string line;
|
|
while (std::getline(test_in, line)) {
|
|
std::string kind;
|
|
if (RE2::PartialMatch(line, kind_re, &kind)) {
|
|
covered_kinds.Insert(kind);
|
|
}
|
|
}
|
|
}
|
|
|
|
llvm::SmallVector<llvm::StringRef> missing_kinds;
|
|
for (auto kind : kinds) {
|
|
if (llvm::find(untested_kinds, kind) != untested_kinds.end()) {
|
|
EXPECT_FALSE(covered_kinds.Erase(kind.name()))
|
|
<< "Kind " << kind
|
|
<< " has coverage even though none was expected. If this has "
|
|
"changed, update the coverage test.";
|
|
continue;
|
|
}
|
|
if (!covered_kinds.Erase(kind.name())) {
|
|
missing_kinds.push_back(kind.name());
|
|
}
|
|
}
|
|
|
|
constexpr llvm::StringLiteral Bullet = "\n - ";
|
|
|
|
std::sort(missing_kinds.begin(), missing_kinds.end());
|
|
EXPECT_TRUE(missing_kinds.empty()) << "Some kinds have no tests:" << Bullet
|
|
<< llvm::join(missing_kinds, Bullet);
|
|
|
|
llvm::SmallVector<std::string> unexpected_matches;
|
|
covered_kinds.ForEach(
|
|
[&](const std::string& match) { unexpected_matches.push_back(match); });
|
|
std::sort(unexpected_matches.begin(), unexpected_matches.end());
|
|
EXPECT_TRUE(unexpected_matches.empty())
|
|
<< "Matched things that aren't in the kind list:" << Bullet
|
|
<< llvm::join(unexpected_matches, Bullet);
|
|
}
|
|
|
|
} // namespace Carbon::Testing
|
|
|
|
#endif // CARBON_TOOLCHAIN_TESTING_COVERAGE_HELPER_H_
|