mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-28 10:20:09 +01:00
Chandler Carruth
e71e6ca07f
This undoes a previous change to unify them, and I think at my advice. =[ Sorry about that, I think I was just wrong. Specifically, I think I had suggested that it would be more efficient to have a single shared hashtable of strings. The more I look at profiles of the toolchain, the less likely that seems. Specifically for identifiers and string literals it seems especially problematic. Using a single, joint hashtable is likely a good idea when all of the different querying code paths are equally likely, the strings follow the same distribution of sizes, and either there is no clustering of access to different sets of strings or none of the sets are meaningfully small enough to fit into a lower level of resident cache. I think essentially none of these predicates actually hold for identifiers vs. string literals: - Identifiers are *much* more hot - They have wildly different size distributions. - The access patterns are very clustered Sorry for the misleading advice on that one. While splitting them, I've worked to simplify the code a bit by building a way to have the `StringRef` holding canonical value stores not require specializations, and so we get a pretty large code cleanup in the process here.
46 lines
1.7 KiB
Plaintext
46 lines
1.7 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// ARGS: compile --phase=lex --dump-shared-values %s
|
|
//
|
|
// AUTOUPDATE
|
|
// TIP: To test this file alone, run:
|
|
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/driver/testdata/dump_shared_values.carbon
|
|
// TIP: To dump output, run:
|
|
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/driver/testdata/dump_shared_values.carbon
|
|
|
|
// The value 8 is significant because it can show as negative due to APInt.
|
|
var int1: i32 = 1;
|
|
var int2: i32 = 8;
|
|
var real1: f64 = 1.0;
|
|
var real2: f64 = 0.8e8;
|
|
var real3: f64 = 0.8e9;
|
|
var str1: String = "abc";
|
|
var str2: String = "ab'\"c";
|
|
|
|
// CHECK:STDOUT: ---
|
|
// CHECK:STDOUT: filename: dump_shared_values.carbon
|
|
// CHECK:STDOUT: shared_values:
|
|
// CHECK:STDOUT: ints:
|
|
// CHECK:STDOUT: int0: 32
|
|
// CHECK:STDOUT: int1: 1
|
|
// CHECK:STDOUT: int2: 8
|
|
// CHECK:STDOUT: int3: 64
|
|
// CHECK:STDOUT: reals:
|
|
// CHECK:STDOUT: real0: 10*10^-1
|
|
// CHECK:STDOUT: real1: 8*10^7
|
|
// CHECK:STDOUT: real2: 8*10^8
|
|
// CHECK:STDOUT: identifiers:
|
|
// CHECK:STDOUT: identifier0: int1
|
|
// CHECK:STDOUT: identifier1: int2
|
|
// CHECK:STDOUT: identifier2: real1
|
|
// CHECK:STDOUT: identifier3: real2
|
|
// CHECK:STDOUT: identifier4: real3
|
|
// CHECK:STDOUT: identifier5: str1
|
|
// CHECK:STDOUT: identifier6: str2
|
|
// CHECK:STDOUT: strings:
|
|
// CHECK:STDOUT: string0: abc
|
|
// CHECK:STDOUT: string1: ab'"c
|
|
// CHECK:STDOUT: ...
|