mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-27 22:02:33 +01:00
Chandler Carruth
8c64f0bfdd
Most of these are places where we failed to include a header file and simply never got an error about this. The fix is to include the header file. Most other cases are functions that should have been marked `static` but were not. Finding all of these was a main motivation for me enabling the warning despite how much work it is. One complicating factor was that we weren't including the `handle.h` for all the state-based handler functions. While this isn't a tiny amount of code, it is just declarations and doesn't add any extra dependencies. It also lets us have the checking for which functions need to be `static` and which don't. For the `parse` library I had to add the `handle.h` header as well, I tried to match the design of it in `check`. I have also had to work around a bug in the warning, but given the value it seems to be providing, that seems reasonable. I've filed the bug upstream: https://github.com/llvm/llvm-project/issues/94138 I also had to use some hacks to work around limitations of Bazel rules that wrap `cc_library` rules and don't expose `copts`. I filed a bug for `cc_proto_library` specifically: ~https://github.com/bazelbuild/bazel/issues/22610~ https://github.com/bazelbuild/bazel/issues/4446
52 lines
1.4 KiB
C++
52 lines
1.4 KiB
C++
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
// To convert a crashing input in text proto to Carbon source:
|
|
// `proto_to_carbon <file.textproto>`
|
|
|
|
#include <google/protobuf/text_format.h>
|
|
|
|
#include <fstream>
|
|
#include <iostream>
|
|
#include <sstream>
|
|
|
|
#include "common/bazel_working_dir.h"
|
|
#include "common/error.h"
|
|
#include "testing/fuzzing/proto_to_carbon.h"
|
|
|
|
namespace Carbon {
|
|
|
|
static auto Main(int argc, char** argv) -> ErrorOr<Success> {
|
|
Carbon::SetWorkingDirForBazel();
|
|
|
|
if (argc != 2) {
|
|
return Error("Syntax: proto_to_carbon <file.textproto>");
|
|
}
|
|
if (!std::filesystem::is_regular_file(argv[1])) {
|
|
return Error("Argument must be a file.");
|
|
}
|
|
|
|
// Read the input file.
|
|
std::ifstream proto_file(argv[1]);
|
|
std::stringstream buffer;
|
|
buffer << proto_file.rdbuf();
|
|
proto_file.close();
|
|
|
|
CARBON_ASSIGN_OR_RETURN(Fuzzing::Carbon proto,
|
|
Carbon::ParseCarbonTextProto(buffer.str()));
|
|
std::cout << Carbon::ProtoToCarbon(proto, /*maybe_add_main=*/true);
|
|
return Success();
|
|
}
|
|
|
|
} // namespace Carbon
|
|
|
|
auto main(int argc, char** argv) -> int {
|
|
auto err = Carbon::Main(argc, argv);
|
|
if (!err.ok()) {
|
|
std::cerr << err.error().message() << "\n";
|
|
return EXIT_FAILURE;
|
|
}
|
|
return EXIT_SUCCESS;
|
|
}
|