mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-28 19:14:54 +01:00
Jon Ross-Perkins
e5d49f5989
This switches to single list storage of SemanticsNode. The driving motivation behind this is to simplify cross-references within a given IR. Types of nodes will frequently refer to other blocks. This causes a significant increase in the number of cross-references, which can become difficult to manage (and reason about). By reducing to a single list of nodes, cross-references are only needed when crossing IR boundaries. Because cross-references now only have 2 things to track (IR and index), they can be a regular SemanticsNode and don't need further indirection. This wasn't motivating, but feels like it reinforces the simplification. Note this isn't being used to deduplicate nodes, at least right now. That could lead to difficult-to-update situations, but also most nodes are associated with the underlying ParseTree::Node in order to track sources for diagnostics; as a consequence, nodes representing equal text in different source locations wouldn't be the same node. There may be future opportunities here, discussed with @zygoloid, but no action is taken at present. We may eventually want to switch the storage of NodeBlocks to have `[start, end)` ranges instead of individual numbers, but I'm leaving that alone for now. As an aside, I noticed I was accidentally overloading the copy constructor on SemanticsIR. I've added some disambiguation on that, but am not deleting the copy constructor per style advice (even though the type should never be copied due to storage size). codespell tries to change `CrossReference -> cross-reference` so disabling it there.
33 lines
1.1 KiB
Plaintext
33 lines
1.1 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// AUTOUPDATE
|
|
// RUN: %{carbon-run-semantics}
|
|
// CHECK:STDOUT: cross_reference_irs.size == 1,
|
|
// CHECK:STDOUT: integer_literals = {
|
|
// CHECK:STDOUT: },
|
|
// CHECK:STDOUT: strings = {
|
|
// CHECK:STDOUT: str0 = "Foo";
|
|
// CHECK:STDOUT: },
|
|
// CHECK:STDOUT: nodes = {
|
|
// CHECK:STDOUT: node0 = CrossReference(ir0, block0): node0;
|
|
// CHECK:STDOUT: node1 = CrossReference(ir0, block1): node1;
|
|
// CHECK:STDOUT: node2 = CrossReference(ir0, block2): node0;
|
|
// CHECK:STDOUT: node3 = CrossReference(ir0, block3): node0;
|
|
// CHECK:STDOUT: node4 = FunctionDeclaration();
|
|
// CHECK:STDOUT: node5 = BindName(str0, node4);
|
|
// CHECK:STDOUT: node6 = FunctionDefinition(node4, block1);
|
|
// CHECK:STDOUT: },
|
|
// CHECK:STDOUT: node_blocks = {
|
|
// CHECK:STDOUT: block0 = {
|
|
// CHECK:STDOUT: node4;
|
|
// CHECK:STDOUT: node5;
|
|
// CHECK:STDOUT: node6;
|
|
// CHECK:STDOUT: },
|
|
// CHECK:STDOUT: block1 = {
|
|
// CHECK:STDOUT: },
|
|
// CHECK:STDOUT: }
|
|
|
|
fn Foo() {}
|