mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-22 17:32:38 +00:00
Some driver file tests are C++ files, such as toolchain/driver/testdata/fail_clang_no_args.cpp, but autoupdate_testdata.py ignored any file argument that wasn't a .carbon file. I tested this manually (since there's no automated test coverage for the script) by making a modification to that .cpp file's CHECK before and after this PR's change: Before: ``` [hi on] blaikie@blaikie-cloudtop2:~/dev/carbon$ ./toolchain/autoupdate_testdata.py toolchain/driver/testdata/fail_clang_no_args.cpp Args do not seem to be test files; for example, toolchain/driver/testdata/fail_clang_no_args.cpp ``` After: ``` [hi on] blaikie@blaikie-cloudtop2:~/dev/carbon$ ./toolchain/autoupdate_testdata.py toolchain/driver/testdata/fail_clang_no_args.cpp ... TEST: toolchain/driver/testdata/fail_clang_no_args.cpp ! Ran 1 tests in 25 ms wall time, 1 ms across threads ``` This improves the situation for those two .cpp files, and paves the way for more top-level C++ test coverage for reverse interop functionality.