Dana Jansens e1f30669af Remove TODO in impl lookup for discarding unused witnesses (#7032) ...

In #6972 we stopped finishing instructions added just for EvalOrAddInst,
which prevents adding the instruction to the containing generic eval
block.

2026-04-07 18:11:08 +00:00

..

cpp

Support round-tripping entities through C++ and Carbon. (#7022)

2026-04-07 08:10:21 +00:00

fuzzer_corpus

Change array syntax from [T; N] to array(T, N) (#4981)

2025-02-20 22:42:47 +00:00

testdata

Refactor WhereExpr evaluation into smaller helper functions (#7006)

2026-04-07 13:52:56 +00:00

action.cpp

Rename type's GetInstId to GetTypeInstId, reflecting returned type (#6708)

2026-02-09 22:00:21 +00:00

action.h

Even more usage of TypeInstId (#5296)

2025-04-11 21:47:43 +00:00

BUILD

Fix name mangling for Carbon functions called from C++ (#6984)

2026-03-27 22:52:11 +00:00

call.cpp

Support const eval when calling a C++ thunk (#6947)

2026-04-01 21:34:41 +00:00

call.h

Model ref tags as insts instead of annotations (#6541)

2026-01-05 22:24:47 +00:00

check_fuzzer.cpp

Switch Driver back to parameters for construction (#4849)

2025-01-27 23:48:44 +00:00

check_unit.cpp

Introduce typed-inst accessors for ConstantValueStore (#6980)

2026-03-27 21:41:04 +00:00

check_unit.h

Use lines instead of statements for readability-function-size clang-tidy (#6594)

2026-01-14 19:32:03 +00:00

check.cpp

Drop "diagnostic" from some filenames in the "diagnostics" folder (#6686)

2026-02-04 17:24:55 +00:00

check.h

Drop "diagnostic" from some filenames in the "diagnostics" folder (#6686)

2026-02-04 17:24:55 +00:00

class.cpp

Rename type's GetInstId to GetTypeInstId, reflecting returned type (#6708)

2026-02-09 22:00:21 +00:00

class.h

Vtable support for generics (#5793)

2025-07-11 22:29:10 +00:00

context.cpp

Implement unused pattern bindings, continued (#6518)

2026-02-19 23:33:36 +00:00

context.h

Fix name mangling for Carbon functions called from C++ (#6984)

2026-03-27 22:52:11 +00:00

control_flow.cpp

Introduce typed-inst accessors for ConstantValueStore (#6980)

2026-03-27 21:41:04 +00:00

control_flow.h

Handle destruction for return statements (#5785)

2025-07-10 16:32:39 +00:00

convert.cpp

Improve InPlaceInitializing conversion. (#7021)

2026-04-03 21:28:54 +00:00

convert.h

Support calling functions with explicit template arguments. (#6814)

2026-03-03 00:26:33 +00:00

core_identifier.cpp

Add well-known identifier caching (#6486)

2025-12-11 21:41:47 +00:00

core_identifier.def

Make C++ types impl Core.Default. (#6962)

2026-03-25 21:07:24 +00:00

core_identifier.h

Add well-known identifier caching (#6486)

2025-12-11 21:41:47 +00:00

custom_witness.cpp

Improve CanDestroyType to handle remaining cases (#6943)

2026-04-02 22:54:58 +00:00

custom_witness.h

Make C++ enum types impl Core.Copy. (#7013)

2026-04-02 19:23:42 +00:00

decl_introducer_state.h

Add basic support for eval fn and musteval fn. (#6694)

2026-02-11 02:08:16 +00:00

decl_name_stack.cpp

Introduce Diagnostics::ContextScope and remove diagnoser callbacks in type completion (#6761)

2026-02-25 15:15:29 +00:00

decl_name_stack.h

Implement unused pattern bindings, continued (#6518)

2026-02-19 23:33:36 +00:00

deduce.cpp

Remove ValueParamPattern case from deduction (#6869)

2026-03-10 21:15:38 +00:00

deduce.h

Add an interface-with-self generic to each interface and same for constraints (#6667)

2026-02-19 16:24:07 +00:00

deferred_definition_worklist.cpp

Track pending thunks on the deferred definition worklist. (#5609)

2025-06-10 22:09:31 +00:00

deferred_definition_worklist.h

Track pending thunks on the deferred definition worklist. (#5609)

2025-06-10 22:09:31 +00:00

diagnostic_emitter.cpp

Rename type's GetInstId to GetTypeInstId, reflecting returned type (#6708)

2026-02-09 22:00:21 +00:00

diagnostic_emitter.h

Drop "diagnostic" from some filenames in the "diagnostics" folder (#6686)

2026-02-04 17:24:55 +00:00

diagnostic_helpers.h

Introduce Diagnostics::ContextScope and remove diagnoser callbacks in type completion (#6761)

2026-02-25 15:15:29 +00:00

dump.cpp

Add lldb dumping for RequireImplsId and RequireImplsBlockId (#6524)

2025-12-19 18:48:20 +00:00

eval_inst.cpp

Support const eval when calling a C++ thunk (#6947)

2026-04-01 21:34:41 +00:00

eval_inst.h

Fix typos in eval_inst.h (#6775)

2026-02-23 16:48:23 +00:00

eval.cpp

Refactor WhereExpr evaluation into smaller helper functions (#7006)

2026-04-07 13:52:56 +00:00

eval.h

Have Specific track whether regions contain errors (#6982)

2026-03-27 19:36:52 +00:00

facet_type.cpp

Implement unused pattern bindings, continued (#6518)

2026-02-19 23:33:36 +00:00

facet_type.h

Add an interface-with-self generic to each interface and same for constraints (#6667)

2026-02-19 16:24:07 +00:00

full_pattern_stack.h

Add support for ->? return forms (#6849)

2026-03-09 22:30:16 +00:00

function.cpp

Make C++ enum types impl Core.Copy. (#7013)

2026-04-02 19:23:42 +00:00

function.h

Make Destroy.Op functions able to have a body (#6729)

2026-03-02 17:57:31 +00:00

generic_region_stack.cpp

Add an interface-with-self generic to each interface and same for constraints (#6667)

2026-02-19 16:24:07 +00:00

generic_region_stack.h

Add an interface-with-self generic to each interface and same for constraints (#6667)

2026-02-19 16:24:07 +00:00

generic.cpp

Have Specific track whether regions contain errors (#6982)

2026-03-27 19:36:52 +00:00

generic.h

Add an interface-with-self generic to each interface and same for constraints (#6667)

2026-02-19 16:24:07 +00:00

global_init.cpp

Remove InitForm::index (#6817)

2026-03-06 17:35:48 +00:00

global_init.h

Split global init out from InstBlockStack. (#4101)

2024-07-03 17:49:47 +00:00

handle_alias.cpp

Add a type_literal instruction to represent syntactic type literals. (#6781)

2026-02-26 20:10:50 +00:00

handle_array.cpp

Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)

2025-04-28 19:06:24 +00:00

handle_binding_pattern.cpp

Support for parsing expression patterns (#6977)

2026-03-28 00:06:06 +00:00

handle_call_expr.cpp

Parse ref as operator (#6539)

2025-12-30 19:18:34 +00:00

handle_choice.cpp

Implement unused pattern bindings, continued (#6518)

2026-02-19 23:33:36 +00:00

handle_class.cpp

Introduce Diagnostics::ContextScope and remove diagnoser callbacks in type completion (#6761)

2026-02-25 15:15:29 +00:00

handle_codeblock.cpp

Implement unused pattern bindings, continued (#6518)

2026-02-19 23:33:36 +00:00

handle_export.cpp

Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)

2025-04-28 19:06:24 +00:00

handle_expr_statement.cpp

Convert discarded calls in thunks. (#5452)

2025-05-09 16:35:28 +00:00

handle_file.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_form_literal.cpp

Remove InitForm::index (#6817)

2026-03-06 17:35:48 +00:00

handle_function.cpp

Reverse nesting structure of parameter patterns (#6930)

2026-03-23 20:38:20 +00:00

handle_if_expr.cpp

Rename type's GetInstId to GetTypeInstId, reflecting returned type (#6708)

2026-02-09 22:00:21 +00:00

handle_if_statement.cpp

Refactor AddInst-family functions to their own file (#4941)

2025-02-14 19:44:36 +00:00

handle_impl.cpp

Add support for ->? return forms (#6849)

2026-03-09 22:30:16 +00:00

handle_import_and_package.cpp

Add support for inline Cpp declarations. (#6994)

2026-03-31 22:27:43 +00:00

handle_index.cpp

Rename type's GetInstId to GetTypeInstId, reflecting returned type (#6708)

2026-02-09 22:00:21 +00:00

handle_inline_decl.cpp

Add support for inline Cpp declarations. (#6994)

2026-03-31 22:27:43 +00:00

handle_interface.cpp

Use earlier require decls inside a named constraint to provide witnesses for Self (#6915)

2026-03-26 15:26:56 +00:00

handle_lambda.cpp

[parse] Implement initial parsing support for Lambda expressions (#6583)

2026-01-14 16:58:15 +00:00

handle_let_and_var.cpp

Support for parsing expression patterns (#6977)

2026-03-28 00:06:06 +00:00

handle_literal.cpp

Fix iN/uN type literal width check for multiples of 8 (#6949)

2026-03-22 02:03:48 +00:00

handle_loop_statement.cpp

Support for parsing expression patterns (#6977)

2026-03-28 00:06:06 +00:00

handle_match.cpp

Refactor match parse nodes. (#6870)

2026-03-10 20:04:28 +00:00

handle_modifier.cpp

Add basic support for eval fn and musteval fn. (#6694)

2026-02-11 02:08:16 +00:00

handle_name.cpp

Add support for ->? return forms (#6849)

2026-03-09 22:30:16 +00:00

handle_named_constraint.cpp

Use earlier require decls inside a named constraint to provide witnesses for Self (#6915)

2026-03-26 15:26:56 +00:00

handle_namespace.cpp

Construct LocId from InstId directly (explicitly) instead of doing lookups when possible (#5355)

2025-04-28 19:06:24 +00:00

handle_noop.cpp

Abort checking when encountering an invalid parse node (#4700)

2024-12-18 00:19:12 +00:00

handle_observe.cpp

Implement parsing observe declarations (#6674)

2026-02-26 19:21:19 +00:00

handle_operator.cpp

Rename type's GetInstId to GetTypeInstId, reflecting returned type (#6708)

2026-02-09 22:00:21 +00:00

handle_paren_expr.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_pattern_list.cpp

Support for parsing expression patterns (#6977)

2026-03-28 00:06:06 +00:00

handle_require.cpp

Add storage for <type> impls <facettype> in the FacetTypeInfo (#7005)

2026-04-03 00:19:57 +00:00

handle_return_statement.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_struct.cpp

Implement unused pattern bindings, continued (#6518)

2026-02-19 23:33:36 +00:00

handle_tuple_literal.cpp

Rename type's GetInstId to GetTypeInstId, reflecting returned type (#6708)

2026-02-09 22:00:21 +00:00

handle_where.cpp

Diagnose where clause without a designator (#6995)

2026-04-01 04:16:35 +00:00

handle.h

Track pending thunks on the deferred definition worklist. (#5609)

2025-06-10 22:09:31 +00:00

impl_lookup.cpp

Remove TODO in impl lookup for discarding unused witnesses (#7032)

2026-04-07 18:11:08 +00:00

impl_lookup.h

Use earlier require decls inside a named constraint to provide witnesses for Self (#6915)

2026-03-26 15:26:56 +00:00

impl_validation.cpp

Check the orphan rule for impls (#6488)

2025-12-11 19:44:39 +00:00

impl_validation.h

Add diagnostics for invalid impl declarations (#5420)

2025-05-22 18:58:47 +00:00

impl.cpp

Introduce typed-inst accessors for ConstantValueStore (#6980)

2026-03-27 21:41:04 +00:00

impl.h

Add an interface-with-self generic to each interface and same for constraints (#6667)

2026-02-19 16:24:07 +00:00

import_ref.cpp

Fix crash lowering call to generic function with concrete type in signature (#7009)

2026-04-03 21:24:00 +00:00

import_ref.h

When performing an impl lookup, only import impls for related interfaces. (#6040)

2025-09-10 21:40:27 +00:00

import.cpp

Add MakeVerifiedLocIdAndInst for runtime validation (#6942)

2026-03-24 20:56:44 +00:00

import.h

Add MakeVerifiedLocIdAndInst for runtime validation (#6942)

2026-03-24 20:56:44 +00:00

inst_block_stack.cpp

Refactor InstBlockStore's API, AddDefaultValue -> AddPlaceholder (#5166)

2025-03-21 23:09:37 +00:00

inst_block_stack.h

Add require decls to Interface and NamedConstraint (#6321)

2025-11-11 16:36:15 +00:00

inst.cpp

Don't finish the non-canonical instruction created in EvalOrAddInst (#6972)

2026-03-27 19:29:34 +00:00

inst.h

Don't finish the non-canonical instruction created in EvalOrAddInst (#6972)

2026-03-27 19:29:34 +00:00

interface.cpp

Implement unused pattern bindings, continued (#6518)

2026-02-19 23:33:36 +00:00

interface.h

Add an interface-with-self generic to each interface and same for constraints (#6667)

2026-02-19 16:24:07 +00:00

keyword_modifier_set.cpp

Some more edits to EnumBase and EnumMaskBase (#6054)

2025-09-12 22:59:37 +00:00

keyword_modifier_set.h

Add basic support for eval fn and musteval fn. (#6694)

2026-02-11 02:08:16 +00:00

lexical_lookup.h

Implement unused pattern bindings, continued (#6518)

2026-02-19 23:33:36 +00:00

literal.cpp

Add a type_literal instruction to represent syntactic type literals. (#6781)

2026-02-26 20:10:50 +00:00

literal.h

Add a type_literal instruction to represent syntactic type literals. (#6781)

2026-02-26 20:10:50 +00:00

member_access.cpp

Introduce typed-inst accessors for ConstantValueStore (#6980)

2026-03-27 21:41:04 +00:00

member_access.h

Introduce Diagnostics::ContextScope and remove diagnoser callbacks in type completion (#6761)

2026-02-25 15:15:29 +00:00

merge.cpp

Reverse nesting structure of parameter patterns (#6930)

2026-03-23 20:38:20 +00:00

merge.h

Reverse nesting structure of parameter patterns (#6930)

2026-03-23 20:38:20 +00:00

modifiers.cpp

Add an interface-with-self generic to each interface and same for constraints (#6667)

2026-02-19 16:24:07 +00:00

modifiers.h

Add an interface-with-self generic to each interface and same for constraints (#6667)

2026-02-19 16:24:07 +00:00

name_component.cpp

Remove InitForm::index (#6817)

2026-03-06 17:35:48 +00:00

name_component.h

Remove InitForm::index (#6817)

2026-03-06 17:35:48 +00:00

name_lookup.cpp

Introduce typed-inst accessors for ConstantValueStore (#6980)

2026-03-27 21:41:04 +00:00

name_lookup.h

Extended name lookup replaces inner Self (#6632)

2026-01-21 17:48:18 +00:00

name_ref.cpp

Fix lowering of thunks in generic impls (#5631)

2025-06-10 20:54:58 +00:00

name_ref.h

Fix lowering of thunks in generic impls (#5631)

2025-06-10 20:54:58 +00:00

name_scope.cpp

Diagnose explicit Self in extend in the parse node handler (Refactor Impl construction 1/7) (#6465)

2025-12-09 20:38:50 +00:00

name_scope.h

Diagnose explicit Self in extend in the parse node handler (Refactor Impl construction 1/7) (#6465)

2025-12-09 20:38:50 +00:00

node_id_traversal.cpp

Track pending thunks on the deferred definition worklist. (#5609)

2025-06-10 22:09:31 +00:00

node_id_traversal.h

Track pending thunks on the deferred definition worklist. (#5609)

2025-06-10 22:09:31 +00:00

node_stack.cpp

Use lines instead of statements for readability-function-size clang-tidy (#6594)

2026-01-14 19:32:03 +00:00

node_stack.h

Add support for inline Cpp declarations. (#6994)

2026-03-31 22:27:43 +00:00

operator.cpp

Introduce Diagnostics::ContextScope and remove diagnoser callbacks in type completion (#6761)

2026-02-25 15:15:29 +00:00

operator.h

Introduce Diagnostics::ContextScope and remove diagnoser callbacks in type completion (#6761)

2026-02-25 15:15:29 +00:00

param_and_arg_refs_stack.h

Consolidate post-check logic (#5003)

2025-02-25 02:07:43 +00:00

pattern_match.cpp

Model thunk call as a pattern match (#6988)

2026-03-31 21:50:06 +00:00

pattern_match.h

Model thunk call as a pattern match (#6988)

2026-03-31 21:50:06 +00:00

pattern.cpp

Support for parsing expression patterns (#6977)

2026-03-28 00:06:06 +00:00

pattern.h

Support for parsing expression patterns (#6977)

2026-03-28 00:06:06 +00:00

pending_block.h

Fix handling of compatible conversions in initialization. (#6797)

2026-02-26 18:25:06 +00:00

pointer_dereference.cpp

Generate thunks for functions in impls (#5390)

2025-05-01 22:17:55 +00:00

pointer_dereference.h

Generate thunks for functions in impls (#5390)

2025-05-01 22:17:55 +00:00

region_stack.h

Support for parsing expression patterns (#6977)

2026-03-28 00:06:06 +00:00

require_impls_stack.cpp

Use earlier require decls inside a named constraint to provide witnesses for Self (#6915)

2026-03-26 15:26:56 +00:00

require_impls_stack.h

Use earlier require decls inside a named constraint to provide witnesses for Self (#6915)

2026-03-26 15:26:56 +00:00

return.cpp

Reverse nesting structure of parameter patterns (#6930)

2026-03-23 20:38:20 +00:00

return.h

Implement unused pattern bindings, continued (#6518)

2026-02-19 23:33:36 +00:00

scope_index.h

Use inline constexpr where appropriate. (#6374)

2025-11-14 13:50:56 +00:00

scope_stack.cpp

Implement unused pattern bindings, continued (#6518)

2026-02-19 23:33:36 +00:00

scope_stack.h

Implement unused pattern bindings, continued (#6518)

2026-02-19 23:33:36 +00:00

subst.cpp

Add storage for <type> impls <facettype> in the FacetTypeInfo (#7005)

2026-04-03 00:19:57 +00:00

subst.h

Finish renaming BindName and related insts. (#6281)

2025-10-28 17:17:38 +00:00

thunk.cpp

Model thunk call as a pattern match (#6988)

2026-03-31 21:50:06 +00:00

thunk.h

Implement support for copying C++ classes. (#6434)

2025-12-02 02:52:23 +00:00

type_completion.cpp

Add storage for <type> impls <facettype> in the FacetTypeInfo (#7005)

2026-04-03 00:19:57 +00:00

type_completion.h

Use earlier require decls inside a named constraint to provide witnesses for Self (#6915)

2026-03-26 15:26:56 +00:00

type_structure.cpp

Return SymbolicBindingType separately in TypeIterator (#6193)

2025-10-10 12:37:37 +00:00

type_structure.h

Prevent accidental copies of TypeStructure (#6519)

2025-12-18 17:26:28 +00:00

type.cpp

Check support for form literals and :? bindings (#6747)

2026-02-26 23:01:24 +00:00

type.h

Check support for form literals and :? bindings (#6747)

2026-02-26 23:01:24 +00:00

unused.cpp

Clean up some of the TODOs in unused.carbon (#6794)

2026-02-26 18:57:15 +00:00

unused.h

Implement unused pattern bindings, continued (#6518)

2026-02-19 23:33:36 +00:00