Files
carbon-lang/toolchain/check/testdata/impl/redeclaration.carbon
T
Chandler CarruthandRichard Smith 94d2c1c6d4 Make proposal filenames use 6 digits and include the title (#7245)
We've talked about adding the title to the filename several times over
the years and it seems really valuable. This requires us to compute a
"slug" for the title spelling that can be part of the filename.

Beyond that, we crossed 7000 recently, and so it seems likely that we
will need to add digits sooner rather than later here, so this goes
ahead and moves us to 6 digits so we don't have to adjust again for a
reasonable length of time.

To implement this and ensure we can sustain it going forward this adds a
tool to our pre-commit that validates (and corrects if needed) the
filename.

In order to update everything and keep links working, there are a _lot_
of changes, but the most interesting for direct review are in
`proposals/scripts`.

Assisted-by: Antigravity with Gemini

---------

Co-authored-by: Richard Smith <richard@metafoo.co.uk>
2026-05-29 00:55:04 +00:00

325 lines
11 KiB
Plaintext

// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
// INCLUDE-FILE: toolchain/testing/testdata/min_prelude/none.carbon
//
// AUTOUPDATE
// TIP: To test this file alone, run:
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/impl/redeclaration.carbon
// TIP: To dump output, run:
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/impl/redeclaration.carbon
// --- redeclaration_no_class.carbon
library "[[@TEST_NAME]]";
interface Z {}
impl {} as Z;
impl {} as Z {}
// --- redeclaration_in_class.carbon
library "[[@TEST_NAME]]";
interface Z {}
// `impl as Z` is normalized to `impl Self as Z` so they are treated as
// syntactically the same.
class C {
impl as Z;
impl as Z;
impl Self as Z {}
}
class D {
impl Self as Z;
impl Self as Z;
impl as Z {}
}
// --- fail_todo_redeclaration_reenter_class.carbon
library "[[@TEST_NAME]]";
interface Z {}
class C;
class C {
impl as Z;
}
// TODO: This should typecheck (see #5366).
// CHECK:STDERR: fail_todo_redeclaration_reenter_class.carbon:[[@LINE+12]]:9: error: expected expression [ExpectedExpr]
// CHECK:STDERR: impl C.(as Z) {}
// CHECK:STDERR: ^~
// CHECK:STDERR:
// CHECK:STDERR: fail_todo_redeclaration_reenter_class.carbon:[[@LINE+8]]:9: error: semantics TODO: `handle invalid parse trees in `check`` [SemanticsTodo]
// CHECK:STDERR: impl C.(as Z) {}
// CHECK:STDERR: ^~
// CHECK:STDERR:
// CHECK:STDERR: fail_todo_redeclaration_reenter_class.carbon:[[@LINE+4]]:15: error: expected `as` in `impl` declaration [ImplExpectedAs]
// CHECK:STDERR: impl C.(as Z) {}
// CHECK:STDERR: ^
// CHECK:STDERR:
impl C.(as Z) {}
// --- fail_todo_redeclaration_reenter_class_explicit_self.carbon
library "[[@TEST_NAME]]";
interface Z {}
class C;
class C {
impl Self as Z;
}
// TODO: This should typecheck (see #5366).
// CHECK:STDERR: fail_todo_redeclaration_reenter_class_explicit_self.carbon:[[@LINE+12]]:9: error: name `Self` not found [NameNotFound]
// CHECK:STDERR: impl C.(Self as Z) {}
// CHECK:STDERR: ^~~~
// CHECK:STDERR:
// CHECK:STDERR: fail_todo_redeclaration_reenter_class_explicit_self.carbon:[[@LINE+8]]:20: error: expected `as` in `impl` declaration [ImplExpectedAs]
// CHECK:STDERR: impl C.(Self as Z) {}
// CHECK:STDERR: ^
// CHECK:STDERR:
// CHECK:STDERR: fail_todo_redeclaration_reenter_class_explicit_self.carbon:[[@LINE+4]]:1: error: semantics TODO: `handle invalid parse trees in `check`` [SemanticsTodo]
// CHECK:STDERR: impl C.(Self as Z) {}
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~
// CHECK:STDERR:
impl C.(Self as Z) {}
// --- fail_todo_redeclaration_reenter_class_mixed_self_outside.carbon
library "[[@TEST_NAME]]";
interface Z {}
class C {
impl as Z;
}
// TODO: This should typecheck (see #5366).
// CHECK:STDERR: fail_todo_redeclaration_reenter_class_mixed_self_outside.carbon:[[@LINE+12]]:9: error: name `Self` not found [NameNotFound]
// CHECK:STDERR: impl C.(Self as Z) {}
// CHECK:STDERR: ^~~~
// CHECK:STDERR:
// CHECK:STDERR: fail_todo_redeclaration_reenter_class_mixed_self_outside.carbon:[[@LINE+8]]:20: error: expected `as` in `impl` declaration [ImplExpectedAs]
// CHECK:STDERR: impl C.(Self as Z) {}
// CHECK:STDERR: ^
// CHECK:STDERR:
// CHECK:STDERR: fail_todo_redeclaration_reenter_class_mixed_self_outside.carbon:[[@LINE+4]]:1: error: semantics TODO: `handle invalid parse trees in `check`` [SemanticsTodo]
// CHECK:STDERR: impl C.(Self as Z) {}
// CHECK:STDERR: ^~~~~~~~~~~~~~~~~~~~~
// CHECK:STDERR:
impl C.(Self as Z) {}
// --- fail_todo_redeclaration_reenter_class_mixed_self_inside.carbon
library "[[@TEST_NAME]]";
interface Z {}
class C {
impl Self as Z;
}
// TODO: This should typecheck (see #5366).
// CHECK:STDERR: fail_todo_redeclaration_reenter_class_mixed_self_inside.carbon:[[@LINE+12]]:9: error: expected expression [ExpectedExpr]
// CHECK:STDERR: impl C.(as Z) {}
// CHECK:STDERR: ^~
// CHECK:STDERR:
// CHECK:STDERR: fail_todo_redeclaration_reenter_class_mixed_self_inside.carbon:[[@LINE+8]]:9: error: semantics TODO: `handle invalid parse trees in `check`` [SemanticsTodo]
// CHECK:STDERR: impl C.(as Z) {}
// CHECK:STDERR: ^~
// CHECK:STDERR:
// CHECK:STDERR: fail_todo_redeclaration_reenter_class_mixed_self_inside.carbon:[[@LINE+4]]:15: error: expected `as` in `impl` declaration [ImplExpectedAs]
// CHECK:STDERR: impl C.(as Z) {}
// CHECK:STDERR: ^
// CHECK:STDERR:
impl C.(as Z) {}
// --- fail_redeclaration_inside_class_is_separate_impl.carbon
library "[[@TEST_NAME]]";
interface Z {}
class C;
impl C as Z;
class C {
// CHECK:STDERR: fail_redeclaration_inside_class_is_separate_impl.carbon:[[@LINE+3]]:3: error: found non-final `impl` with the same type structure as another non-final `impl` [ImplNonFinalSameTypeStructure]
// CHECK:STDERR: impl C as Z {}
// CHECK:STDERR: ^~~~~~~~~~~~~
impl C as Z {}
}
// CHECK:STDERR: fail_redeclaration_inside_class_is_separate_impl.carbon:[[@LINE+4]]:1: note: other `impl` here [ImplNonFinalSameTypeStructureNote]
// CHECK:STDERR: impl C as Z {}
// CHECK:STDERR: ^~~~~~~~~~~~~
// CHECK:STDERR:
impl C as Z {}
// --- fail_redeclaration_outside_class_is_separate_impl.carbon
library "[[@TEST_NAME]]";
interface Z {}
class C {
impl C as Z {}
}
// CHECK:STDERR: fail_redeclaration_outside_class_is_separate_impl.carbon:[[@LINE+7]]:1: error: found non-final `impl` with the same type structure as another non-final `impl` [ImplNonFinalSameTypeStructure]
// CHECK:STDERR: impl C as Z {}
// CHECK:STDERR: ^~~~~~~~~~~~~
// CHECK:STDERR: fail_redeclaration_outside_class_is_separate_impl.carbon:[[@LINE-6]]:3: note: other `impl` here [ImplNonFinalSameTypeStructureNote]
// CHECK:STDERR: impl C as Z {}
// CHECK:STDERR: ^~~~~~~~~~~~~
// CHECK:STDERR:
impl C as Z {}
// --- fail_todo_redeclaration_in_block_scope_is_separate_impl.carbon
library "[[@TEST_NAME]]";
interface Z {}
fn F() {
// CHECK:STDERR: fail_todo_redeclaration_in_block_scope_is_separate_impl.carbon:[[@LINE+4]]:22: error: semantics TODO: `HandleAutoTypeLiteral` [SemanticsTodo]
// CHECK:STDERR: musteval fn G() -> auto {
// CHECK:STDERR: ^~~~
// CHECK:STDERR:
musteval fn G() -> auto {
class C {}
impl C as Z {}
return C;
}
// TODO: This is not a redeclaration, since it's in a different scope.
// TODO: found non-final `impl` with the same type structure as another non-final `impl`.
impl G() as Z {}
}
// --- redecl_of_imported_impl.carbon
library "[[@TEST_NAME]]";
interface Z {}
class C {}
impl C as Z {}
// --- fail_redecl_of_imported_impl.impl.carbon
impl library "[[@TEST_NAME]]";
// CHECK:STDERR: fail_redecl_of_imported_impl.impl.carbon:[[@LINE+4]]:1: error: redeclaration of imported impl [RedeclImportedImpl]
// CHECK:STDERR: impl C as Z {}
// CHECK:STDERR: ^~~~~~~~~~~~~
// CHECK:STDERR:
impl C as Z {}
// --- decl_of_imported_impl_in_new_scope.carbon
library "[[@TEST_NAME]]";
interface Z {}
class C {}
impl C as Z {}
// --- fail_decl_of_imported_impl_in_new_scope.impl.carbon
impl library "[[@TEST_NAME]]";
class D {
// This is not treated as a redeclaration since it is in a different scope.
// But that means it overlaps fully with the impl from the api file, which is
// a separate error.
// CHECK:STDERR: fail_decl_of_imported_impl_in_new_scope.impl.carbon:[[@LINE+8]]:3: error: found non-final `impl` with the same type structure as another non-final `impl` [ImplNonFinalSameTypeStructure]
// CHECK:STDERR: impl C as Z {}
// CHECK:STDERR: ^~~~~~~~~~~~~
// CHECK:STDERR: fail_decl_of_imported_impl_in_new_scope.impl.carbon:[[@LINE-10]]:1: in import [InImport]
// CHECK:STDERR: decl_of_imported_impl_in_new_scope.carbon:5:1: note: other `impl` here [ImplNonFinalSameTypeStructureNote]
// CHECK:STDERR: impl C as Z {}
// CHECK:STDERR: ^~~~~~~~~~~~~
// CHECK:STDERR:
impl C as Z {}
}
// --- fail_redecl_in_fn_scope.carbon
library "[[@TEST_NAME]]";
interface Z {}
fn F() {
class C {}
impl C as Z;
// CHECK:STDERR: fail_redecl_in_fn_scope.carbon:[[@LINE+8]]:3: error: impl redeclation not in a declarative scope; redeclaration is allowed only in a class or namespace [ImplDeclInInvalidScope]
// CHECK:STDERR: impl C as Z {}
// CHECK:STDERR: ^~~~~~~~~~~~~
// CHECK:STDERR:
// CHECK:STDERR: fail_redecl_in_fn_scope.carbon:[[@LINE-5]]:3: error: impl declared but not defined [ImplMissingDefinition]
// CHECK:STDERR: impl C as Z;
// CHECK:STDERR: ^~~~~~~~~~~~
// CHECK:STDERR:
impl C as Z {}
}
// --- fail_redecl_in_different_fn_scope.carbon
library "[[@TEST_NAME]]";
interface Z {}
class C {}
fn F() {
impl C as Z;
}
fn G() {
// CHECK:STDERR: fail_redecl_in_different_fn_scope.carbon:[[@LINE+8]]:3: error: impl redeclation not in a declarative scope; redeclaration is allowed only in a class or namespace [ImplDeclInInvalidScope]
// CHECK:STDERR: impl C as Z {}
// CHECK:STDERR: ^~~~~~~~~~~~~
// CHECK:STDERR:
// CHECK:STDERR: fail_redecl_in_different_fn_scope.carbon:[[@LINE-8]]:3: error: impl declared but not defined [ImplMissingDefinition]
// CHECK:STDERR: impl C as Z;
// CHECK:STDERR: ^~~~~~~~~~~~
// CHECK:STDERR:
impl C as Z {}
}
// --- fail_redecl_in_block_scope.carbon
library "[[@TEST_NAME]]";
interface Z {}
fn F() {
if (true) {
class C {}
impl C as Z;
// CHECK:STDERR: fail_redecl_in_block_scope.carbon:[[@LINE+8]]:5: error: impl redeclation not in a declarative scope; redeclaration is allowed only in a class or namespace [ImplDeclInInvalidScope]
// CHECK:STDERR: impl C as Z {}
// CHECK:STDERR: ^~~~~~~~~~~~~
// CHECK:STDERR:
// CHECK:STDERR: fail_redecl_in_block_scope.carbon:[[@LINE-5]]:5: error: impl declared but not defined [ImplMissingDefinition]
// CHECK:STDERR: impl C as Z;
// CHECK:STDERR: ^~~~~~~~~~~~
// CHECK:STDERR:
impl C as Z {}
}
}
// --- fail_redecl_in_different_block_scope.carbon
library "[[@TEST_NAME]]";
interface Z {}
class C {}
fn F() {
if (true) {
impl C as Z;
}
if (true) {
// CHECK:STDERR: fail_redecl_in_different_block_scope.carbon:[[@LINE+8]]:5: error: impl redeclation not in a declarative scope; redeclaration is allowed only in a class or namespace [ImplDeclInInvalidScope]
// CHECK:STDERR: impl C as Z {}
// CHECK:STDERR: ^~~~~~~~~~~~~
// CHECK:STDERR:
// CHECK:STDERR: fail_redecl_in_different_block_scope.carbon:[[@LINE-7]]:5: error: impl declared but not defined [ImplMissingDefinition]
// CHECK:STDERR: impl C as Z;
// CHECK:STDERR: ^~~~~~~~~~~~
// CHECK:STDERR:
impl C as Z {}
}
}