Richard Smith e1c8c1f855 Use specific_constant when referring to name in enclosing generic (#7936) ...

When unqualified lookup finds a name from an enclosing generic, create a
`specific_constant` if it's a constant, or a `specific_inst` otherwise,
to refer to that name from the inner generic. This allows consumers of
generic instructions to always use a specific of the current scope's
generic when accessing the constant value or type of a dependent
instruction.

Fixes crashes in dominance and in `GetExprCategory` caused by using
specifics for the wrong generic.

Assisted-by: Gemini via Antigravity

2026-10-15 02:00:24 +00:00

..

custom_witness

Canonicalize generated functions for Core witnesses (#7729)

2026-09-15 16:02:13 +00:00

lookup

Use specific_constant when referring to name in enclosing generic (#7936)

2026-10-15 02:00:24 +00:00

access.carbon

Fix accessing protected members from templates derived classes (#7780)

2026-09-18 19:12:05 +00:00

assoc_const_self.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

basic.carbon

Make SemIR::TypeType be an empty FacetType instruction (#7813)

2026-09-22 15:04:40 +00:00

compound.carbon

Use specific_constant when referring to name in enclosing generic (#7936)

2026-10-15 02:00:24 +00:00

declaration.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

empty.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

error_recovery.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

eval_musteval.carbon

Move self to the explicit () parameter list (proposal #7016) (#7272)

2026-06-10 15:30:43 +00:00

extend_final.carbon

Replace :! binding syntax with phase keywords and contextual defaults (#7479)

2026-07-11 01:22:44 +00:00

extend_impl_generic.carbon

Use specific_constant when referring to name in enclosing generic (#7936)

2026-10-15 02:00:24 +00:00

extend_impl.carbon

Make SemIR::TypeType be an empty FacetType instruction (#7813)

2026-09-22 15:04:40 +00:00

fail_alias.carbon

Make SemIR::TypeType be an empty FacetType instruction (#7813)

2026-09-22 15:04:40 +00:00

fail_call_invalid.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

fail_extend_impl_forall.carbon

Use specific_constant when referring to name in enclosing generic (#7936)

2026-10-15 02:00:24 +00:00

fail_extend_impl_scope.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

fail_extend_impl_type_as.carbon

Rename GenericClassType to ParameterizedClassType (#7953)

2026-10-11 23:09:12 +00:00

fail_extend_non_interface.carbon

Rename GenericClassType to ParameterizedClassType (#7953)

2026-10-11 23:09:12 +00:00

fail_extend_partially_defined_interface.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

fail_extend_undefined_interface.carbon

Make SemIR::TypeType be an empty FacetType instruction (#7813)

2026-09-22 15:04:40 +00:00

fail_impl_as_scope.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

fail_impl_bad_assoc_const.carbon

Make SemIR::TypeType be an empty FacetType instruction (#7813)

2026-09-22 15:04:40 +00:00

fail_impl_bad_assoc_fn.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

fail_impl_bad_interface.carbon

Rename GenericClassType to ParameterizedClassType (#7953)

2026-10-11 23:09:12 +00:00

fail_impl_bad_type.carbon

Make SemIR::TypeType be an empty FacetType instruction (#7813)

2026-09-22 15:04:40 +00:00

fail_redefinition.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

fail_self_type_mismatch.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

forward_decls.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

generic_redeclaration.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

impl_as_named_constraint.carbon

Handle ImplSelfWitness appearing in the RHS of a rewrite constraint in impl decl (#7943)

2026-10-14 17:54:41 +00:00

impl_as.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

impl_assoc_const_with_prelude.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

impl_assoc_const.carbon

Make SemIR::TypeType be an empty FacetType instruction (#7813)

2026-09-22 15:04:40 +00:00

impl_assoc_fn_as_alias.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

impl_forall.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

impl_inside_interface.carbon

Add interface modifiers (#7625)

2026-08-17 20:49:23 +00:00

impl_self_as.carbon

Replace :! binding syntax with phase keywords and contextual defaults (#7479)

2026-07-11 01:22:44 +00:00

impl_thunk_min_prelude.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

impl_thunk.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

impl_where_redecl.carbon

Replace :! binding syntax with phase keywords and contextual defaults (#7479)

2026-07-11 01:22:44 +00:00

import_builtin_call.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

import_canonical_witnesses.carbon

Replace :! binding syntax with phase keywords and contextual defaults (#7479)

2026-07-11 01:22:44 +00:00

import_compound.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

import_extend_impl.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

import_generic.carbon

Use specific_constant when referring to name in enclosing generic (#7936)

2026-10-15 02:00:24 +00:00

import_impl_with_no_interface.carbon

Move self to the explicit () parameter list (proposal #7016) (#7272)

2026-06-10 15:30:43 +00:00

import_interface_assoc_const.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

import_self_specific.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

import_self.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

import_thunk.carbon

Use specific_constant when referring to name in enclosing generic (#7936)

2026-10-15 02:00:24 +00:00

import_use_generic.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

incomplete.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

interface_args.carbon

Use specific_constant when referring to name in enclosing generic (#7936)

2026-10-15 02:00:24 +00:00

multiple_extend.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

name_lookup_in_impl_definition.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

name_poisoning.carbon

Replace :! binding syntax with phase keywords and contextual defaults (#7479)

2026-07-11 01:22:44 +00:00

no_definition_in_impl_file.carbon

Make SemIR::TypeType be an empty FacetType instruction (#7813)

2026-09-22 15:04:40 +00:00

orphan.carbon

Anchor the orphan rule on the first owning declaration (#7573)

2026-07-27 14:49:06 +00:00

period_self.carbon

Handle ImplSelfWitness appearing in the RHS of a rewrite constraint in impl decl (#7943)

2026-10-14 17:54:41 +00:00

redeclaration.carbon

Add support for -> auto deduced return types. (#7931)

2026-10-15 00:30:09 +00:00

reenter_scopes.carbon

Do not treat impls in different scopes as redeclarations (#7161)

2026-05-04 19:11:51 +00:00

require_satisified_in_interface.carbon

Add a Core.Array class type, and make array refer to it. (#7892)

2026-10-06 17:23:49 +00:00

require_satisified_in_named_constraint.carbon

Verify non-extend require constraints are satisfied at impl as definition (#7937)

2026-10-14 16:44:37 +00:00

rewrites.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

self_in_class.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

self_in_signature.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

todo_impl_with_unrelated_fn.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

use_assoc_entity.carbon

Defer evaluation of witnesses substituted while identifying a facet type (#7930)

2026-10-14 14:12:56 +00:00

using_invalid_interface.carbon

Replace :! binding syntax with phase keywords and contextual defaults (#7479)

2026-07-11 01:22:44 +00:00