Jon Ross-PerkinsandRichard Smith bed5fdcbbe Fix indirect import handling for functions. (#4258) ...

The particular test this focused on is indirect_two_file in
toolchain/check/testdata/function/definition/no_prelude/extern_library.carbon.

This removes `parent_scope_id_for_new_inst` because I think it's
returning unhelpful results. The use was at the root of incorrect
results for the indirect import chain. `name_id_for_new_inst` is
actually wrapping a union, so it's more important.

The merging of `is_extern` and `first_owning_decl_id` in
`handle_function.cpp` feels like it's less correct with the changes
that've been made to `extern`. This ripples in tests, because the error
recovery shifts.

---------

Co-authored-by: Richard Smith <richard@metafoo.co.uk>

2024-08-27 20:26:23 +00:00

..

fuzzer_corpus

Update some additional package rules where structure changed in #3963. (#3966)

2024-05-21 20:33:20 +00:00

testdata

Fix indirect import handling for functions. (#4258)

2024-08-27 20:26:23 +00:00

BUILD

Initial rough support for deducing generic arguments in a call to a generic function. (#4184)

2024-08-02 22:44:51 +00:00

call.cpp

Initial rough support for deducing generic arguments in a call to a generic function. (#4184)

2024-08-02 22:44:51 +00:00

call.h

Overloaded operator support. (#3796)

2024-03-19 19:47:29 +00:00

check_fuzzer.cpp

Teach fuzzers to initialize their installs from runfiles. (#4030)

2024-06-05 17:04:17 +00:00

check.cpp

Add filename and line number to function debug info metadata (#4243)

2024-08-23 00:05:26 +00:00

check.h

Add filename and line number to function debug info metadata (#4243)

2024-08-23 00:05:26 +00:00

context.cpp

Add fields for extern to EntityWithParamsBase (#4206)

2024-08-12 19:50:15 +00:00

context.h

Address the LocIdAndInst::ReusingLoc TODO (#4211)

2024-08-13 18:52:24 +00:00

convert.cpp

Address the LocIdAndInst::ReusingLoc TODO (#4211)

2024-08-13 18:52:24 +00:00

convert.h

Rename "generic instance" to "specific" throughout the toolchain. (#4165)

2024-07-25 16:42:01 +00:00

decl_introducer_state.h

Implement 'extern library' support for functions. (#4220)

2024-08-19 22:12:21 +00:00

decl_name_stack.cpp

Rename "generic instance" to "specific" throughout the toolchain. (#4165)

2024-07-25 16:42:01 +00:00

decl_name_stack.h

Fix indirect import handling for functions. (#4258)

2024-08-27 20:26:23 +00:00

deduce.cpp

Initial rough support for deducing generic arguments in a call to a generic function. (#4184)

2024-08-02 22:44:51 +00:00

deduce.h

Initial rough support for deducing generic arguments in a call to a generic function. (#4184)

2024-08-02 22:44:51 +00:00

diagnostic_helpers.h

location -> loc abbreviation (#3826)

2024-03-28 18:15:18 +00:00

eval.cpp

Distinguish between whether an entity has its own parameter lists and whether it is generic. (#4191)

2024-08-06 15:50:27 +00:00

eval.h

Rename "generic instance" to "specific" throughout the toolchain. (#4165)

2024-07-25 16:42:01 +00:00

function.cpp

Add fields for extern to EntityWithParamsBase (#4206)

2024-08-12 19:50:15 +00:00

function.h

Basic support for implementing and using a parameterized interface. (#4203)

2024-08-09 01:05:03 +00:00

generic_region_stack.cpp

Create an array stack type for a shared use-case (#4100)

2024-07-03 16:58:47 +00:00

generic_region_stack.h

Create an array stack type for a shared use-case (#4100)

2024-07-03 16:58:47 +00:00

generic.cpp

Error on non-constant parameters to a type. (#4215)

2024-08-13 18:35:10 +00:00

generic.h

Error on non-constant parameters to a type. (#4215)

2024-08-13 18:35:10 +00:00

global_init.cpp

Lower global variables (#4228)

2024-08-19 22:43:07 +00:00

global_init.h

Split global init out from InstBlockStack. (#4101)

2024-07-03 17:49:47 +00:00

handle_alias.cpp

Fix indirect import handling for functions. (#4258)

2024-08-27 20:26:23 +00:00

handle_array.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_binding_pattern.cpp

Rename BindNameInfo to EntityName (#4090)

2024-07-19 22:43:50 +00:00

handle_call_expr.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_choice.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_class.cpp

Fix indirect import handling for functions. (#4258)

2024-08-27 20:26:23 +00:00

handle_codeblock.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_export.cpp

Rename BindNameInfo to EntityName (#4090)

2024-07-19 22:43:50 +00:00

handle_expr_statement.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_file.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_function.cpp

Fix indirect import handling for functions. (#4258)

2024-08-27 20:26:23 +00:00

handle_if_expr.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_if_statement.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_impl.cpp

Separate subtree size information from parse nodes. (#4174)

2024-07-31 19:39:45 +00:00

handle_import_and_package.cpp

Implement 'extern library' support for functions. (#4220)

2024-08-19 22:12:21 +00:00

handle_index.cpp

change tuple index (#4218)

2024-08-15 16:06:02 +00:00

handle_interface.cpp

Implement 'extern library' support for functions. (#4220)

2024-08-19 22:12:21 +00:00

handle_let_and_var.cpp

Rename BindNameInfo to EntityName (#4090)

2024-07-19 22:43:50 +00:00

handle_literal.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_loop_statement.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_match.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_modifier.cpp

Implement 'extern library' support for functions. (#4220)

2024-08-19 22:12:21 +00:00

handle_name.cpp

change tuple index (#4218)

2024-08-15 16:06:02 +00:00

handle_named_constraint.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_namespace.cpp

Fix indirect import handling for functions. (#4258)

2024-08-27 20:26:23 +00:00

handle_noop.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_operator.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_paren_expr.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_pattern_list.cpp

Implement syntactic merge checks for parameters. (#4149)

2024-07-23 20:32:24 +00:00

handle_return_statement.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle_struct.cpp

Implement 'extern library' support for functions. (#4220)

2024-08-19 22:12:21 +00:00

handle_tuple_literal.cpp

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

handle.h

Rename check handlers to HandleParseNode overloads. (#4121)

2024-07-12 22:38:06 +00:00

impl.cpp

Add fields for extern to EntityWithParamsBase (#4206)

2024-08-12 19:50:15 +00:00

impl.h

Initial scaffolding for building a witness table for an impl. (#3743)

2024-03-07 23:10:14 +00:00

import_ref.cpp

Remove excess use of auto on initializers (auto x = Y(z) -> Y x(z)) (#4239)

2024-08-22 20:29:35 +00:00

import_ref.h

Rename BindNameInfo to EntityName (#4090)

2024-07-19 22:43:50 +00:00

import.cpp

Move common entity fields to a 'base' struct. (#4161)

2024-07-24 23:26:00 +00:00

import.h

Improve namespace handling in imports. (#4153)

2024-07-24 19:56:17 +00:00

inst_block_stack.cpp

Use verbose formatting of instructions on crash messages. (#4125)

2024-07-17 22:05:19 +00:00

inst_block_stack.h

Use verbose formatting of instructions on crash messages. (#4125)

2024-07-17 22:05:19 +00:00

interface.cpp

Address the LocIdAndInst::ReusingLoc TODO (#4211)

2024-08-13 18:52:24 +00:00

interface.h

Add an associated entity instruction and corresponding type for interface elements. (#3730)

2024-02-28 01:56:27 +00:00

keyword_modifier_set.h

Add namespace-scoped private keyword support. (#4026)

2024-06-06 00:19:56 +00:00

lexical_lookup.h

Use separate value stores for identifiers and string literals (#4106)

2024-07-03 15:54:04 +00:00

member_access.cpp

change tuple index (#4218)

2024-08-15 16:06:02 +00:00

member_access.h

change tuple index (#4218)

2024-08-15 16:06:02 +00:00

merge.cpp

Fix indirect import handling for functions. (#4258)

2024-08-27 20:26:23 +00:00

merge.h

Fix indirect import handling for functions. (#4258)

2024-08-27 20:26:23 +00:00

modifiers.cpp

Implement 'extern library' support for functions. (#4220)

2024-08-19 22:12:21 +00:00

modifiers.h

Implement 'extern library' support for functions. (#4220)

2024-08-19 22:12:21 +00:00

name_component.cpp

Implement syntactic merge checks for parameters. (#4149)

2024-07-23 20:32:24 +00:00

name_component.h

Implement syntactic merge checks for parameters. (#4149)

2024-07-23 20:32:24 +00:00

node_stack.cpp

Use verbose formatting of instructions on crash messages. (#4125)

2024-07-17 22:05:19 +00:00

node_stack.h

Implement 'extern library' support for functions. (#4220)

2024-08-19 22:12:21 +00:00

operator.cpp

Rename "generic instance" to "specific" throughout the toolchain. (#4165)

2024-07-25 16:42:01 +00:00

operator.h

Overloaded operator support. (#3796)

2024-03-19 19:47:29 +00:00

param_and_arg_refs_stack.h

Use verbose formatting of instructions on crash messages. (#4125)

2024-07-17 22:05:19 +00:00

pending_block.h

Address the LocIdAndInst::ReusingLoc TODO (#4211)

2024-08-13 18:52:24 +00:00

pointer_dereference.cpp

Add -Wmissing-prototypes and fix issues it finds. (#4019)

2024-06-04 20:04:45 +00:00

pointer_dereference.h

Handle arrow operator (#3768)

2024-03-18 17:40:00 +00:00

return.cpp

Add fields for extern to EntityWithParamsBase (#4206)

2024-08-12 19:50:15 +00:00

return.h

Rename parse_node -> node_id (#3760)

2024-03-09 00:21:29 +00:00

scope_index.h

Add import support for remaining decl types. (#3651)

2024-01-25 18:19:22 +00:00

scope_stack.cpp

Rename "generic instance" to "specific" throughout the toolchain. (#4165)

2024-07-25 16:42:01 +00:00

scope_stack.h

Rename "generic instance" to "specific" throughout the toolchain. (#4165)

2024-07-25 16:42:01 +00:00

sem_ir_diagnostic_converter.cpp

Add filename and line number to function debug info metadata (#4243)

2024-08-23 00:05:26 +00:00

sem_ir_diagnostic_converter.h

Add filename and line number to function debug info metadata (#4243)

2024-08-23 00:05:26 +00:00

subst.cpp

Remove excess use of auto on initializers (auto x = Y(z) -> Y x(z)) (#4239)

2024-08-22 20:29:35 +00:00

subst.h

Basic support for implementing and using a parameterized interface. (#4203)

2024-08-09 01:05:03 +00:00