mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-05 22:02:55 +01:00
Jon Ross-Perkins
ccf51cef23
This updates to bazel 8.0.0, also updating bazel mod deps and tools to make that function. The release is a couple weeks old, and we haven't updated in a while, and it's a major release. Note it includes some incompatible flag flips that this is trying to update with respect to. I'll try generally enabling incompatible support separately. The most visible bazel behavior change here will be the change from `~` to `+` in repo path names. (If you're curious, https://github.com/bazelbuild/bazel/issues/23127 indicates this fixes a Windows performance issue) Note that this is building on top of both the action env update in #4728 (which got me started down this path) and the proto removal in #4731 (which would add significant work to this update). Only the commit starting at "Work towards bazel 8.0.0" is specifically part of this PR.
97 lines
3.2 KiB
Python
97 lines
3.2 KiB
Python
#!/usr/bin/env python3
|
|
|
|
"""Check that non-test C++ rules only depend on Carbon and LLVM.
|
|
|
|
Carbon works to ensure its user-visible libraries and binaries only depend on
|
|
their code and LLVM. Among other benefits, this provides a single, simple
|
|
license used for the whole project.
|
|
|
|
However, we frequently use third-party projects and libraries where useful in
|
|
our test code. Here, we verify that the dependencies of non-test C++ rules only
|
|
include Carbon and LLVM code.
|
|
"""
|
|
|
|
__copyright__ = """
|
|
Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
Exceptions. See /LICENSE for license information.
|
|
SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
"""
|
|
|
|
import os
|
|
import sys
|
|
from pathlib import Path
|
|
|
|
runfiles = Path(os.environ["TEST_SRCDIR"])
|
|
deps_path = runfiles / "_main" / "bazel" / "check_deps" / "non_test_cc_deps.txt"
|
|
try:
|
|
with deps_path.open() as deps_file:
|
|
deps = deps_file.read().splitlines()
|
|
except FileNotFoundError:
|
|
sys.exit("ERROR: unable to find deps file: %s" % deps_path)
|
|
|
|
# This errors out on dependencies that aren't recognized, and continues on
|
|
# allowed dependencies.
|
|
for dep in deps:
|
|
print("Checking dependency: " + dep)
|
|
repo, _, rule = dep.partition("//")
|
|
|
|
if repo == "@@+llvm_project+llvm-project":
|
|
package, _, rule = rule.partition(":")
|
|
|
|
# Other packages in the LLVM project shouldn't be accidentally used
|
|
# in Carbon. We can expand the above list if use cases emerge.
|
|
if package not in (
|
|
"llvm",
|
|
"lld",
|
|
"clang",
|
|
"clang-tools-extra/clangd",
|
|
"libunwind",
|
|
):
|
|
sys.exit(
|
|
"ERROR: unexpected dependency into the LLVM project: %s" % dep
|
|
)
|
|
|
|
# Check for accidentally using the copy of GoogleTest in LLVM.
|
|
if rule in ("gmock", "gtest", "gtest_main"):
|
|
sys.exit(
|
|
"ERROR: dependency on LLVM's GoogleTest from non-test code: %s"
|
|
% dep
|
|
)
|
|
|
|
# The rest of LLVM, LLD, and Clang themselves are safe to depend on.
|
|
continue
|
|
|
|
# Carbon code is always allowed.
|
|
if repo == "" and not rule.startswith("third_party"):
|
|
continue
|
|
|
|
# An empty stub library added by rules_cc:
|
|
# https://github.com/bazelbuild/rules_cc/blob/main/BUILD
|
|
if repo == "@@rules_cc+" and rule == ":link_extra_lib":
|
|
continue
|
|
|
|
# An utility library provided by Bazel that is under a compatible license.
|
|
if repo == "@@bazel_tools" and rule == "tools/cpp/runfiles:runfiles":
|
|
continue
|
|
|
|
# These are stubs wrapping system libraries for LLVM. They aren't
|
|
# distributed and so should be fine.
|
|
if repo in (
|
|
"@@zlib+",
|
|
"@@zstd+",
|
|
):
|
|
continue
|
|
|
|
# This should never be reached from non-test code, but these targets do
|
|
# exist. Specially diagnose them to try to provide a more helpful
|
|
# message.
|
|
if repo in (
|
|
"@google_benchmark",
|
|
"@abseil-cpp",
|
|
"@googletest",
|
|
):
|
|
sys.exit("ERROR: dependency only allowed in test code: %s" % dep)
|
|
|
|
# Conservatively fail if a dependency isn't explicitly allowed above.
|
|
sys.exit(f"ERROR: unknown dependency on {repo}: {dep}")
|