Files
carbon-lang/toolchain/testing/BUILD
T
Dana Jansens 9a6c74f0cd Introduce FindIfOrNull() FindIfOrNone() and Contains() (#5322)
`FindIfOrNull` returns a pointer to the element in the range if it's
found, and nullptr otherwise. `FindIfOrNone` returns a copy of the
element in the range if it's found, and `T::None` (for a range of
elements of type `T`) otherwise. `Contains` returns a bool indicating
whether the element in the range is found.

These functions replace `llvm::find()` and `llvm::find_if()` when you
want a single answer back instead of an iterator. This avoids the need
to check against `end()`, allowing the return condition to be tested as
a standard bool.

We replace uses of `find()` and `find_if()` that did not require an
iterator with these new helpers.

Note that the return type of `FindIfOrNull` is a pointer since we can
not write `optional<T&>`, which must be tested for null. If the null
check is omitted, UB occurs and the resulting code may end up with an
incorrect pointer (https://crbug.com/40153300) into the range (or
elsewhere), rather than a null dereference. And this would be very
confusing to debug. Hopefully debug builds and sanitizers keep this from
being an issue we sink a bunch of time into debugging.
2025-04-18 14:17:48 +00:00

102 lines
2.5 KiB
Python

# Part of the Carbon Language project, under the Apache License v2.0 with LLVM
# Exceptions. See /LICENSE for license information.
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
load("//bazel/cc_rules:defs.bzl", "cc_library", "cc_test")
load("//testing/file_test:rules.bzl", "file_test")
package(default_visibility = ["//visibility:public"])
filegroup(
name = "all_testdata",
srcs = [
"//toolchain/check:testdata",
"//toolchain/codegen:testdata",
"//toolchain/diagnostics:testdata",
"//toolchain/driver:testdata",
"//toolchain/format:testdata",
"//toolchain/language_server:testdata",
"//toolchain/lex:testdata",
"//toolchain/lower:testdata",
"//toolchain/parse:testdata",
],
)
filegroup(
name = "minimal_preludes",
data = [
"//toolchain/testing/min_prelude",
],
)
cc_library(
name = "compile_helper",
testonly = 1,
srcs = ["compile_helper.cpp"],
hdrs = ["compile_helper.h"],
deps = [
"//toolchain/diagnostics:diagnostic_emitter",
"//toolchain/lex",
"//toolchain/parse",
"//toolchain/parse:tree",
"//toolchain/source:source_buffer",
"@llvm-project//llvm:Support",
],
)
cc_library(
name = "coverage_helper",
testonly = 1,
hdrs = ["coverage_helper.h"],
deps = [
"//common:find",
"//common:set",
"@googletest//:gtest",
"@llvm-project//llvm:Support",
"@re2",
],
)
file_test(
name = "file_test",
size = "small",
timeout = "moderate", # Taking >60 seconds in GitHub actions
srcs = ["file_test.cpp"],
data = [":minimal_preludes"],
tests = [":all_testdata"],
deps = [
"//common:all_llvm_targets",
"//common:error",
"//testing/file_test:file_test_base",
"//toolchain/driver",
"@abseil-cpp//absl/strings",
"@llvm-project//llvm:Support",
],
)
cc_library(
name = "yaml_test_helpers",
testonly = 1,
srcs = ["yaml_test_helpers.cpp"],
hdrs = ["yaml_test_helpers.h"],
deps = [
"//common:error",
"//common:ostream",
"//common:raw_string_ostream",
"@abseil-cpp//absl/strings",
"@googletest//:gtest",
"@llvm-project//llvm:Support",
],
)
cc_test(
name = "yaml_test_helpers_test",
size = "small",
srcs = ["yaml_test_helpers_test.cpp"],
deps = [
":yaml_test_helpers",
"//testing/base:gtest_main",
"@googletest//:gtest",
],
)