Files
carbon-lang/toolchain/autoupdate_testdata.py
T
David Blaikie e2603996e5 Allow autoupdate_testdata.py to update C++ file tests (#8124)
Some driver file tests are C++ files, such as
toolchain/driver/testdata/fail_clang_no_args.cpp, but
autoupdate_testdata.py ignored any file argument that wasn't a .carbon
file.

I tested this manually (since there's no automated test coverage for the
script)
by making a modification to that .cpp file's CHECK before and after this
PR's
change:

Before:
```
[hi on] blaikie@blaikie-cloudtop2:~/dev/carbon$ ./toolchain/autoupdate_testdata.py toolchain/driver/testdata/fail_clang_no_args.cpp
Args do not seem to be test files; for example, toolchain/driver/testdata/fail_clang_no_args.cpp
```
After:
```
[hi on] blaikie@blaikie-cloudtop2:~/dev/carbon$ ./toolchain/autoupdate_testdata.py toolchain/driver/testdata/fail_clang_no_args.cpp
...
TEST: toolchain/driver/testdata/fail_clang_no_args.cpp !
Ran 1 tests in 25 ms wall time, 1 ms across threads
```

This improves the situation for those two .cpp files, and paves the way
for more
top-level C++ test coverage for reverse interop functionality.
2026-11-11 22:57:11 +00:00

142 lines
4.3 KiB
Python
Executable File

#!/usr/bin/env -S uv run --script
# /// script
# requires-python = ">=3.12"
# ///
"""Autoupdates testdata in toolchain."""
__copyright__ = """
Part of the Carbon Language project, under the Apache License v2.0 with LLVM
Exceptions. See /LICENSE for license information.
SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
"""
import argparse
import re
import shlex
import subprocess
import sys
from pathlib import Path
from typing import Any
def _detect_build_mode(bazel: str, printv: Any) -> str:
build_mode = "fastbuild"
workspace = subprocess.check_output(
[
bazel,
"info",
"workspace",
"--ui_event_filters=stdout",
],
encoding="utf-8",
).strip()
bazel_bin_path = Path(workspace).joinpath("bazel-bin")
if bazel_bin_path.exists():
link = str(bazel_bin_path.readlink())
m = re.search(r"-(\w+)/bin$", link)
if m:
build_mode = m[1]
printv(f"Detected --compilation_mode: {build_mode}")
else:
exit(f"Build mode not found in `bazel-bin` symlink: {link}")
else:
printv(
"Detected --compilation_mode: none (no `./bazel-bin`), "
+ f"falling back to {build_mode}"
)
return build_mode
def main() -> None:
# Parse arguments.
parser = argparse.ArgumentParser(__doc__)
parser.add_argument("--non-fatal-checks", action="store_true")
parser.add_argument(
"--print_slowest_tests", default=0, help="Forwarded to file_test"
)
parser.add_argument("--threads", help="Forwarded to file_test")
parser.add_argument(
"--verbose", "-v", action="store_true", help="Produce verbose output"
)
parser.add_argument(
"--compilation-mode",
"-c",
help=(
"Compilation mode to use. The default is to detect the mode used "
"by the last bazel invocation"
),
choices=["dbg", "fastbuild", "opt"],
)
parser.add_argument("files", nargs="*")
args = parser.parse_args()
printv = print if args.verbose else lambda _: None
bazel = str(Path(__file__).parents[1] / "scripts" / "run_bazel.py")
configs = []
# Unless the user chose one explicitly, use the most recently-used build
# mode, or `fastbuild` if missing `bazel-bin`.
build_mode = args.compilation_mode or _detect_build_mode(bazel, printv)
if args.non_fatal_checks:
if build_mode == "optimize":
exit(
"`--non-fatal-checks` is incompatible with inferred "
"`-c optimize` build mode"
)
configs.append("--config=non-fatal-checks")
argv = [
bazel,
"run",
"-c",
build_mode,
*configs,
"--experimental_convenience_symlinks=ignore",
"--ui_event_filters=-info,-stdout,-stderr,-finish",
"//toolchain/testing:file_test",
"--",
"--autoupdate",
"--print_slowest_tests",
str(args.print_slowest_tests),
]
if args.threads:
argv += ["--threads", args.threads]
# Support specifying tests to update, such as:
# ./autoupdate_testdata.py lex/**/*
if args.files:
repo_root = Path(__file__).parents[1]
file_tests = []
# Filter down to just test files. Most are Carbon files, but some
# driver tests are C++ files.
for f in args.files:
if f.endswith((".carbon", ".cpp")):
path = str(Path(f).resolve().relative_to(repo_root))
if path.count("/testdata/"):
file_tests.append(path)
if not file_tests:
sys.exit(
"Args do not seem to be test files; for example, "
f"{args.files[0]}"
)
argv.append("--file_tests=" + ",".join(file_tests))
printv(shlex.join(argv))
# Provide an empty stdin so that the driver tests that read from stdin
# don't block waiting for input. This matches the behavior of `bazel test`.
result = subprocess.run(argv)
if result.returncode != 0:
sys.exit(
f"Command `{shlex.join(argv)}` failed with exit code "
f"`{result.returncode}`"
)
if __name__ == "__main__":
try:
main()
except KeyboardInterrupt:
sys.exit(1)