carbon-lang

mirror of https://github.com/carbon-language/carbon-lang.git synced 2026-10-02 06:45:49 +01:00

Files

T

Jon Ross-Perkins 27275e6729 Change the IdBase operator== to fix reversed operator warnings (#4636 )

I believe our flags enable the warning by default, it's just that it
doesn't catch this in clang-16 (maybe more; I reproduced with clang-18
and didn't keep digging). For example:

```
toolchain/parse/tree_test.cpp:86:28: error: ISO C++20 considers use of overloaded operator '==' (with operand types 'value_type' (aka 'Carbon::Parse::NodeIdInCategory<Carbon::Parse::NodeCategory::Decl>') and 'AnyDeclId' (aka 'NodeIdInCategory<NodeCategory::Decl>')) to be ambiguous despite there being a unique best viable function [-Werror,-Wambiguous-reversed-operator]
   86 |   EXPECT_TRUE(*any_decl_id == any_decl_id2);
      |               ~~~~~~~~~~~~ ^  ~~~~~~~~~~~~
```

The different `operator==` approach works except for with
`Parse::NodeId::Invalid`, which seems easy to replace with a
`.is_valid()` check.

2024-12-05 19:37:32 +00:00

BUILD

Follow-up to #4487 to fix file names (#4520 )

2024-11-13 18:10:52 +00:00

index_base.h

Change the IdBase operator== to fix reversed operator warnings (#4636 )

2024-12-05 19:37:32 +00:00

int_test.cpp

Follow-up to #4487 to fix file names (#4520 )

2024-11-13 18:10:52 +00:00

int.cpp

Follow-up to #4487 to fix file names (#4520 )