mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-11-15 22:28:14 +00:00
Christopher Di Bella
05a7ecbd34
Determining that a type has trivial destruction requires checking whether all of its subobjects have trivial destruction and whether its type has a custom witness for `Destroy.Op`. This isn't possible when `Destroy` is the custodian for `Destroy.Op` and `SubobjectDestroy.Op`, so we need to make `SubobjectDestroy` its own interface. `Destroy.SelfDestruct` becomes a standalone function because it depends on `SubobjectDestroy` and `Destroy` being implemented, and is also responsible for generating any custom witnesses for both interfaces. Making `SelfDestruct` an interface was experimented with, but this required a blanket impl that caused issues for facet types. `Destroy` depends on `SubobjectDestroy` to be implemented. We'd ideally use `require impls SubobjectDestroy`, but it isn't complete yet, and it also causes problems when `Destroy` is implemented inside the class definition. We work around this by temporarily renaming the `Destroy` interface to `DestroyImpl`, and introducing a constraint called `Destroy` so that user code doesn't need to write `Core.SubobjectDestroy & Core.Destroy`.
198 lines
6.5 KiB
Plaintext
198 lines
6.5 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// INCLUDE-FILE: toolchain/testing/testdata/min_prelude/int.carbon
|
|
//
|
|
// AUTOUPDATE
|
|
// TIP: To test this file alone, run:
|
|
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/check/testdata/interop/cpp/class/export/base.carbon
|
|
// TIP: To dump output, run:
|
|
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/check/testdata/interop/cpp/class/export/base.carbon
|
|
|
|
// --- derived_to_base.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import Cpp;
|
|
|
|
base class A {}
|
|
|
|
class B {
|
|
extend base: A;
|
|
}
|
|
|
|
inline Cpp '''
|
|
Carbon::A* Convert(Carbon::B* p) {
|
|
return p;
|
|
}
|
|
''';
|
|
|
|
// --- name_lookup.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import Cpp;
|
|
|
|
base class LookupBase {
|
|
fn F();
|
|
fn G(n: i32);
|
|
}
|
|
|
|
class LookupDerived {
|
|
extend base: LookupBase;
|
|
fn G();
|
|
}
|
|
|
|
inline Cpp '''
|
|
void Qualified() {
|
|
Carbon::LookupDerived::F();
|
|
Carbon::LookupDerived::G();
|
|
}
|
|
|
|
void MemberAccess(Carbon::LookupBase *a, Carbon::LookupDerived *b) {
|
|
b->F();
|
|
b->G();
|
|
}
|
|
''';
|
|
|
|
// --- fail_derive_from_final.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import Cpp;
|
|
|
|
class FinalClass {}
|
|
|
|
inline Cpp '''
|
|
// CHECK:STDERR: fail_derive_from_final.carbon:[[@LINE+3]]:12: error: base 'FinalClass' is marked 'final' [CppInteropParseError]
|
|
// CHECK:STDERR: fail_derive_from_final.carbon:[[@LINE-4]]:18: note: 'FinalClass' declared here [CppInteropParseNote]
|
|
// CHECK:STDERR:
|
|
struct A : Carbon::FinalClass {};
|
|
''';
|
|
|
|
// --- fail_abstract.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import Cpp;
|
|
|
|
// TODO: Add a way to give a class a virtual destructor without C++ interop.
|
|
inline Cpp '''
|
|
struct VirtualDestructor {
|
|
virtual ~VirtualDestructor() {}
|
|
};
|
|
''';
|
|
|
|
// CHECK:STDERR: fail_abstract.carbon:[[@LINE+3]]:1-34: error: cannot convert type `AbstractWithVdtor` into type implementing `Core.Destroy` [ConversionFailureTypeToFacet]
|
|
// CHECK:STDERR: min_prelude/parts/destroy.carbon:32:1-39: note: while deducing parameters of generic declared here [DeductionGenericHere]
|
|
// CHECK:STDERR:
|
|
abstract class AbstractWithVdtor {
|
|
extend base: Cpp.VirtualDestructor;
|
|
}
|
|
|
|
inline Cpp '''
|
|
// CHECK:STDERR: fail_abstract.carbon:[[@LINE+3]]:27: error: variable type 'Carbon::AbstractWithVdtor' (aka 'Carbon::Main::AbstractWithVdtor') is an abstract class [CppInteropParseError]
|
|
// CHECK:STDERR: fail_abstract.carbon:[[@LINE-6]]:34: note: unimplemented pure virtual method '~AbstractWithVdtor' in 'AbstractWithVdtor' [CppInteropParseNote]
|
|
// CHECK:STDERR:
|
|
Carbon::AbstractWithVdtor x;
|
|
''';
|
|
|
|
// --- fail_todo_abstract_nonvirtual_dtor.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import Cpp;
|
|
|
|
// TODO: Find a way to export this to C++ as an abstract class, despite not
|
|
// having a vptr.
|
|
// CHECK:STDERR: fail_todo_abstract_nonvirtual_dtor.carbon:[[@LINE+5]]:1-39: error: semantics TODO: `exporting abstract class with no abstract methods and non-virtual destructor to C++` [SemanticsTodo]
|
|
// CHECK:STDERR:
|
|
// CHECK:STDERR: fail_todo_abstract_nonvirtual_dtor.carbon:[[@LINE+3]]:1-39: error: cannot convert type `AbstractNonvirtualDtor` into type implementing `Core.Destroy` [ConversionFailureTypeToFacet]
|
|
// CHECK:STDERR: min_prelude/parts/destroy.carbon:32:1-39: note: while deducing parameters of generic declared here [DeductionGenericHere]
|
|
// CHECK:STDERR:
|
|
abstract class AbstractNonvirtualDtor {}
|
|
|
|
inline Cpp '''
|
|
class DerivedNonvirtualDtor : public Carbon::AbstractNonvirtualDtor {};
|
|
''';
|
|
|
|
// --- fail_todo_abstract_nonvirtual_dtor_but_virtual_fns.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import Cpp;
|
|
|
|
// TODO: We should support generating a base subobject destructor for an
|
|
// abstract class, even though we refuse to generate a complete object
|
|
// destructor.
|
|
// CHECK:STDERR: fail_todo_abstract_nonvirtual_dtor_but_virtual_fns.carbon:[[@LINE+3]]:1-41: error: cannot convert type `AbstractWithMethodNoVptr` into type implementing `Core.Destroy` [ConversionFailureTypeToFacet]
|
|
// CHECK:STDERR: min_prelude/parts/destroy.carbon:32:1-39: note: while deducing parameters of generic declared here [DeductionGenericHere]
|
|
// CHECK:STDERR:
|
|
abstract class AbstractWithMethodNoVptr {
|
|
abstract fn F(self);
|
|
}
|
|
|
|
inline Cpp '''
|
|
class DerivedWithMethodNoVptr : public Carbon::AbstractWithMethodNoVptr {
|
|
};
|
|
''';
|
|
|
|
// --- fail_variable_with_abstract_method.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import Cpp;
|
|
|
|
// TODO: We should support generating a base subobject destructor for an
|
|
// abstract class, even though we refuse to generate a complete object
|
|
// destructor.
|
|
// CHECK:STDERR: fail_variable_with_abstract_method.carbon:[[@LINE+3]]:1-35: error: cannot convert type `AbstractWithMethod` into type implementing `Core.Destroy` [ConversionFailureTypeToFacet]
|
|
// CHECK:STDERR: min_prelude/parts/destroy.carbon:32:1-39: note: while deducing parameters of generic declared here [DeductionGenericHere]
|
|
// CHECK:STDERR:
|
|
abstract class AbstractWithMethod {
|
|
abstract fn F(self);
|
|
}
|
|
|
|
inline Cpp '''
|
|
// CHECK:STDERR: fail_variable_with_abstract_method.carbon:[[@LINE+3]]:28: error: variable type 'Carbon::AbstractWithMethod' (aka 'Carbon::Main::AbstractWithMethod') is an abstract class [CppInteropParseError]
|
|
// CHECK:STDERR: fail_variable_with_abstract_method.carbon:[[@LINE-5]]:22: note: unimplemented pure virtual method 'F' in 'AbstractWithMethod' [CppInteropParseNote]
|
|
// CHECK:STDERR:
|
|
Carbon::AbstractWithMethod x_abstract;
|
|
''';
|
|
|
|
// --- fail_todo_abstract_method_overridden_in_cpp.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import Cpp;
|
|
|
|
// TODO: We should support generating a base subobject destructor for an
|
|
// abstract class, even though we refuse to generate a complete object
|
|
// destructor.
|
|
// CHECK:STDERR: fail_todo_abstract_method_overridden_in_cpp.carbon:[[@LINE+3]]:1-35: error: cannot convert type `AbstractToOverride` into type implementing `Core.Destroy` [ConversionFailureTypeToFacet]
|
|
// CHECK:STDERR: min_prelude/parts/destroy.carbon:32:1-39: note: while deducing parameters of generic declared here [DeductionGenericHere]
|
|
// CHECK:STDERR:
|
|
abstract class AbstractToOverride {
|
|
abstract fn F(ref self);
|
|
}
|
|
|
|
// A C++ class that overrides the abstract method can be instantiated.
|
|
inline Cpp '''
|
|
struct DerivedOverriding : Carbon::AbstractToOverride {
|
|
void F() & override {}
|
|
};
|
|
DerivedOverriding d;
|
|
''';
|
|
|
|
// --- override_virtual_dtor.carbon
|
|
library "[[@TEST_NAME]]";
|
|
|
|
import Cpp;
|
|
|
|
inline Cpp '''
|
|
struct BaseWithPureVdtor {
|
|
virtual ~BaseWithPureVdtor() = 0;
|
|
};
|
|
''';
|
|
|
|
class DerivedWithVdtor {
|
|
extend base: Cpp.BaseWithPureVdtor;
|
|
}
|
|
|
|
inline Cpp '''
|
|
Carbon::DerivedWithVdtor b;
|
|
''';
|