mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-04 06:31:04 +01:00
Jon Ross-PerkinsandChandler Carruth
7befe2ce9f
This switches most error printing to use diagnostics instead of direct stream writes, even when not a specific file diagnostic. I'm allowing empty filenames for this use-case. This allows a little more specific testing to validate coverage of output using the diagnostic coverage test. I'm adding a few tests to cover things that weren't previously tested. Separately, this also forces a little more standardization in format... considering how changes like #4568 show effort being spent to _mirror_ diagnostic style, my thought is now to just use diagnostic code where possible. Note this also allows incrementally better testing of the language server; I'm changing the crash fix from #4847 in favor of diagnostic testing. --------- Co-authored-by: Chandler Carruth <chandlerc@gmail.com>
35 lines
990 B
Python
35 lines
990 B
Python
# Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
# Exceptions. See /LICENSE for license information.
|
|
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test")
|
|
|
|
package(default_visibility = ["//visibility:public"])
|
|
|
|
cc_library(
|
|
name = "source_buffer",
|
|
srcs = ["source_buffer.cpp"],
|
|
hdrs = ["source_buffer.h"],
|
|
deps = [
|
|
"//common:error",
|
|
"//toolchain/diagnostics:diagnostic_emitter",
|
|
"//toolchain/diagnostics:file_diagnostics",
|
|
"//toolchain/diagnostics:format_providers",
|
|
"@llvm-project//llvm:Support",
|
|
],
|
|
)
|
|
|
|
cc_test(
|
|
name = "source_buffer_test",
|
|
size = "small",
|
|
srcs = ["source_buffer_test.cpp"],
|
|
deps = [
|
|
":source_buffer",
|
|
"//common:check",
|
|
"//testing/base:gtest_main",
|
|
"//toolchain/diagnostics:diagnostic_emitter",
|
|
"@googletest//:gtest",
|
|
"@llvm-project//llvm:Support",
|
|
],
|
|
)
|