mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-10-05 11:21:05 +01:00
This removes the separately built and installed LLD binary. The symlinks used by Clang when directly invoking LLD now point back to the main `carbon-busybox` binary and dispatch through the newly added subcommand. With this change we're down to shipping a single busybox binary in the toolchain, removing duplicate installed copies of LLD and all its LLVM dependencies. =] The LLD subcommand works a bit differently from the `clang` subcommand because the CLI for LLD is specific to which platform flavor of linker is being invoked. As part of this, I've extracted some of the common functionality in the Clang runner into a base class that can be re-used. I expect to use this again in a follow-up change to add subcommands to run other LLVM tools. --------- Co-authored-by: Jon Ross-Perkins <jperkins@google.com>
206 lines
5.7 KiB
Python
206 lines
5.7 KiB
Python
# Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
# Exceptions. See /LICENSE for license information.
|
|
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
load(
|
|
"@llvm-project//:vars.bzl",
|
|
"LLVM_VERSION_MAJOR",
|
|
)
|
|
load("@rules_cc//cc:defs.bzl", "cc_binary", "cc_library", "cc_test")
|
|
load("//bazel/cc_toolchains:defs.bzl", "cc_env")
|
|
load("//bazel/manifest:defs.bzl", "manifest")
|
|
load("install_filegroups.bzl", "install_filegroup", "install_symlink", "install_target", "make_install_filegroups")
|
|
load("pkg_helpers.bzl", "pkg_naming_variables", "pkg_tar_and_test")
|
|
|
|
package(default_visibility = ["//visibility:public"])
|
|
|
|
# Build rules supporting the install data tree for the Carbon toolchain.
|
|
#
|
|
# This populates a synthetic Carbon toolchain installation under the
|
|
# `prefix_root` directory. For details on its layout, see `install_dirs` below.
|
|
|
|
# A library for computing install paths for the toolchain. Note that this
|
|
# library does *not* include the data itself, as that would form a dependency
|
|
# cycle. Each part of the toolchain should add the narrow data file groups to
|
|
# their data dependencies, and then use this library to locate them.
|
|
cc_library(
|
|
name = "install_paths",
|
|
srcs = ["install_paths.cpp"],
|
|
hdrs = ["install_paths.h"],
|
|
deps = [
|
|
"//common:check",
|
|
"//common:error",
|
|
"@bazel_tools//tools/cpp/runfiles",
|
|
"@llvm-project//llvm:Support",
|
|
],
|
|
)
|
|
|
|
cc_binary(
|
|
name = "test_binary",
|
|
testonly = 1,
|
|
srcs = ["test_binary.cpp"],
|
|
data = [":install_data"],
|
|
)
|
|
|
|
cc_test(
|
|
name = "install_paths_test",
|
|
size = "small",
|
|
srcs = ["install_paths_test.cpp"],
|
|
data = [
|
|
":install_data",
|
|
":test_binary",
|
|
],
|
|
deps = [
|
|
":install_paths",
|
|
"//common:check",
|
|
"//common:ostream",
|
|
"//testing/base:global_exe_path",
|
|
"//testing/base:gtest_main",
|
|
"@bazel_tools//tools/cpp/runfiles",
|
|
"@googletest//:gtest",
|
|
"@llvm-project//llvm:Support",
|
|
],
|
|
)
|
|
|
|
cc_library(
|
|
name = "install_paths_test_helpers",
|
|
testonly = 1,
|
|
srcs = ["install_paths_test_helpers.cpp"],
|
|
hdrs = ["install_paths_test_helpers.h"],
|
|
deps = [
|
|
":install_paths",
|
|
"//testing/base:global_exe_path",
|
|
"@llvm-project//llvm:Support",
|
|
],
|
|
)
|
|
|
|
cc_library(
|
|
name = "busybox_info",
|
|
hdrs = ["busybox_info.h"],
|
|
deps = [
|
|
"//common:error",
|
|
"@llvm-project//llvm:Support",
|
|
],
|
|
)
|
|
|
|
cc_test(
|
|
name = "busybox_info_test",
|
|
size = "small",
|
|
srcs = ["busybox_info_test.cpp"],
|
|
deps = [
|
|
":busybox_info",
|
|
"//common:check",
|
|
"//testing/base:gtest_main",
|
|
"@googletest//:gtest",
|
|
"@llvm-project//llvm:Support",
|
|
],
|
|
)
|
|
|
|
# This target doesn't include prelude libraries. To get a target that has the
|
|
# prelude available, use //toolchain.
|
|
cc_binary(
|
|
name = "carbon-busybox",
|
|
srcs = ["busybox_main.cpp"],
|
|
env = cc_env(),
|
|
deps = [
|
|
":busybox_info",
|
|
":install_paths",
|
|
"//common:all_llvm_targets",
|
|
"//common:bazel_working_dir",
|
|
"//common:error",
|
|
"//common:exe_path",
|
|
"//common:init_llvm",
|
|
"//common:version_stamp",
|
|
"//toolchain/driver",
|
|
"@llvm-project//llvm:Support",
|
|
],
|
|
)
|
|
|
|
# TODO: Add remaining aliases of LLD for Windows and WASM when we have support
|
|
# for them wired up through the busybox.
|
|
lld_aliases = [
|
|
"ld.lld",
|
|
"ld64.lld",
|
|
]
|
|
|
|
filegroup(
|
|
name = "clang_headers",
|
|
srcs = ["@llvm-project//clang:builtin_headers_gen"],
|
|
)
|
|
|
|
# Given a root `prefix_root`, the hierarchy looks like:
|
|
#
|
|
# - prefix_root/bin: Binaries intended for direct use.
|
|
# - prefix_root/lib/carbon: Private data and files.
|
|
# - prefix_root/lib/carbon/core: The `Core` package files.
|
|
# - prefix_root/lib/carbon/llvm/bin: LLVM binaries.
|
|
#
|
|
# This will be how installs are provided on Unix-y platforms, and is loosely
|
|
# based on the FHS (Filesystem Hierarchy Standard).
|
|
install_dirs = {
|
|
"bin": [
|
|
install_symlink(
|
|
"carbon",
|
|
"../lib/carbon/carbon-busybox",
|
|
is_driver = True,
|
|
),
|
|
],
|
|
"lib/carbon": [
|
|
install_target("carbon_install.txt", "carbon_install.txt"),
|
|
install_target(
|
|
"carbon-busybox",
|
|
":carbon-busybox",
|
|
executable = True,
|
|
is_driver = True,
|
|
),
|
|
install_filegroup("core", "//core:prelude"),
|
|
],
|
|
"lib/carbon/llvm/bin": [
|
|
install_symlink(
|
|
"clang",
|
|
"../../carbon-busybox",
|
|
is_driver = True,
|
|
),
|
|
] + [install_symlink(
|
|
name,
|
|
"../../carbon-busybox",
|
|
is_driver = True,
|
|
) for name in lld_aliases],
|
|
"lib/carbon/llvm/lib/clang/" + LLVM_VERSION_MAJOR: [
|
|
install_filegroup("include", ":clang_headers", "staging/include/"),
|
|
],
|
|
}
|
|
|
|
make_install_filegroups(
|
|
name = "install_data",
|
|
install_dirs = install_dirs,
|
|
no_driver_name = "install_data.no_driver",
|
|
pkg_name = "pkg_data",
|
|
prefix = "prefix_root",
|
|
)
|
|
|
|
manifest(
|
|
name = "install_data_manifest.txt",
|
|
srcs = [":install_data"],
|
|
)
|
|
|
|
pkg_naming_variables(
|
|
name = "packaging_variables",
|
|
)
|
|
|
|
# We build both a compressed and uncompressed tar file with the same code here.
|
|
# This lets us use the tar file in testing as it is fast to create, but ship the
|
|
# compressed version as a release.
|
|
#
|
|
# For manual tests, the tar rules are `carbon_toolchain_tar_rule` and
|
|
# `carbon_toolchain_tar_gz_rule`.
|
|
pkg_tar_and_test(
|
|
srcs = [":pkg_data"],
|
|
install_data_manifest = ":install_data_manifest.txt",
|
|
name_base = "carbon_toolchain",
|
|
package_dir = "carbon_toolchain-$(version)",
|
|
package_file_name_base = "carbon_toolchain-$(version)",
|
|
package_variables = ":packaging_variables",
|
|
stamp = -1, # Allow `--stamp` builds to produce file timestamps.
|
|
)
|