Files
carbon-lang/toolchain/diagnostics/sorting_diagnostic_consumer.h
T
Jon Ross-Perkins 8ee0ecec94 Fix sorted output flakiness by using stable_sort (#2301)
Visible with bazel test //toolchain/parser/testdata:if/fail_errors.carbon.test --runs_per_test=20 (produces 2 errors on the same line)
2022-10-17 18:07:08 -07:00

48 lines
1.6 KiB
C++

// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
#ifndef CARBON_TOOLCHAIN_DIAGNOSTICS_SORTING_DIAGNOSTIC_CONSUMER_H_
#define CARBON_TOOLCHAIN_DIAGNOSTICS_SORTING_DIAGNOSTIC_CONSUMER_H_
#include "common/check.h"
#include "llvm/ADT/STLExtras.h"
#include "toolchain/diagnostics/diagnostic_emitter.h"
namespace Carbon {
// Buffers incoming diagnostics for printing and sorting.
class SortingDiagnosticConsumer : public DiagnosticConsumer {
public:
explicit SortingDiagnosticConsumer(DiagnosticConsumer& next_consumer)
: next_consumer_(&next_consumer) {}
~SortingDiagnosticConsumer() override { Flush(); }
// Buffers the diagnostic.
auto HandleDiagnostic(const Diagnostic& diagnostic) -> void override {
diagnostics_.push_back(diagnostic);
}
// Sorts and flushes buffered diagnostics.
void Flush() override {
llvm::stable_sort(diagnostics_, [](const Diagnostic& lhs,
const Diagnostic& rhs) {
return std::tie(lhs.location.line_number, lhs.location.column_number) <
std::tie(rhs.location.line_number, rhs.location.column_number);
});
for (const auto& diagnostic : diagnostics_) {
next_consumer_->HandleDiagnostic(diagnostic);
}
diagnostics_.clear();
}
private:
llvm::SmallVector<Diagnostic, 0> diagnostics_;
DiagnosticConsumer* next_consumer_;
};
} // namespace Carbon
#endif // CARBON_TOOLCHAIN_DIAGNOSTICS_SORTING_DIAGNOSTIC_CONSUMER_H_