Dana Jansens
b705be9527
Use a Timings* in place of optional<Timings>* ( #4607 )
...
The current representation has two nested presence indicatators (the
optional bool, the null pointer). Currently the pointer is never null,
but the style guide suggests that T* should be used for parameters that
may or may not be present, so we do not need the optional here.
> When passing an object's address as an argument, use a reference
> unless one of the following cases applies:
>
> - If the parameter is optional, use a pointer and document that it
> may be null.
Once the parameter is just a pointer, the ScopedTiming field does not
need an optional either, and can just store the pointer.
It would be more preferable to have an optional representation of a
sometimes-null pointer like optional<T&> to describe a sometimes-null
pointer, as this would allow clearer runtime diagnostics when used
incorrectly (a check failure in unwrapping) and would be better
self-documenting through syntax instead of a comment. But we do not
currently have such a primitive.
2024-12-03 19:01:12 +00:00
..
2024-05-21 20:33:20 +00:00
2024-12-03 18:46:27 +00:00
2024-12-03 18:46:27 +00:00
2024-11-22 18:34:21 +00:00
2024-09-05 23:39:58 +00:00
2024-11-18 22:28:57 +00:00
2024-11-22 16:51:10 +00:00
2024-12-03 19:01:12 +00:00
2024-12-03 18:46:27 +00:00
2024-12-03 18:46:27 +00:00
2024-11-27 22:26:30 +00:00
2024-11-19 20:37:39 +00:00
2024-09-12 16:42:08 +00:00
2024-12-02 20:06:01 +00:00
2024-11-22 18:34:21 +00:00
2024-11-25 23:50:56 +00:00
2024-10-08 22:17:37 +00:00
2024-11-20 20:58:58 +00:00
2024-11-20 20:58:58 +00:00
2024-10-07 22:55:26 +00:00
2024-11-27 22:26:30 +00:00
2024-07-25 16:42:01 +00:00
2024-10-12 15:17:42 +00:00
2024-08-09 01:05:03 +00:00
2024-07-03 16:58:47 +00:00
2024-07-03 16:58:47 +00:00
2024-10-21 19:53:38 +00:00
2024-10-21 19:53:38 +00:00
2024-11-22 18:34:21 +00:00
2024-07-03 17:49:47 +00:00
2024-11-19 20:37:39 +00:00
2024-11-19 20:37:39 +00:00
2024-11-26 18:16:25 +00:00
2024-12-02 18:51:44 +00:00
2024-07-12 22:38:06 +00:00
2024-11-27 22:26:30 +00:00
2024-07-12 22:38:06 +00:00
2024-09-25 19:12:58 +00:00
2024-07-12 22:38:06 +00:00
2024-07-12 22:38:06 +00:00
2024-12-03 18:46:27 +00:00
2024-12-03 18:46:27 +00:00
2024-09-12 16:42:08 +00:00
2024-11-22 18:34:21 +00:00
2024-08-19 22:12:21 +00:00
2024-12-03 18:46:27 +00:00
2024-11-11 18:01:50 +00:00
2024-11-19 20:37:39 +00:00
2024-12-03 18:46:27 +00:00
2024-09-19 21:32:53 +00:00
2024-07-12 22:38:06 +00:00
2024-09-19 21:32:53 +00:00
2024-10-07 22:55:26 +00:00
2024-07-12 22:38:06 +00:00
2024-09-25 19:12:58 +00:00
2024-09-12 16:42:08 +00:00
2024-11-19 20:37:39 +00:00
2024-07-12 22:38:06 +00:00
2024-07-23 20:32:24 +00:00
2024-07-12 22:38:06 +00:00
2024-11-19 20:37:39 +00:00
2024-07-12 22:38:06 +00:00
2024-11-19 20:37:39 +00:00
2024-07-12 22:38:06 +00:00
2024-12-02 18:49:30 +00:00
2024-10-22 17:19:21 +00:00
2024-11-21 22:29:53 +00:00
2024-03-07 23:10:14 +00:00
2024-11-28 00:13:21 +00:00
2024-10-26 00:38:24 +00:00
2024-09-19 21:32:53 +00:00
2024-07-24 19:56:17 +00:00
2024-11-07 16:22:36 +00:00
2024-11-07 16:22:36 +00:00
2024-11-19 20:37:39 +00:00
2024-02-28 01:56:27 +00:00
2024-09-11 00:03:25 +00:00
2024-11-04 04:00:17 +00:00
2024-12-03 18:46:27 +00:00
2024-12-03 18:46:27 +00:00
2024-11-27 22:26:30 +00:00
2024-10-07 17:25:35 +00:00
2024-11-21 22:29:53 +00:00
2024-10-16 19:15:29 +00:00
2024-10-17 22:47:40 +00:00
2024-10-17 22:47:40 +00:00
2024-11-22 18:34:21 +00:00
2024-11-22 18:34:21 +00:00
2024-11-20 20:58:58 +00:00
2024-11-20 20:58:58 +00:00
2024-11-07 16:22:36 +00:00
2024-11-07 16:22:36 +00:00
2024-11-19 20:37:39 +00:00
2024-10-07 17:25:35 +00:00
2024-11-07 16:22:36 +00:00
2024-11-22 18:34:21 +00:00
2024-11-22 18:34:21 +00:00
2024-08-29 21:10:14 +00:00
2024-11-27 22:26:30 +00:00
2024-03-18 17:40:00 +00:00
2024-11-19 20:37:39 +00:00
2024-03-09 00:21:29 +00:00
2024-01-25 18:19:22 +00:00
2024-11-19 20:37:39 +00:00
2024-09-25 17:06:09 +00:00
2024-11-22 16:51:10 +00:00
2024-11-22 16:51:10 +00:00
2024-11-13 01:20:07 +00:00
2024-08-09 01:05:03 +00:00