Files
carbon-lang/toolchain/install/install_paths_test.cpp
T
Chandler CarruthandJon Ross-Perkins d3a5b0eee7 Add utilities for managing a toolchain install, and install and use LLD. (#3993)
The install directory contains the BUILD logic for creating an
installable tree of data files and executables for the toolchain, and
a library to facilitate toolchain code accessing the paths to their data
within this installation.

Then adds an installation of LLD in a synthetic LLVM installation, and
teaches the Clang runner to configure this and use it for linking
instead of the system linker.

Currently, the install paths only really manage access to the LLVM
binaries installed and used by the Clang runner for linking, but
eventually other data files like the prelude and runtime libraries will
be fleshed out as well. There are TODOs for moving more things over here
such as the prelude.

One interesting aspect of this is where to put helpers like parts of
LLVM in our install. This PR suggests nesting those files under
`lib/carbon`. While using a `lib` subdirectory isn't a perfect fit for
the FHS (Filesystem Hierarchy Standard), having a single location where
private data is collected is significantly superior to spreading them
across the system. This also matches similar patterns used by Clang
itself and several other language toolchains and standard libraries.

The install directory also provides a natural place for us to build out
packaging rules to create installable packages in various formats, but
that remains future work.

---------

Co-authored-by: Jon Ross-Perkins <jperkins@google.com>
2024-06-01 03:19:52 +00:00

131 lines
4.6 KiB
C++

// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
// Exceptions. See /LICENSE for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
#include "toolchain/install/install_paths.h"
#include <gmock/gmock.h>
#include <gtest/gtest.h>
#include "common/check.h"
#include "llvm/ADT/SmallString.h"
#include "llvm/Support/FileSystem.h"
#include "llvm/Support/FormatVariadic.h"
#include "llvm/Support/Path.h"
#include "testing/base/gtest_main.h"
#include "tools/cpp/runfiles/runfiles.h"
namespace Carbon {
namespace {
using ::bazel::tools::cpp::runfiles::Runfiles;
using ::testing::Eq;
using ::testing::HasSubstr;
using ::testing::Optional;
using ::testing::StartsWith;
class InstallPathsTest : public ::testing::Test {
protected:
InstallPathsTest() {
std::string error;
test_runfiles_.reset(
Runfiles::Create(Testing::GetTestExePath().str(), &error));
CARBON_CHECK(test_runfiles_ != nullptr) << error;
}
// Test the install paths found with the given `exe_path`. Will check that
// the detected install prefix path starts with `prefix_startswith`, and then
// check that the path accessors point to the right kind of file or
// directory.
auto TestInstallPaths(const InstallPaths& paths) -> void {
SCOPED_TRACE(llvm::formatv("Install prefix: '%s'", paths.prefix()));
// Grab a the prefix into a string to make it easier to use in the test.
std::string prefix = paths.prefix().str();
EXPECT_TRUE(llvm::sys::fs::exists(prefix));
EXPECT_TRUE(llvm::sys::fs::is_directory(prefix));
// Now check that all the expected parts of the toolchain's install are in
// fact found using the API.
std::string driver_path = paths.driver();
ASSERT_THAT(driver_path, StartsWith(prefix));
EXPECT_TRUE(llvm::sys::fs::exists(driver_path)) << "path: " << driver_path;
EXPECT_TRUE(llvm::sys::fs::can_execute(driver_path))
<< "path: " << driver_path;
std::string llvm_bin_path = paths.llvm_install_bin();
ASSERT_THAT(llvm_bin_path, StartsWith(prefix));
EXPECT_TRUE(llvm::sys::fs::exists(llvm_bin_path))
<< "path: " << llvm_bin_path;
EXPECT_TRUE(llvm::sys::fs::is_directory(llvm_bin_path))
<< "path: " << llvm_bin_path;
for (llvm::StringRef llvm_bin :
{"lld", "ld.lld", "ld64.lld", "lld-link", "wasm-ld"}) {
llvm::SmallString<128> bin_path;
bin_path.assign(llvm_bin_path);
llvm::sys::path::append(bin_path, llvm_bin);
EXPECT_TRUE(llvm::sys::fs::exists(bin_path)) << "path: " << bin_path;
EXPECT_TRUE(llvm::sys::fs::can_execute(bin_path)) << "path: " << bin_path;
}
}
std::unique_ptr<Runfiles> test_runfiles_;
};
TEST_F(InstallPathsTest, PrefixRootDriver) {
std::string installed_driver_path = test_runfiles_->Rlocation(
"_main/toolchain/install/prefix_root/bin/carbon");
auto paths = InstallPaths::MakeExeRelative(installed_driver_path);
ASSERT_THAT(paths.error(), Eq(std::nullopt)) << *paths.error();
TestInstallPaths(paths);
}
TEST_F(InstallPathsTest, PrefixRootExplicit) {
std::string marker_path = test_runfiles_->Rlocation(
"_main/toolchain/install/prefix_root/lib/carbon/carbon_install.txt");
llvm::StringRef prefix_path = marker_path;
CARBON_CHECK(prefix_path.consume_back("lib/carbon/carbon_install.txt"))
<< "Unexpected suffix of the marker path: " << marker_path;
auto paths = InstallPaths::Make(prefix_path);
ASSERT_THAT(paths.error(), Eq(std::nullopt)) << *paths.error();
TestInstallPaths(paths);
}
TEST_F(InstallPathsTest, TestRunfiles) {
auto paths = InstallPaths::MakeForBazelRunfiles(Testing::GetTestExePath());
ASSERT_THAT(paths.error(), Eq(std::nullopt)) << *paths.error();
TestInstallPaths(paths);
}
TEST_F(InstallPathsTest, BinaryRunfiles) {
std::string test_binary_path =
test_runfiles_->Rlocation("_main/toolchain/install/test_binary");
CARBON_CHECK(llvm::sys::fs::can_execute(test_binary_path))
<< test_binary_path;
auto paths = InstallPaths::MakeForBazelRunfiles(test_binary_path);
ASSERT_THAT(paths.error(), Eq(std::nullopt)) << *paths.error();
TestInstallPaths(paths);
}
TEST_F(InstallPathsTest, Errors) {
auto paths = InstallPaths::Make("foo/bar/baz");
EXPECT_THAT(paths.error(), Optional(HasSubstr("foo/bar/baz")));
EXPECT_THAT(paths.prefix(), Eq(""));
paths = InstallPaths::MakeExeRelative("foo/bar/baz");
EXPECT_THAT(paths.error(), Optional(HasSubstr("foo/bar/baz")));
EXPECT_THAT(paths.prefix(), Eq(""));
// Note that we can't test the runfiles code path from within a test because
// it succeeds some of the time even with a bogus executable name.
}
} // namespace
} // namespace Carbon