mirror of
https://github.com/carbon-language/carbon-lang.git
synced 2026-09-24 19:10:14 +01:00
Dana Jansens
d2ac9b3933
This is in addition to finding a `where` on the RHS of another `where`. Since a generic binding introduces `.Self`, any `where` expression that isn't part of a facet type modifying the binding itself would introduce an ambiguous `.Self`. Add virtual parse nodes for let, var, and form bindings, which goes before the type. This allows us to track if `where` appears in the binding's type. We only need to look for an invalid `where` if any appeared in the type. We combine these three nodes together into a single node kind, which requires us to remove the name from it as a child. We move it up to the Pattern node again, and rename the PatternStart nodes to PatternTypeStart as they are now located in the middle of the Pattern nodes, just before the type. And we only need to thaw `.Self` in generic bindings. Non-generic bindings can only have `.Self` through a `where` expression, since the name is not provided otherwise to non-generic bindings. And `where` expressions thaw their `.Self` independently. So the binding only needs to thaw a `.Self` that it introduced, which is only for generic bindings.
97 lines
6.2 KiB
Plaintext
97 lines
6.2 KiB
Plaintext
// Part of the Carbon Language project, under the Apache License v2.0 with LLVM
|
|
// Exceptions. See /LICENSE for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
// AUTOUPDATE
|
|
// TIP: To test this file alone, run:
|
|
// TIP: bazel test //toolchain/testing:file_test --test_arg=--file_tests=toolchain/parse/testdata/basics/fail_bracket_recovery.carbon
|
|
// TIP: To dump output, run:
|
|
// TIP: bazel run //toolchain/testing:file_test -- --dump_output --file_tests=toolchain/parse/testdata/basics/fail_bracket_recovery.carbon
|
|
|
|
// This is a valid parse tree even though the lex errors.
|
|
fn F() {
|
|
var a: array(i32, 3) = (0, 1, 2);
|
|
// CHECK:STDERR: fail_bracket_recovery.carbon:[[@LINE+4]]:5: error: opening symbol without a corresponding closing symbol [UnmatchedOpening]
|
|
// CHECK:STDERR: (a[1) + 1;
|
|
// CHECK:STDERR: ^
|
|
// CHECK:STDERR:
|
|
(a[1) + 1;
|
|
// CHECK:STDERR: fail_bracket_recovery.carbon:[[@LINE+12]]:15: error: opening symbol without a corresponding closing symbol [UnmatchedOpening]
|
|
// CHECK:STDERR: var x: {.y: (} = {.y = ((};
|
|
// CHECK:STDERR: ^
|
|
// CHECK:STDERR:
|
|
// CHECK:STDERR: fail_bracket_recovery.carbon:[[@LINE+8]]:26: error: opening symbol without a corresponding closing symbol [UnmatchedOpening]
|
|
// CHECK:STDERR: var x: {.y: (} = {.y = ((};
|
|
// CHECK:STDERR: ^
|
|
// CHECK:STDERR:
|
|
// CHECK:STDERR: fail_bracket_recovery.carbon:[[@LINE+4]]:27: error: opening symbol without a corresponding closing symbol [UnmatchedOpening]
|
|
// CHECK:STDERR: var x: {.y: (} = {.y = ((};
|
|
// CHECK:STDERR: ^
|
|
// CHECK:STDERR:
|
|
var x: {.y: (} = {.y = ((};
|
|
}
|
|
|
|
// CHECK:STDOUT: - filename: fail_bracket_recovery.carbon
|
|
// CHECK:STDOUT: parse_tree: [
|
|
// CHECK:STDOUT: {kind: 'FileStart', text: ''},
|
|
// CHECK:STDOUT: {kind: 'FunctionIntroducer', text: 'fn'},
|
|
// CHECK:STDOUT: {kind: 'IdentifierNameMaybeBeforeSignature', text: 'F'},
|
|
// CHECK:STDOUT: {kind: 'ExplicitParamListStart', text: '('},
|
|
// CHECK:STDOUT: {kind: 'ExplicitParamList', text: ')', subtree_size: 2},
|
|
// CHECK:STDOUT: {kind: 'FunctionDefinitionStart', text: '{', subtree_size: 5},
|
|
// CHECK:STDOUT: {kind: 'VariableIntroducer', text: 'var'},
|
|
// CHECK:STDOUT: {kind: 'IdentifierNameNotBeforeSignature', text: 'a'},
|
|
// CHECK:STDOUT: {kind: 'BindingPatternTypeStart', text: ':'},
|
|
// CHECK:STDOUT: {kind: 'ArrayExprKeyword', text: 'array'},
|
|
// CHECK:STDOUT: {kind: 'ArrayExprOpenParen', text: '('},
|
|
// CHECK:STDOUT: {kind: 'IntTypeLiteral', text: 'i32'},
|
|
// CHECK:STDOUT: {kind: 'ArrayExprComma', text: ','},
|
|
// CHECK:STDOUT: {kind: 'IntLiteral', text: '3'},
|
|
// CHECK:STDOUT: {kind: 'ArrayExpr', text: ')', subtree_size: 6},
|
|
// CHECK:STDOUT: {kind: 'VarBindingPattern', text: ':', subtree_size: 9},
|
|
// CHECK:STDOUT: {kind: 'VariablePattern', text: 'var', subtree_size: 10},
|
|
// CHECK:STDOUT: {kind: 'VariableInitializer', text: '='},
|
|
// CHECK:STDOUT: {kind: 'TupleLiteralStart', text: '('},
|
|
// CHECK:STDOUT: {kind: 'IntLiteral', text: '0'},
|
|
// CHECK:STDOUT: {kind: 'TupleLiteralComma', text: ','},
|
|
// CHECK:STDOUT: {kind: 'IntLiteral', text: '1'},
|
|
// CHECK:STDOUT: {kind: 'TupleLiteralComma', text: ','},
|
|
// CHECK:STDOUT: {kind: 'IntLiteral', text: '2'},
|
|
// CHECK:STDOUT: {kind: 'TupleLiteral', text: ')', subtree_size: 7},
|
|
// CHECK:STDOUT: {kind: 'VariableDecl', text: ';', subtree_size: 20},
|
|
// CHECK:STDOUT: {kind: 'ParenExprStart', text: '('},
|
|
// CHECK:STDOUT: {kind: 'IdentifierNameExpr', text: 'a'},
|
|
// CHECK:STDOUT: {kind: 'IndexExprStart', text: '[', subtree_size: 2},
|
|
// CHECK:STDOUT: {kind: 'IntLiteral', text: '1'},
|
|
// CHECK:STDOUT: {kind: 'IndexExpr', text: ']', subtree_size: 4},
|
|
// CHECK:STDOUT: {kind: 'ParenExpr', text: ')', subtree_size: 6},
|
|
// CHECK:STDOUT: {kind: 'IntLiteral', text: '1'},
|
|
// CHECK:STDOUT: {kind: 'InfixOperatorPlus', text: '+', subtree_size: 8},
|
|
// CHECK:STDOUT: {kind: 'ExprStatement', text: ';', subtree_size: 9},
|
|
// CHECK:STDOUT: {kind: 'VariableIntroducer', text: 'var'},
|
|
// CHECK:STDOUT: {kind: 'IdentifierNameNotBeforeSignature', text: 'x'},
|
|
// CHECK:STDOUT: {kind: 'BindingPatternTypeStart', text: ':'},
|
|
// CHECK:STDOUT: {kind: 'StructTypeLiteralStart', text: '{'},
|
|
// CHECK:STDOUT: {kind: 'IdentifierNameNotBeforeSignature', text: 'y'},
|
|
// CHECK:STDOUT: {kind: 'StructFieldDesignator', text: '.', subtree_size: 2},
|
|
// CHECK:STDOUT: {kind: 'TupleLiteralStart', text: '('},
|
|
// CHECK:STDOUT: {kind: 'TupleLiteral', text: ')', subtree_size: 2},
|
|
// CHECK:STDOUT: {kind: 'StructTypeLiteralField', text: ':', subtree_size: 5},
|
|
// CHECK:STDOUT: {kind: 'StructTypeLiteral', text: '}', subtree_size: 7},
|
|
// CHECK:STDOUT: {kind: 'VarBindingPattern', text: ':', subtree_size: 10},
|
|
// CHECK:STDOUT: {kind: 'VariablePattern', text: 'var', subtree_size: 11},
|
|
// CHECK:STDOUT: {kind: 'VariableInitializer', text: '='},
|
|
// CHECK:STDOUT: {kind: 'StructLiteralStart', text: '{'},
|
|
// CHECK:STDOUT: {kind: 'IdentifierNameNotBeforeSignature', text: 'y'},
|
|
// CHECK:STDOUT: {kind: 'StructFieldDesignator', text: '.', subtree_size: 2},
|
|
// CHECK:STDOUT: {kind: 'ParenExprStart', text: '('},
|
|
// CHECK:STDOUT: {kind: 'TupleLiteralStart', text: '('},
|
|
// CHECK:STDOUT: {kind: 'TupleLiteral', text: ')', subtree_size: 2},
|
|
// CHECK:STDOUT: {kind: 'ParenExpr', text: ')', subtree_size: 4},
|
|
// CHECK:STDOUT: {kind: 'StructLiteralField', text: '=', subtree_size: 7},
|
|
// CHECK:STDOUT: {kind: 'StructLiteral', text: '}', subtree_size: 9},
|
|
// CHECK:STDOUT: {kind: 'VariableDecl', text: ';', subtree_size: 23},
|
|
// CHECK:STDOUT: {kind: 'FunctionDefinition', text: '}', subtree_size: 58},
|
|
// CHECK:STDOUT: {kind: 'FileEnd', text: ''},
|
|
// CHECK:STDOUT: ]
|